Remove unused deprecated dependencies#571
Merged
Merged
Conversation
|
Review changes with Changed Files
|
Contributor
|
joanise
force-pushed
the
dev.ej/deprecations
branch
from
997ef15 to
c5fa02a
Compare
joanise
force-pushed
the
dev.ej/deprecations
branch
2 times, most recently
from
bdb4bb8 to
53474e4
Compare
….module.ts With Angular 21, provideZoneChangeDetection is required, otherwise our microphone buttons don't work properly, but with the deprecated platform-browser-dynamic, that belonged in main.ts, while with the recommended platform-browser, it has to be moved to the NgModule's provides in app.module.ts.
joanise
force-pushed
the
dev.ej/deprecations
branch
from
53474e4 to
8b5abf7
Compare
sergeleger
approved these changes
Jun 25, 2026
sergeleger
left a comment
sergeleger
left a comment
Collaborator
There was a problem hiding this comment.
Most of this looks familiar with my WW angular upgrades. Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
When we run
npm install, a number of deprecations are reported. Some of them we still use, but some we don't anymore. This PR removed unused deprecated dependencies.Feedback sought?
Sanity checking
Priority?
normal
Tests added?
Already tested in CI
How to test?
See that CI passes.
Confidence?
high
Version change?
no