Skip to content

fix: make pause at end of page work with any translation #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joanise merged 1 commit into from
Jun 26, 2026
Merged

fix: make pause at end of page work with any translation #579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/web-component/src/components/read-along-component/read-along.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1125,7 +1125,8 @@ export class ReadAlongComponent {
const sentences = paragraphs[
paragraphs.length - 1
].querySelectorAll(
"s:not(.translation), s:not(.sentence__translation)",
// chain the not statements so they are ANDed: exclude sentences matching any of these criteria
's:not(.translation):not(.sentence__translation):not([do-not-align="true"])',
); //get non-translation sentences in the last paragraph
const word =
sentences[sentences.length - 1].querySelector("w:last-of-type"); //get the last word of the last sentence
Expand Down
Loading