fix(greader): stop sync from undoing mark all as read#1272
Closed
amerkay wants to merge 1 commit intoReadYouApp:mainfrom
Closed
fix(greader): stop sync from undoing mark all as read#1272amerkay wants to merge 1 commit intoReadYouApp:mainfrom
amerkay wants to merge 1 commit intoReadYouApp:mainfrom
Conversation
markAsRead pushed only locally-known IDs via edit-tag, so unread items only on the server stayed unread and got flipped back on the next sync. Use the bulk mark-all-as-read endpoint instead.
Author
|
This broke it when you use the "Mark all as read" feature when offline. Stack trace when offlineVersion: 0.16.1 Device: Google Pixel 6a System: Android 16 (API 36) Stack trace: I see there was an attempt to fix: I will investigate and report back with a better pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GoogleReaderRssService.markAsReadfrom per-IDedit-tagcalls to the server'smark-all-as-readstream endpoint.Why
The old flow pushed only IDs the local database knew about. Articles unread on the server but missing locally (pagination, archive, mid-sync) stayed unread, and the next sync flipped them back to unread on the client - producing the
515 → 0 → 1796 → 0 → 515cycle described in #1271 and mentioned/related to #1157 (comment)Scope
beforetimestamp): now usesgoogleReaderAPI.markAllAsRead(streamId, ts)againstAllItems/Feed/Category.editTag.The endpoint is part of the standard Google Reader API. Verified against Miniflux only; behavior against other Google Reader / FreshRSS backends has not been tested but should be no worse than the current per-ID approach.
Closes #1271
Tested