Skip to content

fix(greader): stop sync from undoing mark all as read #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amerkay wants to merge 1 commit into from
Closed

fix(greader): stop sync from undoing mark all as read #1272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions app/src/main/java/me/ash/reader/domain/service/GoogleReaderRssService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -773,6 +773,26 @@ constructor(
) {
val accountId = accountService.getCurrentAccountId()
val googleReaderAPI = getGoogleReaderAPI()

// The server can have unread items we don't have locally yet. Marking by ID
// misses those, and the next sync flips them back to unread. Mark the whole
// stream on the server instead using markAllAsRead.
if (!isUnread && articleId == null) {
val streamTag =
when {
groupId != null ->
GoogleReaderAPI.Stream.Category(groupId.dollarLast()).tag
feedId != null -> GoogleReaderAPI.Stream.Feed(feedId.dollarLast()).tag
else -> GoogleReaderAPI.Stream.AllItems.tag
}
super.markAsRead(groupId, feedId, articleId, before, isUnread)
googleReaderAPI.markAllAsRead(
streamId = streamTag,
sinceTimestamp = before?.time?.times(1000L),
)
return
}

val markList: List<String> =
when {
groupId != null -> {
Expand Down
Loading