Skip to content

Enable interactive provision of password#731

Open
jmcp wants to merge 1 commit into
ReagentX:developfrom
jmcp:feature/issue-730
Open

Enable interactive provision of password#731
jmcp wants to merge 1 commit into
ReagentX:developfrom
jmcp:feature/issue-730

Conversation

@jmcp
Copy link
Copy Markdown

@jmcp jmcp commented Apr 25, 2026

Adds support for providing a password interactively rather than on the command line.

@ReagentX
Copy link
Copy Markdown
Owner

Thank you for your contribution! The first thing that comes to mind is that this shouldn't be another CLI flag; rather, if we detect the backup is encrypted and the user did not pass -x, it should automatically request them to enter the password. What are your thoughts?

@ReagentX
Copy link
Copy Markdown
Owner

Are we sure rpassword is the best dependency add here?

@jmcp
Copy link
Copy Markdown
Author

jmcp commented Apr 26, 2026

Are we sure rpassword is the best dependency add here?

I don't know for sure, it's the first crate that was suggested when I went looking for a getpass() equivalent. I'm coming from the C and Python worlds where I'm very familiar with the standard libraries, still feeling my way with Rust.

Do you have a different suggestion? Very happy to try one

@jmcp
Copy link
Copy Markdown
Author

jmcp commented Apr 26, 2026

Thank you for your contribution! The first thing that comes to mind is that this shouldn't be another CLI flag; rather, if we detect the backup is encrypted and the user did not pass -x, it should automatically request them to enter the password. What are your thoughts?

That's a good point. I'll implement that and republish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants