You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you for your contribution! The first thing that comes to mind is that this shouldn't be another CLI flag; rather, if we detect the backup is encrypted and the user did not pass -x, it should automatically request them to enter the password. What are your thoughts?
Are we sure rpassword is the best dependency add here?
I don't know for sure, it's the first crate that was suggested when I went looking for a getpass() equivalent. I'm coming from the C and Python worlds where I'm very familiar with the standard libraries, still feeling my way with Rust.
Do you have a different suggestion? Very happy to try one
Thank you for your contribution! The first thing that comes to mind is that this shouldn't be another CLI flag; rather, if we detect the backup is encrypted and the user did not pass -x, it should automatically request them to enter the password. What are your thoughts?
That's a good point. I'll implement that and republish
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for providing a password interactively rather than on the command line.