fix: BrowseCustomRobloxIconLocation applying changes to bootstrapper custom icon

Author: returnrqt

Bloxstrap/Integrations/WindowManipulation.cs

@@ -9,7 +9,7 @@ namespace Bloxstrap.Integrations
 {
     public class WindowManipulation
     {
-        private WINEVENTPROC _setTitleHook;
+        private WINEVENTPROC? _setTitleHook;
 
         private HWND _hWnd;
         private uint _robloxPID;

Bloxstrap/Resources/Strings.Designer.cs

@@ -1808,4 +1808,16 @@ Defaulting to {1}.</value>
   <data name="Menu.Integrations.MultiInstanceLaunching.Warning" xml:space="preserve">
     <value>Multi-Instancing is prone to breaking. We will not provide support for issues with Multi-Instancing, since Roblox is actively adding measures to make sure it doesn't work. We cannot and won't attempt to bypass these measures.</value>
   </data>
+  <data name="Menu.Appearance.RobloxTitle.Title" xml:space="preserve">
+    <value>Roblox title</value>
+  </data>
+	<data name="Menu.Appearance.RobloxTitle.Description" xml:space="preserve">
+    <value>Choose what title Roblox window should have.</value>
+  </data>
+  <data name="Menu.Appearance.RobloxIcon.Title" xml:space="preserve">
+    <value>Roblox icon</value>
+  </data>
+  <data name="Menu.Appearance.RobloxIcon.Description" xml:space="preserve">
+    <value>Choose what icon Roblox should display on the taskbar.</value>
+  </data>
 </root>

Bloxstrap/Resources/Strings.resx

@@ -32,11 +32,11 @@
         </controls:OptionControl>
         <TextBlock Text="Roblox" FontSize="20" FontWeight="Medium" Margin="0,16,0,0" />
 
-        <controls:OptionControl Header="Set Roblox Title" Description="Set the title for the Roblox window.">
+        <controls:OptionControl Header="{x:Static resources:Strings.Menu_Appearance_RobloxTitle_Title}" Description="{x:Static resources:Strings.Menu_Appearance_RobloxTitle_Description}">
             <ui:TextBox PlaceholderText="Roblox" Width="200" Text="{Binding WindowTitle, Mode=TwoWay}" />
         </controls:OptionControl>
 
-        <controls:OptionControl Header="Set Roblox Icon" Description="Set the titlebar and taskbar icon for the Roblox window.">
+        <controls:OptionControl Header="{x:Static resources:Strings.Menu_Appearance_RobloxIcon_Title}" Description="{x:Static resources:Strings.Menu_Appearance_RobloxIcon_Description}">
             <ComboBox Width="200" Padding="10,5,10,5" ItemsSource="{Binding RobloxIcons, Mode=OneWay}" SelectedValuePath="IconType" SelectedValue="{Binding RobloxIcon, Mode=TwoWay}">
                 <ComboBox.ItemTemplate>
                     <DataTemplate>
@@ -53,7 +53,7 @@
             </ComboBox>
         </controls:OptionControl>
 
-        <controls:OptionControl Header="Custom Icon" Description="Set a custom icon instead of using a preset. NOTE: Icon must be a multi-size .ico file">
+        <controls:OptionControl Header="{x:Static resources:Strings.Menu_Appearance_CustomisationIcon_Title}" Description="{x:Static resources:Strings.Menu_Appearance_CustomisationIcon_Description}">
             <Grid>
                 <Grid.ColumnDefinitions>
                     <ColumnDefinition Width="200" />

Bloxstrap/UI/Elements/Settings/Pages/AppearancePage.xaml

@@ -65,8 +65,8 @@ private void BrowseCustomRobloxIconLocation()
             if (dialog.ShowDialog() != true)
                 return;
 
-            CustomIconLocation = dialog.FileName;
-            OnPropertyChanged(nameof(CustomIconLocation));
+            CustomRobloxIconLocation = dialog.FileName;
+            OnPropertyChanged(nameof(CustomRobloxIconLocation));
         }
 
         public AppearanceViewModel(Page page)