Skip to content

Commit 07efd11

Browse files
Matt561Matt561
authored
feat: added mainnet monad to default getDefaultNetworkEnablementControllerState in network-enablement-controller (MetaMask#8743)
## Explanation <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> Adds mainnet Monad as a default enabled network. ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> - [MUSD-784: Mobile: Add Monad to default enabled networks](https://consensyssoftware.atlassian.net/browse/MUSD-784) ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: this only changes the default enabled network list and updates tests/changelog, with no behavioral logic changes beyond initial state defaults for new users. > > **Overview** > Adds Monad mainnet (`0x8f`, chain ID 143) to `NetworkEnablementController`’s default `enabledNetworkMap` so new users start with Monad enabled. > > Updates the unit test expectations (and related disable/fallback scenarios) plus the package changelog to reflect the new default network. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 54f7486. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent 685b508 commit 07efd11

3 files changed

Lines changed: 23 additions & 0 deletions

File tree

‎packages/network-enablement-controller/CHANGELOG.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
## [Unreleased]
99

10+
### Changed
11+
12+
- Add Monad mainnet (`0x8f`, chain ID 143) to the default enabled network map for new users ([#8743](https://github.com/MetaMask/core/pull/8743))
13+
1014
## [5.1.1]
1115

1216
### Changed

‎packages/network-enablement-controller/src/NetworkEnablementController.test.ts‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,7 @@ describe('NetworkEnablementController', () => {
195195
[ChainId[BuiltInNetworkName.OptimismMainnet]]: true,
196196
[ChainId[BuiltInNetworkName.PolygonMainnet]]: true,
197197
[ChainId[BuiltInNetworkName.SeiMainnet]]: true,
198+
[ChainId[BuiltInNetworkName.MonadMainnet]]: true,
198199
},
199200
[KnownCaipNamespace.Solana]: {
200201
[SolScope.Mainnet]: true,
@@ -250,6 +251,7 @@ describe('NetworkEnablementController', () => {
250251
[ChainId[BuiltInNetworkName.OptimismMainnet]]: true,
251252
[ChainId[BuiltInNetworkName.PolygonMainnet]]: true,
252253
[ChainId[BuiltInNetworkName.SeiMainnet]]: true,
254+
[ChainId[BuiltInNetworkName.MonadMainnet]]: true,
253255
'0xa86a': true, // Avalanche network added and enabled (keeps current selection)
254256
},
255257
[KnownCaipNamespace.Solana]: {
@@ -314,6 +316,7 @@ describe('NetworkEnablementController', () => {
314316
[ChainId[BuiltInNetworkName.OptimismMainnet]]: true,
315317
[ChainId[BuiltInNetworkName.PolygonMainnet]]: true,
316318
[ChainId[BuiltInNetworkName.SeiMainnet]]: true,
319+
[ChainId[BuiltInNetworkName.MonadMainnet]]: true,
317320
},
318321
[KnownCaipNamespace.Solana]: {
319322
[SolScope.Mainnet]: true,
@@ -418,6 +421,7 @@ describe('NetworkEnablementController', () => {
418421
controller.disableNetwork('0xa'); // Optimism Mainnet
419422
controller.disableNetwork('0x89'); // Polygon Mainnet
420423
controller.disableNetwork('0x531'); // Sei Mainnet
424+
controller.disableNetwork('0x8f'); // Monad Mainnet
421425

422426
// Publish an update with linea network removed
423427
rootMessenger.publish('NetworkController:networkRemoved', {
@@ -455,6 +459,7 @@ describe('NetworkEnablementController', () => {
455459
[ChainId[BuiltInNetworkName.OptimismMainnet]]: false,
456460
[ChainId[BuiltInNetworkName.PolygonMainnet]]: false,
457461
[ChainId[BuiltInNetworkName.SeiMainnet]]: false,
462+
[ChainId[BuiltInNetworkName.MonadMainnet]]: false,
458463
},
459464
[KnownCaipNamespace.Solana]: {
460465
[SolScope.Mainnet]: true,
@@ -555,6 +560,7 @@ describe('NetworkEnablementController', () => {
555560
[ChainId[BuiltInNetworkName.OptimismMainnet]]: true,
556561
[ChainId[BuiltInNetworkName.PolygonMainnet]]: true,
557562
[ChainId[BuiltInNetworkName.SeiMainnet]]: true,
563+
[ChainId[BuiltInNetworkName.MonadMainnet]]: true,
558564
},
559565
[KnownCaipNamespace.Solana]: {
560566
[SolScope.Mainnet]: true, // Solana Mainnet (exists in multichain config)
@@ -1197,6 +1203,7 @@ describe('NetworkEnablementController', () => {
11971203
[ChainId[BuiltInNetworkName.OptimismMainnet]]: true,
11981204
[ChainId[BuiltInNetworkName.PolygonMainnet]]: true,
11991205
[ChainId[BuiltInNetworkName.SeiMainnet]]: true,
1206+
[ChainId[BuiltInNetworkName.MonadMainnet]]: true,
12001207
},
12011208
[KnownCaipNamespace.Solana]: {
12021209
[SolScope.Mainnet]: true,
@@ -1231,6 +1238,7 @@ describe('NetworkEnablementController', () => {
12311238
[ChainId[BuiltInNetworkName.OptimismMainnet]]: false, // Not in mocked config
12321239
[ChainId[BuiltInNetworkName.PolygonMainnet]]: false, // Not in mocked config
12331240
[ChainId[BuiltInNetworkName.SeiMainnet]]: false, // Not in mocked config
1241+
[ChainId[BuiltInNetworkName.MonadMainnet]]: false, // Not in mocked config
12341242
},
12351243
[KnownCaipNamespace.Solana]: {
12361244
[SolScope.Mainnet]: true, // Solana
@@ -1494,6 +1502,7 @@ describe('NetworkEnablementController', () => {
14941502
[ChainId[BuiltInNetworkName.OptimismMainnet]]: true,
14951503
[ChainId[BuiltInNetworkName.PolygonMainnet]]: true,
14961504
[ChainId[BuiltInNetworkName.SeiMainnet]]: true,
1505+
[ChainId[BuiltInNetworkName.MonadMainnet]]: true,
14971506
},
14981507
[KnownCaipNamespace.Solana]: {
14991508
[SolScope.Mainnet]: true,
@@ -1528,6 +1537,7 @@ describe('NetworkEnablementController', () => {
15281537
[ChainId[BuiltInNetworkName.OptimismMainnet]]: false,
15291538
[ChainId[BuiltInNetworkName.PolygonMainnet]]: false,
15301539
[ChainId[BuiltInNetworkName.SeiMainnet]]: false,
1540+
[ChainId[BuiltInNetworkName.MonadMainnet]]: false,
15311541
},
15321542
[KnownCaipNamespace.Solana]: {
15331543
[SolScope.Mainnet]: false, // Now disabled (cross-namespace behavior)
@@ -1582,6 +1592,7 @@ describe('NetworkEnablementController', () => {
15821592
[ChainId[BuiltInNetworkName.OptimismMainnet]]: false,
15831593
[ChainId[BuiltInNetworkName.PolygonMainnet]]: false,
15841594
[ChainId[BuiltInNetworkName.SeiMainnet]]: false,
1595+
[ChainId[BuiltInNetworkName.MonadMainnet]]: false,
15851596
},
15861597
[KnownCaipNamespace.Solana]: {
15871598
[SolScope.Mainnet]: false, // Disabled due to cross-namespace behavior
@@ -1620,6 +1631,7 @@ describe('NetworkEnablementController', () => {
16201631
[ChainId[BuiltInNetworkName.OptimismMainnet]]: false,
16211632
[ChainId[BuiltInNetworkName.PolygonMainnet]]: false,
16221633
[ChainId[BuiltInNetworkName.SeiMainnet]]: false,
1634+
[ChainId[BuiltInNetworkName.MonadMainnet]]: false,
16231635
},
16241636
[KnownCaipNamespace.Solana]: {
16251637
[SolScope.Mainnet]: false, // Now disabled (cross-namespace behavior)
@@ -1658,6 +1670,7 @@ describe('NetworkEnablementController', () => {
16581670
[ChainId[BuiltInNetworkName.OptimismMainnet]]: false,
16591671
[ChainId[BuiltInNetworkName.PolygonMainnet]]: false,
16601672
[ChainId[BuiltInNetworkName.SeiMainnet]]: false,
1673+
[ChainId[BuiltInNetworkName.MonadMainnet]]: false,
16611674
},
16621675
[KnownCaipNamespace.Solana]: {
16631676
[SolScope.Mainnet]: false, // Now disabled (cross-namespace behavior)
@@ -1707,6 +1720,7 @@ describe('NetworkEnablementController', () => {
17071720
[ChainId[BuiltInNetworkName.OptimismMainnet]]: false,
17081721
[ChainId[BuiltInNetworkName.PolygonMainnet]]: false,
17091722
[ChainId[BuiltInNetworkName.SeiMainnet]]: false,
1723+
[ChainId[BuiltInNetworkName.MonadMainnet]]: false,
17101724
},
17111725
[KnownCaipNamespace.Solana]: {
17121726
[SolScope.Mainnet]: false, // Disabled due to cross-namespace behavior
@@ -1753,6 +1767,7 @@ describe('NetworkEnablementController', () => {
17531767
[ChainId[BuiltInNetworkName.OptimismMainnet]]: false,
17541768
[ChainId[BuiltInNetworkName.PolygonMainnet]]: false,
17551769
[ChainId[BuiltInNetworkName.SeiMainnet]]: false,
1770+
[ChainId[BuiltInNetworkName.MonadMainnet]]: false,
17561771
},
17571772
[KnownCaipNamespace.Solana]: {
17581773
[SolScope.Mainnet]: false,
@@ -1802,6 +1817,7 @@ describe('NetworkEnablementController', () => {
18021817
[ChainId[BuiltInNetworkName.OptimismMainnet]]: false,
18031818
[ChainId[BuiltInNetworkName.PolygonMainnet]]: false,
18041819
[ChainId[BuiltInNetworkName.SeiMainnet]]: false,
1820+
[ChainId[BuiltInNetworkName.MonadMainnet]]: false,
18051821
},
18061822
[KnownCaipNamespace.Solana]: {
18071823
[SolScope.Mainnet]: false, // Disabled due to cross-namespace behavior
@@ -1848,6 +1864,7 @@ describe('NetworkEnablementController', () => {
18481864
[ChainId[BuiltInNetworkName.OptimismMainnet]]: true,
18491865
[ChainId[BuiltInNetworkName.PolygonMainnet]]: true,
18501866
[ChainId[BuiltInNetworkName.SeiMainnet]]: true,
1867+
[ChainId[BuiltInNetworkName.MonadMainnet]]: true,
18511868
},
18521869
[KnownCaipNamespace.Solana]: {
18531870
[SolScope.Mainnet]: true,
@@ -1896,6 +1913,7 @@ describe('NetworkEnablementController', () => {
18961913
[ChainId[BuiltInNetworkName.OptimismMainnet]]: true,
18971914
[ChainId[BuiltInNetworkName.PolygonMainnet]]: true,
18981915
[ChainId[BuiltInNetworkName.SeiMainnet]]: true,
1916+
[ChainId[BuiltInNetworkName.MonadMainnet]]: true,
18991917
},
19001918
[KnownCaipNamespace.Solana]: {
19011919
[SolScope.Mainnet]: true,

‎packages/network-enablement-controller/src/NetworkEnablementController.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,7 @@ const getDefaultNetworkEnablementControllerState =
167167
[ChainId[BuiltInNetworkName.OptimismMainnet]]: true,
168168
[ChainId[BuiltInNetworkName.PolygonMainnet]]: true,
169169
[ChainId[BuiltInNetworkName.SeiMainnet]]: true,
170+
[ChainId[BuiltInNetworkName.MonadMainnet]]: true,
170171
},
171172
[KnownCaipNamespace.Solana]: {
172173
[SolScope.Mainnet]: true,

0 commit comments

Comments
 (0)