feat: asset-controller tempo adjustments before migration (MetaMask#8638)

## Explanation

<!--
Thanks for your contribution! Take a moment to answer these questions so
that reviewers have the information they need to properly understand
your changes:

* What is the current state of things and why does it need to change?
* What is the solution your changes offer and how does it work?
* Are there any changes whose purpose might not obvious to those
unfamiliar with the domain?
* If your primary goal was to update one package but you found you had
to update another one along the way, why did you do so?
* If you had to upgrade a dependency, why did you do so?
-->

This PR prevents native balance fetches on Tempo chains for the native
asset for:
- Allowing transition from multi-assets-controller to unified - long
smoke-tested but will need proper QA with fresh+used states.
- Future-proof the case if `getBalance` started to return an error from
Tempo's RPC - currently returns
`4242424242424242424242424242424242424242424242424242424242424242424242424242`
but Tempo might change it to an error message in the future.

## References

<!--
Are there any issues that this pull request is tied to?
Are there other links that reviewers should consult to understand these
changes better?
Are there client or consumer pull requests to adopt any breaking
changes?

For example:

* Fixes #12345
* Related to #67890
-->

## Checklist

- [ ] I've updated the test suite for new or updated code as appropriate
- [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md)
- [ ] I've introduced [breaking
changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md)
in this PR and have prepared draft pull requests for clients and
consumer packages to resolve them


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Changes the RPC balance fetch pipeline to omit native-asset fetching
(including fallback paths) for chains flagged as having no native token,
which could affect displayed balances/metadata on those networks if
misclassified.
> 
> **Overview**
> Prevents `RpcDataSource` from querying/returning native balances on
Tempo chains by gating native asset inclusion (and the error-path
default native `0` entry) behind a new `shouldSkipNativeForCaipChainId`
helper.
> 
> Updates `AssetsController` native-token hiding logic to use the same
helper, adds targeted RPC data source tests to ensure native entries and
`getBalance` fallbacks are skipped when configured, and adjusts token
price support mappings so Tempo chains are treated as having *no native
asset*.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
af970ec. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Author: maxime-oe

packages/assets-controller/CHANGELOG.md

@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 
 - Bump `@metamask/network-controller` from `^31.0.0` to `^31.1.0` ([#8765](https://github.com/MetaMask/core/pull/8765))
+- Update `RpcDataSource` to prevent native `getEthBalance` fetching for Tempo chains ([#8638](https://github.com/MetaMask/core/pull/8638))
 
 ## [7.0.1]
 

packages/assets-controller/src/AssetsController.ts

@@ -12,7 +12,6 @@ import type {
 } from '@metamask/base-controller';
 import type { ClientControllerStateChangeEvent } from '@metamask/client-controller';
 import { clientControllerSelectors } from '@metamask/client-controller';
-import { CHAIN_IDS_WITH_NO_NATIVE_TOKEN } from '@metamask/controller-utils';
 import type { TraceCallback } from '@metamask/controller-utils';
 import type {
   ApiPlatformClient,
@@ -74,6 +73,7 @@ import type {
 import type { AccountsApiDataSourceConfig } from './data-sources/AccountsApiDataSource';
 import { AccountsApiDataSource } from './data-sources/AccountsApiDataSource';
 import { BackendWebsocketDataSource } from './data-sources/BackendWebsocketDataSource';
+import { shouldSkipNativeForCaipChainId } from './data-sources/evm-rpc-services/utils/assets';
 import type { PriceDataSourceConfig } from './data-sources/PriceDataSource';
 import { PriceDataSource } from './data-sources/PriceDataSource';
 import type { RpcDataSourceConfig } from './data-sources/RpcDataSource';
@@ -2393,11 +2393,7 @@ export class AssetsController extends BaseController<
    */
   #shouldHideNativeToken(chainId: ChainId, metadata: AssetMetadata): boolean {
     // Check if it's a chain that should skip native tokens
-    if (
-      !CHAIN_IDS_WITH_NO_NATIVE_TOKEN.includes(
-        chainId as (typeof CHAIN_IDS_WITH_NO_NATIVE_TOKEN)[number],
-      )
-    ) {
+    if (!shouldSkipNativeForCaipChainId(chainId)) {
       return false;
     }
 

packages/assets-controller/src/data-sources/RpcDataSource.test.ts

@@ -19,6 +19,7 @@ import type {
   BalanceFetchResult,
   TokenDetectionResult,
 } from './evm-rpc-services';
+import { shouldSkipNativeForCaipChainId } from './evm-rpc-services/utils/assets';
 import type { RpcDataSourceOptions } from './RpcDataSource';
 import {
   RpcDataSource,
@@ -247,6 +248,10 @@ jest.mock('@ethersproject/providers', () => ({
   })),
 }));
 
+jest.mock('./evm-rpc-services/utils/assets', () => ({
+  shouldSkipNativeForCaipChainId: jest.fn().mockReturnValue(false),
+}));
+
 describe('caipChainIdToHex', () => {
   it('returns hex unchanged when given hex string', () => {
     expect(caipChainIdToHex('0x1')).toBe('0x1');
@@ -469,6 +474,18 @@ describe('RpcDataSource', () => {
       });
     });
 
+    it('fetches balances for accounts except native for native skip chain', async () => {
+      jest.mocked(shouldSkipNativeForCaipChainId).mockReturnValue(true);
+      await withController(async ({ controller }) => {
+        const response = await controller.fetch(createDataRequest());
+        expect(response).toBeDefined();
+        expect(response.assetsBalance).toBeDefined();
+        expect(response.assetsBalance?.[MOCK_ACCOUNT_ID]).not.toHaveProperty(
+          'eip155:1/slip44:60',
+        );
+      });
+    });
+
     it('converts fetched balances to human-readable and merges metadata', async () => {
       const nativeAssetId = 'eip155:1/slip44:60' as Caip19AssetId;
       await withController(async ({ controller }) => {
@@ -506,6 +523,30 @@ describe('RpcDataSource', () => {
       });
     });
 
+    it('skips native asset call even in the getBalance fallback when Multicall aggregate3 fails', async () => {
+      const { Web3Provider } = jest.requireMock('@ethersproject/providers');
+      jest.mocked(shouldSkipNativeForCaipChainId).mockReturnValue(true);
+
+      const mockCall = jest
+        .fn()
+        .mockRejectedValueOnce(new Error('aggregate3 unavailable'))
+        .mockResolvedValue('0x0');
+      const mockGetBalance = jest
+        .fn()
+        .mockResolvedValue({ toString: () => '1000000000000000000' });
+      (Web3Provider as jest.Mock).mockImplementationOnce(() => ({
+        call: mockCall,
+        getBalance: mockGetBalance,
+      }));
+
+      await withController(async ({ controller }) => {
+        const response = await controller.fetch(createDataRequest());
+        expect(response.assetsBalance).toBeDefined();
+        expect(response.assetsBalance?.[MOCK_ACCOUNT_ID]).toStrictEqual({});
+        expect(mockGetBalance).not.toHaveBeenCalled();
+      });
+    });
+
     it('uses getBalance when Multicall aggregate3 fails (#getMulticallProvider getBalance)', async () => {
       const { Web3Provider } = jest.requireMock('@ethersproject/providers');
       const mockCall = jest
@@ -576,6 +617,25 @@ describe('RpcDataSource', () => {
       });
     });
 
+    it('initializes assetsBalance[accountId] with no native in catch when first fetch for account throws on native skip chain', async () => {
+      await withController(async ({ controller }) => {
+        jest
+          .spyOn(BalanceFetcher.prototype, 'fetchBalancesForAssets')
+          .mockRejectedValue(new Error('RPC unavailable'));
+        // Indicates that we want to skip native for that chain
+        jest.mocked(shouldSkipNativeForCaipChainId).mockReturnValue(true);
+        const request = createDataRequest();
+        const response = await controller.fetch(request);
+        expect(response.errors).toBeDefined();
+        expect(response.errors?.[MOCK_CHAIN_ID_CAIP]).toBe('RPC fetch failed');
+        expect(response.assetsBalance).toBeDefined();
+        expect(response.assetsBalance?.[MOCK_ACCOUNT_ID]).toBeDefined();
+        expect(response.assetsBalance?.[MOCK_ACCOUNT_ID]).not.toHaveProperty(
+          'eip155:1/slip44:60',
+        );
+      });
+    });
+
     it('returns undefined from #getProvider when network client has no provider', async () => {
       const networkState = createMockNetworkState(NetworkStatus.Available);
       (networkState.networkConfigurationsByChainId as Record<string, unknown>)[

packages/assets-controller/src/data-sources/RpcDataSource.ts

@@ -61,6 +61,7 @@ import type {
   BalanceFetchResult,
   TokenDetectionResult,
 } from './evm-rpc-services/types';
+import { shouldSkipNativeForCaipChainId } from './evm-rpc-services/utils/assets';
 
 const CONTROLLER_NAME = 'RpcDataSource';
 const DEFAULT_BALANCE_INTERVAL = 30_000; // 30 seconds
@@ -941,12 +942,14 @@ export class RpcDataSource extends AbstractDataSource<
 
       for (const chainId of chainsForAccount) {
         const hexChainId = caipChainIdToHex(chainId);
-
-        // Build a single AssetFetchEntry[] for native + custom ERC-20s
         const nativeAssetId = this.#getNativeAssetForChain(chainId);
-        const assetsToFetch: AssetFetchEntry[] = [
-          { assetId: nativeAssetId, address: ZERO_ADDRESS },
-        ];
+
+        const shouldSkipNative = shouldSkipNativeForCaipChainId(chainId);
+        const assetsToFetch: AssetFetchEntry[] = [];
+        if (!shouldSkipNative) {
+          // Build a single AssetFetchEntry[] for native + custom ERC-20s
+          assetsToFetch.push({ assetId: nativeAssetId, address: ZERO_ADDRESS });
+        }
 
         if (request.customAssets) {
           const existingMetadata = this.#getExistingAssetsMetadata();
@@ -1041,8 +1044,10 @@ export class RpcDataSource extends AbstractDataSource<
           if (!assetsBalance[accountId]) {
             assetsBalance[accountId] = {};
           }
-          assetsBalance[accountId][nativeAssetId] = { amount: '0' };
 
+          if (!shouldSkipNative) {
+            assetsBalance[accountId][nativeAssetId] = { amount: '0' };
+          }
           // Even on error, include native token metadata. Prefer the richer
           // metadata already in state (e.g. enriched with image/description
           // by the price/info API) and fall back to a minimal stub only when

packages/assets-controller/src/data-sources/evm-rpc-services/utils/assets.ts

@@ -0,0 +1,10 @@
+import { CHAIN_IDS_WITH_NO_NATIVE_TOKEN } from '@metamask/controller-utils';
+import { CaipChainId } from '@metamask/utils';
+
+export function shouldSkipNativeForCaipChainId(
+  caipChainId: CaipChainId,
+): boolean {
+  return (CHAIN_IDS_WITH_NO_NATIVE_TOKEN as readonly string[]).includes(
+    caipChainId,
+  );
+}

packages/assets-controllers/CHANGELOG.md

@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 
 - Bump `@metamask/network-controller` from `^31.0.0` to `^31.1.0` ([#8765](https://github.com/MetaMask/core/pull/8765))
+- Modify `SPOT_PRICES_SUPPORT_INFO` entries for Tempo chains (`0x1079` and `0xa5bf`) ([#8638](https://github.com/MetaMask/core/pull/8638))
 
 ## [106.0.1]
 

packages/assets-controllers/src/token-prices-service/codefi-v2.ts

@@ -233,8 +233,6 @@ const chainIdToNativeTokenAddress: Record<Hex, Hex> = {
   '0x64': '0xe91d153e0b41518a2ce8dd3d7944fa863463a97d', // Gnosis
   '0x1e': '0x542fda317318ebf1d3deaf76e0b632741a7e677d', // Rootstock Mainnet - Native symbol: RBTC
   '0x3dc': '0x779ded0c9e1022225f8e0630b35a9b54be713736', // Stable - Native symbol: USDT0
-  '0x1079': '0x20c0000000000000000000000000000000000000', // Tempo Mainnet - Pseudo-Native symbol: pathUSD
-  '0xa5bf': '0x20c0000000000000000000000000000000000000', // Tempo Moderato Testnet - Pseudo-Native symbol: pathUSD
 };
 
 /**
@@ -289,7 +287,7 @@ export const SPOT_PRICES_SUPPORT_INFO = {
   '0x74c': 'eip155:1868/erc20:0x0000000000000000000000000000000000000000', // Soneium - Native symbol: ETH
   '0xa729': 'eip155:42793/erc20:0x0000000000000000000000000000000000000000', // Etherlink - Native symbol: XTZ (Tezos L2)
   '0xab5': 'eip155:2741/erc20:0x0000000000000000000000000000000000000000', // Abstract - Native symbol: ETH
-  '0x1079': 'eip155:4217/erc20:0x20c0000000000000000000000000000000000000', // Tempo Mainnet - Pseudo-Native symbol: pathUSD
+  '0x1079': 'eip155:4217/slip44:60', // Tempo Mainnet - No native asset
   '0x10e6': 'eip155:4326/erc20:0x0000000000000000000000000000000000000000', // MegaETH Mainnet - Native symbol: ETH
   '0x1388': 'eip155:5000/erc20:0xdeaddeaddeaddeaddeaddeaddeaddeaddead0000', // Mantle - Native symbol: MNT
   '0x2105': 'eip155:8453/slip44:60', // Base - Native symbol: ETH
@@ -302,7 +300,7 @@ export const SPOT_PRICES_SUPPORT_INFO = {
   '0xa516': 'eip155:42262/slip44:474', // Oasis Emerald - Native symbol: ROSE
   '0xa867': 'eip155:43111/erc20:0x0000000000000000000000000000000000000000', // Hemi - Native symbol: ETH
   '0xa86a': 'eip155:43114/slip44:9005', // Avalanche C-Chain - Native symbol: AVAX
-  '0xa5bf': 'eip155:42431/erc20:0x20c0000000000000000000000000000000000000', // Tempo Testnet Moderato - Pseudo-Native symbol: pathUSD
+  '0xa5bf': 'eip155:42431/slip44:60', // Tempo Testnet Moderato - No native asset
   '0xe708': 'eip155:59144/slip44:60', // Linea Mainnet - Native symbol: ETH
   '0xed88': 'eip155:60808/erc20:0x0000000000000000000000000000000000000000', // BOB - Native symbol: ETH
   '0x138de': 'eip155:80094/erc20:0x0000000000000000000000000000000000000000', // Berachain - Native symbol: Bera',