Skip to content

Commit 56cdc72

Browse files
authored
feat: export InfuraRpcEndpoint and AddNetworkCustomRpcEndpointFields types (MetaMask#8764)
## Explanation <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> `InfuraRpcEndpoint` and `AddNetworkCustomRpcEndpointFields` were not exported from `packages/network-controller/index.ts`. ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> * Related to MetaMask/metamask-extension#40343 ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: this is a public API surface change that only re-exports existing TypeScript types and updates the changelog, with no runtime logic changes. > > **Overview** > **Exposes two previously internal type definitions** from `@metamask/network-controller` by re-exporting `InfuraRpcEndpoint` and `AddNetworkCustomRpcEndpointFields` from `src/index.ts`. > > Adds a corresponding `CHANGELOG.md` entry under *Unreleased* noting the new exports for downstream consumers. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 6074d4f. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent 07efd11 commit 56cdc72

2 files changed

Lines changed: 6 additions & 0 deletions

File tree

packages/network-controller/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
## [Unreleased]
99

10+
### Added
11+
12+
- Add export for `AddNetworkCustomRpcEndpointFields` and `InfuraRpcEndpoint` types ([#8764](https://github.com/MetaMask/core/pull/8764))
13+
1014
## [31.0.0]
1115

1216
### Added

packages/network-controller/src/index.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,10 @@ export type {
1010
NetworkState,
1111
BlockTrackerProxy,
1212
ProviderProxy,
13+
AddNetworkCustomRpcEndpointFields,
1314
AddNetworkFields,
1415
UpdateNetworkFields,
16+
InfuraRpcEndpoint,
1517
NetworkControllerStateChangeEvent,
1618
NetworkControllerNetworkWillChangeEvent,
1719
NetworkControllerNetworkDidChangeEvent,

0 commit comments

Comments
 (0)