fix(transaction-pay-controller): vault musd via sentinel (MetaMask#9161)

## Explanation

Direct mUSD fiat quotes for Money Account deposits can settle directly
into the Money Account, so they do not need a Relay quote or Relay
execute path.

This PR moves that path to a Ramps-funded, sponsored Money Account vault
batch. After fiat settlement, the Fiat strategy refreshes the vault
calldata through `getAmountData`, submits the nested approve/deposit
calls through `TransactionController:addTransactionBatch`, and lets the
client publish hook handle 7702/Sentinel sponsorship.

It also keeps a local QA funding path behind client-provided fiat test
options so the settlement step can be exercised without creating a real
on-ramp order.

## References

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md)
- [ ] I've introduced [breaking
changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md)
in this PR and have prepared draft pull requests for clients and
consumer packages to resolve them

Author: matthewwalsh0

packages/transaction-pay-controller/CHANGELOG.md

@@ -7,9 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Added
+
+- Add test-only fiat execution options to bypass fiat on-ramp settlement during local QA by funding the expected fiat asset from a configured account before continuing the normal MM Pay fiat submit flow ([#9161](https://github.com/MetaMask/core/pull/9161))
+
 ### Fixed
 
 - Sync transaction metadata when fiat payment is selected but no payment token is present ([#9158](https://github.com/MetaMask/core/pull/9158))
+- Fix direct mUSD fiat Money Account deposits by submitting a sponsored Money Account vault batch after fiat settlement instead of requiring Relay execute ([#9161](https://github.com/MetaMask/core/pull/9161))
 
 ## [23.8.0]
 

packages/transaction-pay-controller/src/TransactionPayController-method-action-types.ts

@@ -81,6 +81,18 @@ export type TransactionPayControllerGetAmountDataAction = {
   handler: TransactionPayController['getAmountData'];
 };
 
+/**
+ * Returns optional fiat execution configuration.
+ *
+ * This is intentionally not stored in controller state.
+ *
+ * @returns Fiat execution options, if configured.
+ */
+export type TransactionPayControllerGetFiatOptionsAction = {
+  type: `TransactionPayController:getFiatOptions`;
+  handler: TransactionPayController['getFiatOptions'];
+};
+
 export type TransactionPayControllerGetPaymentOverrideDataAction = {
   type: `TransactionPayController:getPaymentOverrideData`;
   handler: TransactionPayController['getPaymentOverrideData'];
@@ -134,6 +146,7 @@ export type TransactionPayControllerMethodActions =
   | TransactionPayControllerUpdateFiatPaymentAction
   | TransactionPayControllerGetDelegationTransactionAction
   | TransactionPayControllerGetAmountDataAction
+  | TransactionPayControllerGetFiatOptionsAction
   | TransactionPayControllerGetPaymentOverrideDataAction
   | TransactionPayControllerGetStrategyAction
   | TransactionPayControllerPolymarketGetDepositWalletAddressAction

packages/transaction-pay-controller/src/TransactionPayController.test.ts

@@ -11,6 +11,7 @@ import { deriveFiatAssetForFiatPayment } from './strategy/fiat/utils';
 import { getMessengerMock } from './tests/messenger-mock';
 import type {
   TransactionPayControllerMessenger,
+  TransactionPayControllerOptions,
   TransactionPaySourceAmount,
   UpdateTransactionDataCallback,
 } from './types';
@@ -35,7 +36,6 @@ const TRANSACTION_ID_MOCK = '123-456';
 const TRANSACTION_META_MOCK = { id: TRANSACTION_ID_MOCK } as TransactionMeta;
 const TOKEN_ADDRESS_MOCK = '0xabc' as Hex;
 const CHAIN_ID_MOCK = '0x1' as Hex;
-
 describe('TransactionPayController', () => {
   const updateFiatPaymentMock = jest.mocked(updateFiatPayment);
   const updatePaymentTokenMock = jest.mocked(updatePaymentToken);
@@ -56,10 +56,14 @@ describe('TransactionPayController', () => {
   /**
    * Create a TransactionPayController.
    *
+   * @param options - Controller options.
    * @returns The created controller.
    */
-  function createController(): TransactionPayController {
+  function createController(
+    options: Partial<TransactionPayControllerOptions> = {},
+  ): TransactionPayController {
     return new TransactionPayController({
+      ...options,
       getDelegationTransaction: jest.fn(),
       messenger,
     });
@@ -563,6 +567,29 @@ describe('TransactionPayController', () => {
     });
   });
 
+  describe('getFiatOptions', () => {
+    it('returns configured fiat options', () => {
+      const fiatOptions = {
+        testFundingSource: '0x1111111111111111111111111111111111111111' as Hex,
+        testAmountOverride: '0.1',
+      };
+
+      createController({ fiatOptions });
+
+      const result = messenger.call('TransactionPayController:getFiatOptions');
+
+      expect(result).toBe(fiatOptions);
+    });
+
+    it('returns undefined when no fiat options are configured', () => {
+      createController();
+
+      const result = messenger.call('TransactionPayController:getFiatOptions');
+
+      expect(result).toBeUndefined();
+    });
+  });
+
   describe('polymarket callbacks', () => {
     const EOA_MOCK = '0x1111111111111111111111111111111111111111' as Hex;
     const DEPOSIT_WALLET_MOCK =

packages/transaction-pay-controller/src/TransactionPayController.ts

@@ -20,6 +20,7 @@ import type {
   TransactionConfigCallback,
   TransactionData,
   TransactionPayControllerMessenger,
+  TransactionPayFiatOptions,
   TransactionPayControllerOptions,
   TransactionPayControllerState,
   UpdateFiatPaymentRequest,
@@ -36,6 +37,7 @@ import {
 const MESSENGER_EXPOSED_METHODS = [
   'getAmountData',
   'getDelegationTransaction',
+  'getFiatOptions',
   'getPaymentOverrideData',
   'getStrategy',
   'polymarketGetDepositWalletAddress',
@@ -67,6 +69,8 @@ export class TransactionPayController extends BaseController<
 
   readonly #getDelegationTransaction: GetDelegationTransactionCallback;
 
+  readonly #fiatOptions?: TransactionPayFiatOptions;
+
   readonly #getPaymentOverrideData?: GetPaymentOverrideDataCallback;
 
   readonly #getStrategy?: (
@@ -80,6 +84,7 @@ export class TransactionPayController extends BaseController<
   readonly #polymarket?: PolymarketCallbacks;
 
   constructor({
+    fiatOptions,
     getAmountData,
     getDelegationTransaction,
     getPaymentOverrideData,
@@ -98,6 +103,7 @@ export class TransactionPayController extends BaseController<
 
     this.#getAmountData = getAmountData;
     this.#getDelegationTransaction = getDelegationTransaction;
+    this.#fiatOptions = fiatOptions;
     this.#getPaymentOverrideData = getPaymentOverrideData;
     this.#getStrategy = getStrategy;
     this.#getStrategies = getStrategies;
@@ -244,6 +250,17 @@ export class TransactionPayController extends BaseController<
     return this.#getAmountData?.(...args) ?? Promise.resolve({ updates: [] });
   }
 
+  /**
+   * Returns optional fiat execution configuration.
+   *
+   * This is intentionally not stored in controller state.
+   *
+   * @returns Fiat execution options, if configured.
+   */
+  getFiatOptions(): TransactionPayFiatOptions | undefined {
+    return this.#fiatOptions;
+  }
+
   getPaymentOverrideData(
     ...args: Parameters<GetPaymentOverrideDataCallback>
   ): ReturnType<GetPaymentOverrideDataCallback> {

packages/transaction-pay-controller/src/index.ts

@@ -9,6 +9,7 @@ export type {
   TransactionData,
   TransactionFiatPayment,
   TransactionFiatPaymentCallback,
+  TransactionPayFiatOptions,
   TransactionPayControllerActions,
   TransactionPayControllerEvents,
   TransactionPayControllerGetStateAction,
@@ -28,6 +29,7 @@ export type {
 export type {
   TransactionPayControllerGetAmountDataAction,
   TransactionPayControllerGetDelegationTransactionAction,
+  TransactionPayControllerGetFiatOptionsAction,
   TransactionPayControllerGetStrategyAction,
   TransactionPayControllerPolymarketGetDepositWalletAddressAction,
   TransactionPayControllerPolymarketSubmitDepositWalletBatchAction,

packages/transaction-pay-controller/src/strategy/fiat/constants.ts

@@ -51,6 +51,3 @@ export const MUSD_MONAD_FIAT_ASSET: TransactionPayFiatAsset = {
   address: MUSD_MONAD_ADDRESS,
   chainId: CHAIN_ID_MONAD,
 };
-
-/** Fixed USD amount used to probe whether any fiat provider can sell mUSD on Monad. */
-export const MUSD_PROBE_AMOUNT_USD = 50;