[pull] main from MetaMask:main#577
Merged
Merged
Conversation
…ds` types (#8764) ## Explanation <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> `InfuraRpcEndpoint` and `AddNetworkCustomRpcEndpointFields` were not exported from `packages/network-controller/index.ts`. ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> * Related to MetaMask/metamask-extension#40343 ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: this is a public API surface change that only re-exports existing TypeScript types and updates the changelog, with no runtime logic changes. > > **Overview** > **Exposes two previously internal type definitions** from `@metamask/network-controller` by re-exporting `InfuraRpcEndpoint` and `AddNetworkCustomRpcEndpointFields` from `src/index.ts`. > > Adds a corresponding `CHANGELOG.md` entry under *Unreleased* noting the new exports for downstream consumers. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 6074d4f. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
## Explanation <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> Releasing new minor version of `@metamask/network-controller` ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Primarily version and dependency bumps plus changelog updates; functional risk is limited to any downstream impact from consuming `@metamask/network-controller@31.1.0`. > > **Overview** > Publishes `@metamask/network-controller` **v31.1.0**, documenting the new exported types `AddNetworkCustomRpcEndpointFields` and `InfuraRpcEndpoint`. > > Updates the monorepo release version to `975.0.0` and bumps all affected workspace packages (and `yarn.lock`) to depend on `@metamask/network-controller` `^31.1.0`, with corresponding `CHANGELOG.md` entries. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 0049bb6. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
## Explanation <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> This PR prevents native balance fetches on Tempo chains for the native asset for: - Allowing transition from multi-assets-controller to unified - long smoke-tested but will need proper QA with fresh+used states. - Future-proof the case if `getBalance` started to return an error from Tempo's RPC - currently returns `4242424242424242424242424242424242424242424242424242424242424242424242424242` but Tempo might change it to an error message in the future. ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Changes the RPC balance fetch pipeline to omit native-asset fetching (including fallback paths) for chains flagged as having no native token, which could affect displayed balances/metadata on those networks if misclassified. > > **Overview** > Prevents `RpcDataSource` from querying/returning native balances on Tempo chains by gating native asset inclusion (and the error-path default native `0` entry) behind a new `shouldSkipNativeForCaipChainId` helper. > > Updates `AssetsController` native-token hiding logic to use the same helper, adds targeted RPC data source tests to ensure native entries and `getBalance` fallbacks are skipped when configured, and adjusts token price support mappings so Tempo chains are treated as having *no native asset*. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit af970ec. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )