[pull] main from MetaMask:main#665
Merged
Merged
Conversation
## Explanation Revert @metamask/transaction-pay-controller changes not required ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> ## Checklist - [X] I've updated the test suite for new or updated code as appropriate - [X] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [X] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [X] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **High Risk** > Marked breaking in the PR; changes MM Pay relay `user` identity and whether post-quote same-token transfers fetch quotes, which can break account-override and same-token MM Pay flows that depended on #9150/#9187. > > **Overview** > Reverts recent MM Pay relay and post-quote behavior in `@metamask/transaction-pay-controller`. > > **Relay quotes:** Removes `getQuoteUser` and always sets the quote body **`user`** to the resolved **`from`** address. Same-chain, same-token flows with **`accountOverride`** no longer send **`txParams.from`** as **`user`** on non–post-quote requests. > > **Post-quote source amounts:** **`calculatePostQuoteSourceAmounts`** no longer skips same-token-on-same-chain filtering when **`isQuoteRequired`** is true. Post-quote paths again drop identical source/destination tokens unless **`isHyperliquidSource`** or **`isPolymarketDepositWallet`** applies. **`isQuoteRequired`** still affects non–post-quote source amount logic elsewhere. > > Changelog and tests for the reverted behavior are updated accordingly. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit c4b3a2e. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
## Explanation Releasing @metamask/transaction-pay-controller ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> ## Checklist - [X] I've updated the test suite for new or updated code as appropriate - [X] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [X] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [X] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Version and changelog updates only; functional change is already in the prior 23.12.0 changelog entry for MM Pay quote filtering. > > **Overview** > Release **1053.0.0** cuts **`@metamask/transaction-pay-controller` 23.12.0** with no runtime code changes in this PR—only version bumps and changelog packaging. > > The published **23.12.0** note documents a behavior change from [#9194](#9194): post-quote source amount filtering no longer skips same-token filtering when **`isQuoteRequired`** is set. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 2d0a9e7. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
## Explanation <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> Current state: @metamask/perps-controller@8.1.0 is the latest publish, but #9178 (Perps Discovery analytics constants) merged afterward. Mobile needs those constants from core and can’t drop its local mirror until we ship a new version. Solution: Release 1054.0.0 publishes @metamask/perps-controller@8.2.0. This PR only versions and ships what’s already on main with no new feature work. What’s in 8.2.0: Added: Perps Discovery analytics constants (PERPS_EVENT_PROPERTY / PERPS_EVENT_VALUE) — #9178 Changed: Bump @metamask/utils to ^11.11.0 — #9074 Worth noting: The “Uncategorized” changelog entries are release bookkeeping from prior monorepo releases (1035–1049) that merged perps changes without publishing the package. The analytics constants are shared telemetry strings so clients emit consistent Perps Discovery events. Other packages / deps: Only perps-controller is published here. The utils bump was already merged separately and is included because it landed after 8.1.0. References #9178 — Perps Discovery analytics constants #9074 — @metamask/utils bump Mobile follow-up: swap local constant mirrors for @metamask/perps-controller imports after this release ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Version and changelog bookkeeping only; no runtime or API changes in this diff. > > **Overview** > **Release-only PR** — bumps the core monorepo to **1054.0.0** and publishes **`@metamask/perps-controller@8.2.0`** (from 8.1.0). There is no new feature work in the diff; it versions and ships changes already merged on `main`. > > The **8.2.0** changelog section is finalized (moved out of Unreleased) so consumers can adopt **Perps Discovery analytics constants** (`PERPS_EVENT_PROPERTY` / `PERPS_EVENT_VALUE`, #9178) from the package instead of local mirrors, plus the already-landed **`@metamask/utils`** bump (#9074). > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit ec77451. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )