From 27694d02363b550f97d0c6280786a6c6a42fa257 Mon Sep 17 00:00:00 2001 From: ieow <4881057+ieow@users.noreply.github.com> Date: Fri, 19 Jun 2026 14:24:15 +0800 Subject: [PATCH 1/2] feat: test lint issue - add agentic cli preferences (#8933) (#9173) ## Explanation Follow-up to #8933. The `does not mutate DEFAULT_AGENTIC_CLI_PREFERENCES when coercing legacy payloads` test in `@metamask/authenticated-user-storage` failed TypeScript and ESLint checks after `agenticCli` was added as an optional field on `NotificationPreferences`. The guard now checks `result?.agenticCli` instead of only `result`, so TypeScript narrows correctly before the test mutates `result.agenticCli.inAppNotificationsEnabled`. No runtime or API behavior changes. ## References * Follow-up to #8933 ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them --- .../src/authenticated-user-storage.test.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/authenticated-user-storage/src/authenticated-user-storage.test.ts b/packages/authenticated-user-storage/src/authenticated-user-storage.test.ts index df6703bcd9..bc18d81a6b 100644 --- a/packages/authenticated-user-storage/src/authenticated-user-storage.test.ts +++ b/packages/authenticated-user-storage/src/authenticated-user-storage.test.ts @@ -229,11 +229,10 @@ describe('AuthenticatedUserStorageService', () => { const result = await service.getNotificationPreferences(); expect(result).not.toBeNull(); - if (!result) { + if (!result?.agenticCli) { throw new Error('Result is null'); } result.agenticCli.inAppNotificationsEnabled = false; - expect(DEFAULT_AGENTIC_CLI_PREFERENCES.inAppNotificationsEnabled).toBe( true, ); From cfd51affd72f9c783eea7c3d847ee47a07706a7e Mon Sep 17 00:00:00 2001 From: Amitabh Aggarwal Date: Fri, 19 Jun 2026 01:38:13 -0500 Subject: [PATCH 2/2] Release 1055.0.0 (#9199) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Explanation **Current state:** `@metamask/ramps-controller@14.2.0` is the latest publish on npm. Since then, two consumer-facing changes merged to `main` but are not yet published: - **#9159 (TRAM-3539)** — `RampsController` now merges orders on the internal MetaMask order code (from canonical `order.id`, e.g. `c-{guid}`) instead of `providerOrderId`. Without this, Moonpay redirect buys can produce duplicate Activity rows (precreate stub + provider callback row). - **#9135** — exports `getTransakApiMessage`, `isTransakPhoneRegisteredError`, and centralized Transak API error codes for client-side error handling. Mobile QA is currently blocked on a **preview build** (`@metamask-previews/ramps-controller`) for TestFlight; we need a real npm release to drop preview/resolution pins. **Solution:** Release **1055.0.0** publishes **`@metamask/ramps-controller@14.3.0`**. This PR only versions and ships what is already on `main` — no new feature work in the diff. **What's in 14.3.0:** | Category | Change | |----------|--------| | **Fixed** | Compare internal order codes in `addOrder` / `getOrder` / `addPrecreatedOrder` ([#9159](https://github.com/MetaMask/core/pull/9159)) | | **Added** | Transak API error helpers (`getTransakApiMessage`, `isTransakPhoneRegisteredError`, `transakErrorCodes.ts`) ([#9135](https://github.com/MetaMask/core/pull/9135)) | | **Changed** | Bump `@metamask/profile-sync-controller` to `^28.2.0` ([#9119](https://github.com/MetaMask/core/pull/9119)) | **SemVer:** Minor bump (14.2.0 → 14.3.0) — includes new exports plus a bug fix. No breaking API changes. **Other packages / deps:** Only `@metamask/ramps-controller` is published in this release. Dependency bumps listed above were already merged separately and are included because they landed after 14.2.0. **Worth noting for reviewers:** The fix normalizes stored `providerOrderId` to the internal order code for polling/lookup consistency. Order Details “copy id” may show the MetaMask `c-…` code rather than the provider-native UUID — support should use provider link / tx hash for native references. ## References - TRAM-3539 — duplicate Moonpay Activity rows on redirect buys - [#9159](https://github.com/MetaMask/core/pull/9159) — internal order id merge fix - [#9135](https://github.com/MetaMask/core/pull/9135) — Transak API error helpers - [#9119](https://github.com/MetaMask/core/pull/9119) — profile-sync-controller dep bump - [MetaMask/metamask-mobile#31837](https://github.com/MetaMask/metamask-mobile/pull/31837) — mobile QA PR (preview pin; update to `^14.3.0` after this release) **Mobile follow-up after merge + npm publish:** 1. Bump `@metamask/ramps-controller` to `^14.3.0` 2. Remove preview alias / `resolutions` / `previewBuilds` 3. Re-run TestFlight QA for Moonpay redirect buy (single Activity row) ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them _(N/A — no breaking changes)_ --- > [!NOTE] > **Low Risk** > Release-only version, changelog, and lockfile updates with no runtime code changes in this diff. > > **Overview** > Release **1055.0.0** publishes **`@metamask/ramps-controller@14.3.0`** to npm. The PR diff is versioning and dependency wiring only—no new feature code. > > **`@metamask/ramps-controller`** goes **14.2.0 → 14.3.0** with changelog section **14.3.0** (content already on `main`): Transak error helpers (`getTransakApiMessage`, `isTransakPhoneRegisteredError`, `transakErrorCodes.ts`), bump to `@metamask/profile-sync-controller` ^28.2.0, and the documented order-id merge fix for duplicate Moonpay Activity rows. > > Root **`package.json`** is bumped **1054.0.0 → 1055.0.0**. **`@metamask/transaction-pay-controller`** updates its dependency to **`@metamask/ramps-controller` ^14.3.0** and records that in its changelog; **`yarn.lock`** is updated accordingly. > > Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 4685db4f90a30baf35d858141637643cc83cf104. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --- package.json | 2 +- packages/ramps-controller/CHANGELOG.md | 5 ++++- packages/ramps-controller/package.json | 2 +- packages/transaction-pay-controller/CHANGELOG.md | 4 ++++ packages/transaction-pay-controller/package.json | 2 +- yarn.lock | 4 ++-- 6 files changed, 13 insertions(+), 6 deletions(-) diff --git a/package.json b/package.json index a276c5692d..350be0b05a 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@metamask/core-monorepo", - "version": "1054.0.0", + "version": "1055.0.0", "private": true, "description": "Monorepo for packages shared between MetaMask clients", "repository": { diff --git a/packages/ramps-controller/CHANGELOG.md b/packages/ramps-controller/CHANGELOG.md index 6edd622bd0..24fd6f2cfd 100644 --- a/packages/ramps-controller/CHANGELOG.md +++ b/packages/ramps-controller/CHANGELOG.md @@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +## [14.3.0] + ### Added - Export `getTransakApiMessage` and `isTransakPhoneRegisteredError` for consumers handling `TransakApiError`, and centralize known Transak API error codes in `transakErrorCodes.ts` ([#9135](https://github.com/MetaMask/core/pull/9135)) @@ -388,7 +390,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Add `OnRampService` for interacting with the OnRamp API - Add geolocation detection via IP address lookup -[Unreleased]: https://github.com/MetaMask/core/compare/@metamask/ramps-controller@14.2.0...HEAD +[Unreleased]: https://github.com/MetaMask/core/compare/@metamask/ramps-controller@14.3.0...HEAD +[14.3.0]: https://github.com/MetaMask/core/compare/@metamask/ramps-controller@14.2.0...@metamask/ramps-controller@14.3.0 [14.2.0]: https://github.com/MetaMask/core/compare/@metamask/ramps-controller@14.1.1...@metamask/ramps-controller@14.2.0 [14.1.1]: https://github.com/MetaMask/core/compare/@metamask/ramps-controller@14.1.0...@metamask/ramps-controller@14.1.1 [14.1.0]: https://github.com/MetaMask/core/compare/@metamask/ramps-controller@14.0.0...@metamask/ramps-controller@14.1.0 diff --git a/packages/ramps-controller/package.json b/packages/ramps-controller/package.json index 8184f042e4..d74dddbba9 100644 --- a/packages/ramps-controller/package.json +++ b/packages/ramps-controller/package.json @@ -1,6 +1,6 @@ { "name": "@metamask/ramps-controller", - "version": "14.2.0", + "version": "14.3.0", "description": "A controller for managing cryptocurrency on/off ramps functionality", "keywords": [ "Ethereum", diff --git a/packages/transaction-pay-controller/CHANGELOG.md b/packages/transaction-pay-controller/CHANGELOG.md index 82156cdbe0..0a26f749b7 100644 --- a/packages/transaction-pay-controller/CHANGELOG.md +++ b/packages/transaction-pay-controller/CHANGELOG.md @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +### Changed + +- Bump `@metamask/ramps-controller` from `^14.2.0` to `^14.3.0` ([#9199](https://github.com/MetaMask/core/pull/9199)) + ## [23.12.0] ### Changed diff --git a/packages/transaction-pay-controller/package.json b/packages/transaction-pay-controller/package.json index 040019a082..84f04b95ee 100644 --- a/packages/transaction-pay-controller/package.json +++ b/packages/transaction-pay-controller/package.json @@ -68,7 +68,7 @@ "@metamask/messenger": "^1.2.0", "@metamask/metamask-eth-abis": "^3.1.1", "@metamask/network-controller": "^32.0.0", - "@metamask/ramps-controller": "^14.2.0", + "@metamask/ramps-controller": "^14.3.0", "@metamask/remote-feature-flag-controller": "^4.2.2", "@metamask/transaction-controller": "^68.0.1", "@metamask/utils": "^11.11.0", diff --git a/yarn.lock b/yarn.lock index 1767486529..f68fd7e449 100644 --- a/yarn.lock +++ b/yarn.lock @@ -8056,7 +8056,7 @@ __metadata: languageName: node linkType: hard -"@metamask/ramps-controller@npm:^14.2.0, @metamask/ramps-controller@workspace:packages/ramps-controller": +"@metamask/ramps-controller@npm:^14.3.0, @metamask/ramps-controller@workspace:packages/ramps-controller": version: 0.0.0-use.local resolution: "@metamask/ramps-controller@workspace:packages/ramps-controller" dependencies: @@ -8703,7 +8703,7 @@ __metadata: "@metamask/messenger": "npm:^1.2.0" "@metamask/metamask-eth-abis": "npm:^3.1.1" "@metamask/network-controller": "npm:^32.0.0" - "@metamask/ramps-controller": "npm:^14.2.0" + "@metamask/ramps-controller": "npm:^14.3.0" "@metamask/remote-feature-flag-controller": "npm:^4.2.2" "@metamask/transaction-controller": "npm:^68.0.1" "@metamask/utils": "npm:^11.11.0"