Commit 0232dd7
authored
chore: remove importSrpWordSuggestion remote config flag (MetaMask#28139)
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->
## **Description**
* Removes the `importSrpWordSuggestion` remote flag and all code that
read it. The BIP39 word-suggestion bar experiment is complete, so the
app no longer depends on remote config flag for that UI.
* Jra: https://consensyssoftware.atlassian.net/browse/TO-647
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
## **Changelog**
<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`
If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`
(This helps the Release Engineer do their job more quickly and
accurately)
-->
CHANGELOG entry: Import SRP screens always show BIP39 word suggestions
when the keyboard is open, with no remote feature flag
## **Related issues**
Fixes:
## **Manual testing steps**
```gherkin
Feature: Import SRP BIP39 word suggestions bar
Scenario: Onboarding import wallet shows word suggestions while typing SRP
Given the user is on Import from SRP
And the keyboard is open
When the user types partial words in the SRP field
Then BIP39 word suggestions are shown and can be selected
Scenario: Import new SRP (multi-SRP) shows word suggestions while typing
Given the user is on Import New SRP
And the keyboard is open
When the user types partial words in the SRP field
Then BIP39 word suggestions are shown and can be selected
```
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **Before**
<!-- [screenshots/recordings] -->
### **After**
https://github.com/user-attachments/assets/8426a0a8-11d6-4f24-8eb6-b98208f584af
https://github.com/user-attachments/assets/11bf056f-a203-4fd1-a90c-27fa27982d76
<!-- [screenshots/recordings] -->
## **Pre-merge author checklist**
- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Medium Risk**
> Moderate risk because it changes onboarding wallet-import UI behavior
and removes a remote kill-switch, but the logic change is small and
localized to SRP import screens and flag plumbing.
>
> **Overview**
> Removes the `importSrpWordSuggestion` remote feature flag end-to-end
(feature flag enum entry, selector implementation + tests, and registry
entry).
>
> Updates both SRP import flows (`ImportFromSecretRecoveryPhrase` and
`ImportNewSecretRecoveryPhrase`) to *always* render `SrpWordSuggestions`
when the keyboard is visible (and on step 0 where applicable), and drops
the associated feature-flag mocks from the screen tests.
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
24f7f6a. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->1 parent 88afe15 commit 0232dd7
8 files changed
Lines changed: 15 additions & 307 deletions
File tree
- app
- components/Views
- ImportFromSecretRecoveryPhrase
- ImportNewSecretRecoveryPhrase
- constants
- selectors/featureFlagController/importSrpWordSuggestion
- tests/feature-flags
Lines changed: 14 additions & 22 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| |||
96 | 96 | | |
97 | 97 | | |
98 | 98 | | |
99 | | - | |
100 | 99 | | |
101 | 100 | | |
102 | 101 | | |
| |||
137 | 136 | | |
138 | 137 | | |
139 | 138 | | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | 139 | | |
146 | 140 | | |
147 | 141 | | |
| |||
845 | 839 | | |
846 | 840 | | |
847 | 841 | | |
848 | | - | |
849 | | - | |
850 | | - | |
851 | | - | |
852 | | - | |
853 | | - | |
854 | | - | |
855 | | - | |
856 | | - | |
857 | | - | |
858 | | - | |
859 | | - | |
860 | | - | |
861 | | - | |
862 | | - | |
| 842 | + | |
| 843 | + | |
| 844 | + | |
| 845 | + | |
| 846 | + | |
| 847 | + | |
| 848 | + | |
| 849 | + | |
| 850 | + | |
| 851 | + | |
| 852 | + | |
| 853 | + | |
| 854 | + | |
863 | 855 | | |
864 | 856 | | |
865 | 857 | | |
| |||
Lines changed: 0 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | 97 | | |
105 | 98 | | |
106 | 99 | | |
| |||
Lines changed: 0 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
141 | 141 | | |
142 | 142 | | |
143 | 143 | | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | 144 | | |
153 | 145 | | |
154 | 146 | | |
| |||
Lines changed: 1 addition & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
57 | 56 | | |
58 | 57 | | |
59 | 58 | | |
| |||
78 | 77 | | |
79 | 78 | | |
80 | 79 | | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | 80 | | |
87 | 81 | | |
88 | 82 | | |
| |||
329 | 323 | | |
330 | 324 | | |
331 | 325 | | |
332 | | - | |
| 326 | + | |
333 | 327 | | |
334 | 328 | | |
335 | 329 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | 13 | | |
15 | 14 | | |
16 | 15 | | |
| |||
Lines changed: 0 additions & 211 deletions
This file was deleted.
Lines changed: 0 additions & 40 deletions
This file was deleted.
0 commit comments