Commit 033777f
authored
chore: bump
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->
## Summary
- Update the mobile SDKConnect integration to match the latest
`mobile-wallet-protocol` APIs.
- Switch connection setup to `SessionStore.create(...)` and add peer
public key validation support in the mobile `KeyManager`.
- Align the SDKConnect unit tests with the new async session store
factory and key validation behavior.
## Test plan
- [ ] Run `yarn jest app/core/SDKConnectV2/services/connection.test.ts
app/core/SDKConnectV2/services/key-manager.test.ts --runInBand`
- [ ] Verify SDKConnect deeplink connection flow still initializes and
resumes sessions correctly
- [ ] Smoke test trusted and untrusted connection flows if needed
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
## **Changelog**
<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`
If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`
(This helps the Release Engineer do their job more quickly and
accurately)
-->
CHANGELOG entry: null
MetaMask Connect not released to public officially yet
## **Related issues**
Fixes:
## **Manual testing steps**
```gherkin
Feature: my feature name
Scenario: user [verb for user action]
Given [describe expected initial app state]
When user [verb for user action]
Then [describe expected outcome]
```
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **Before**
<!-- [screenshots/recordings] -->
### **After**
<!-- [screenshots/recordings] -->
## **Pre-merge author checklist**
- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Medium Risk**
> Medium risk due to a breaking dependency upgrade in the Mobile Wallet
Protocol stack and changes to connection/session-store initialization
and peer key validation that could affect SDKConnect session persistence
or handshake failures.
>
> **Overview**
> Updates SDKConnectV2 to the latest
`@metamask/mobile-wallet-protocol-core`/`wallet-client` versions and
absorbs API breaking changes.
>
> `Connection.create` now initializes the session store via async
`SessionStore.create(...)` (instead of `new SessionStore(...)`), with
unit tests updated to mock/expect the factory call.
>
> Adds `KeyManager.validatePeerKey` (using `eciesjs` `PublicKey`
parsing) plus new tests covering acceptance/rejection of peer public
keys.
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
9d63dbd. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->@metamask/mobile-wallet-protocol-core & @metamask/mobile-wallet-protocol-wallet-client to latest versions and absorb breaking changes (MetaMask#27215)1 parent 9975c8c commit 033777f
6 files changed
Lines changed: 40 additions & 28 deletions
File tree
- app/core/SDKConnectV2/services
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
27 | 29 | | |
28 | 30 | | |
29 | 31 | | |
| |||
47 | 49 | | |
48 | 50 | | |
49 | 51 | | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
50 | 55 | | |
51 | 56 | | |
52 | 57 | | |
| |||
139 | 144 | | |
140 | 145 | | |
141 | 146 | | |
| 147 | + | |
142 | 148 | | |
143 | 149 | | |
144 | 150 | | |
| |||
155 | 161 | | |
156 | 162 | | |
157 | 163 | | |
158 | | - | |
| 164 | + | |
159 | 165 | | |
160 | 166 | | |
161 | 167 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
180 | 180 | | |
181 | 181 | | |
182 | 182 | | |
183 | | - | |
| 183 | + | |
184 | 184 | | |
185 | 185 | | |
186 | 186 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
42 | 54 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
13 | 17 | | |
14 | 18 | | |
15 | 19 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
252 | 252 | | |
253 | 253 | | |
254 | 254 | | |
255 | | - | |
256 | | - | |
| 255 | + | |
| 256 | + | |
257 | 257 | | |
258 | 258 | | |
259 | 259 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8987 | 8987 | | |
8988 | 8988 | | |
8989 | 8989 | | |
8990 | | - | |
8991 | | - | |
8992 | | - | |
8993 | | - | |
8994 | | - | |
8995 | | - | |
8996 | | - | |
8997 | | - | |
8998 | | - | |
8999 | | - | |
9000 | | - | |
9001 | | - | |
9002 | | - | |
9003 | | - | |
| 8990 | + | |
| 8991 | + | |
| 8992 | + | |
9004 | 8993 | | |
| 8994 | + | |
9005 | 8995 | | |
9006 | 8996 | | |
9007 | 8997 | | |
9008 | | - | |
| 8998 | + | |
9009 | 8999 | | |
9010 | 9000 | | |
9011 | 9001 | | |
9012 | | - | |
9013 | | - | |
9014 | | - | |
| 9002 | + | |
| 9003 | + | |
| 9004 | + | |
9015 | 9005 | | |
9016 | | - | |
| 9006 | + | |
9017 | 9007 | | |
9018 | 9008 | | |
9019 | | - | |
| 9009 | + | |
9020 | 9010 | | |
9021 | 9011 | | |
9022 | 9012 | | |
| |||
35466 | 35456 | | |
35467 | 35457 | | |
35468 | 35458 | | |
35469 | | - | |
35470 | | - | |
| 35459 | + | |
| 35460 | + | |
35471 | 35461 | | |
35472 | 35462 | | |
35473 | 35463 | | |
| |||
0 commit comments