fix: remove ens calls when accounts list is opened (MetaMask#23920)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

remove ens calls from account list to improve perf

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: remove ens calls from account list to improve perf

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->


https://github.com/user-attachments/assets/0e03ec65-2c9e-4c24-8c72-825d5c809ca7






### **After**

<!-- [screenshots/recordings] -->



https://github.com/user-attachments/assets/353267ee-e869-41c8-a01c-1ffbe5b75883



## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Introduce a `fetchENS` flag to `useAccounts` (default true) and pass
`fetchENS: false` from `AccountSelector` to avoid ENS lookups when the
accounts list opens; add tests for both behaviors.
> 
> - **Hooks (`useAccounts`)**:
> - Add optional `fetchENS` param (default `true`) to
`UseAccountsParams` and hook signature.
>   - Conditionally call `fetchENSNames` based on `fetchENS`.
> - Export `evmAccounts` alongside `accounts` and `ensByAccountAddress`
(unchanged behavior).
> - **UI (`AccountSelector`)**:
> - Pass `{ isLoading: reloadAccounts, `fetchENS: false` }` to
`useAccounts` to skip ENS lookups when opening the account list.
> - **Tests (`useAccounts.test.ts`)**:
> - Add cases verifying ENS fetching when `fetchENS` is true (default
and explicit) and not fetching when `false`.
>   - Minor test description tweak (grammar).
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
3befab0. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Author: salimtb

app/components/Views/AccountSelector/AccountSelector.tsx

@@ -143,6 +143,7 @@ const AccountSelector = ({ route }: AccountSelectorProps) => {
   const accountsParams = useMemo(
     () => ({
       isLoading: reloadAccounts,
+      fetchENS: false,
     }),
     [reloadAccounts],
   );

app/components/hooks/useAccounts/useAccounts.test.ts

@@ -125,11 +125,73 @@ describe('useAccounts', () => {
     expect(result.current.ensByAccountAddress).toStrictEqual(expectedENSNames);
   });
 
-  it('return scopes for evm accounts', async () => {
+  it('returns scopes for evm accounts', async () => {
     const { result, waitForNextUpdate } = renderHook(() => useAccounts());
     await act(async () => {
       await waitForNextUpdate();
     });
     expect(result.current.accounts[0].scopes).toStrictEqual([EthScope.Eoa]);
   });
+
+  describe('fetchENS parameter', () => {
+    it('fetches ENS names when fetchENS is true (default)', async () => {
+      const expectedENSNames = {
+        [MOCK_ACCOUNT_1.address]: MOCK_ENS_CACHED_NAME,
+      };
+
+      const { result, waitForNextUpdate } = renderHook(() => useAccounts());
+      await act(async () => {
+        await waitForNextUpdate();
+      });
+
+      expect(result.current.ensByAccountAddress).toStrictEqual(
+        expectedENSNames,
+      );
+    });
+
+    it('fetches ENS names when fetchENS is explicitly true', async () => {
+      const expectedENSNames = {
+        [MOCK_ACCOUNT_1.address]: MOCK_ENS_CACHED_NAME,
+      };
+
+      const { result, waitForNextUpdate } = renderHook(() =>
+        useAccounts({ fetchENS: true }),
+      );
+      await act(async () => {
+        await waitForNextUpdate();
+      });
+
+      expect(result.current.ensByAccountAddress).toStrictEqual(
+        expectedENSNames,
+      );
+    });
+
+    it('does not fetch ENS names when fetchENS is false', async () => {
+      const { result } = renderHook(() => useAccounts({ fetchENS: false }));
+
+      // Give some time for any potential async operations
+      await act(async () => {
+        await new Promise((resolve) => setTimeout(resolve, 100));
+      });
+
+      expect(result.current.ensByAccountAddress).toStrictEqual({});
+    });
+
+    it('returns accounts but not ENS names when fetchENS is false', async () => {
+      const expectedInternalAccounts: Account[] = [
+        MOCK_ACCOUNT_1,
+        MOCK_ACCOUNT_2,
+      ];
+
+      const { result } = renderHook(() => useAccounts({ fetchENS: false }));
+
+      // Give some time for accounts to be populated
+      await act(async () => {
+        await new Promise((resolve) => setTimeout(resolve, 100));
+      });
+
+      expect(result.current.accounts).toStrictEqual(expectedInternalAccounts);
+      expect(result.current.ensByAccountAddress).toStrictEqual({});
+    });
+  });
 });

app/components/hooks/useAccounts/useAccounts.ts

@@ -31,6 +31,7 @@ import {
  */
 const useAccounts = ({
   isLoading = false,
+  fetchENS = true,
 }: UseAccountsParams = {}): UseAccounts => {
   const isMountedRef = useRef(false);
   const [accounts, setAccounts] = useState<Account[]>([]);
@@ -141,8 +142,15 @@ const useAccounts = ({
     setEVMAccounts(
       flattenedAccounts.filter((account) => !isNonEvmAddress(account.address)),
     );
-    fetchENSNames({ flattenedAccounts, startingIndex: selectedIndex });
-  }, [internalAccounts, fetchENSNames, selectedInternalAccount?.address]);
+    if (fetchENS) {
+      fetchENSNames({ flattenedAccounts, startingIndex: selectedIndex });
+    }
+  }, [
+    internalAccounts,
+    fetchENS,
+    fetchENSNames,
+    selectedInternalAccount?.address,
+  ]);
 
   useEffect(() => {
     if (!isMountedRef.current) {

app/components/hooks/useAccounts/useAccounts.types.ts

@@ -89,6 +89,11 @@ export interface UseAccountsParams {
    * @default false
    */
   isLoading?: boolean;
+  /**
+   * Optional boolean that indicates if ENS names should be fetched for accounts.
+   * @default true
+   */
+  fetchENS?: boolean;
 }
 
 /**