chore: swap out all npx calls to use yarn (MetaMask#19344)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

Using `npx` as a package manager is not desired in this repository. This
PR removes the use and replaces it will `yarn`.

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry:

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

Test Bitrise Build:
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2edf3a5f-50d0-4804-81b4-420a61ed3517

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Author: sethkfman

docs/readme/release-build-profiler.md

@@ -34,7 +34,7 @@ Notes:
 Chrome's tracing UI expects a JSON trace. Convert the `.cpuprofile` first:
 
 ```bash
-npx react-native-release-profiler --local /path/to/profile.cpuprofile
+yarn react-native-release-profiler --local /path/to/profile.cpuprofile
 ```
 
 Then open Chrome and load the generated JSON:

package.json

@@ -109,10 +109,10 @@
     "test:wdio:android": "yarn wdio ./wdio/config/android.config.debug.js",
     "test:wdio:android:browserstack": "yarn wdio ./wdio/config/android.config.browserstack.js",
     "test:wdio:android:browserstack:local": "yarn wdio ./wdio/config/android.config.browserstack.local.js",
-    "run-appwright:android-bs": "npx appwright test --project browserstack-android --config appwright/appwright.config.ts",
-    "run-appwright:ios-bs": "npx appwright test --project browserstack-ios --config appwright/appwright.config.ts",
-    "run-appwright:android": "npx appwright test --project android --config appwright/appwright.config.ts",
-    "run-appwright:ios": "npx appwright test --project ios --config appwright/appwright.config.ts",
+    "run-appwright:android-bs": "yarn appwright test --project browserstack-android --config appwright/appwright.config.ts",
+    "run-appwright:ios-bs": "yarn appwright test --project browserstack-ios --config appwright/appwright.config.ts",
+    "run-appwright:android": "yarn appwright test --project android --config appwright/appwright.config.ts",
+    "run-appwright:ios": "yarn appwright test --project ios --config appwright/appwright.config.ts",
     "test:depcheck": "yarn depcheck",
     "test:tgz-check": "./scripts/tgz-check.sh",
     "test:attribution-check": "./scripts/attributions-check.sh",
@@ -126,10 +126,10 @@
     "patch:approval": "./scripts/patch-approval-controller.sh",
     "storybook-generate": "sb-rn-get-stories",
     "storybook-watch": "sb-rn-watcher",
-    "gen-bundle:ios": "npx react-native bundle --platform ios --dev false --entry-file index.js --bundle-output ios/main.jsbundle",
-    "gen-bundle:android": "npx react-native bundle --platform android --dev false --entry-file index.js --bundle-output android/main.jsbundle",
+    "gen-bundle:ios": "yarn react-native bundle --platform ios --dev false --entry-file index.js --bundle-output ios/main.jsbundle",
+    "gen-bundle:android": "yarn react-native bundle --platform android --dev false --entry-file index.js --bundle-output android/main.jsbundle",
     "circular:deps": "dpdm ./app/* --circular --exit-code circular:1 --warning=false",
-    "generate-icons": "npx ts-node app/component-library/components/Icons/Icon/scripts/generate-assets.ts"
+    "generate-icons": "yarn ts-node app/component-library/components/Icons/Icon/scripts/generate-assets.ts"
   },
   "lint-staged": {
     "*.{js,jsx,ts,tsx}": [

scripts/build.sh

@@ -325,7 +325,7 @@ buildAndroidRun(){
 	remapEnvVariableLocal
 	prebuild_android
 	#react-native run-android --port=$WATCHER_PORT --variant=prodDebug --active-arch-only
-	npx expo run:android --no-install --port $WATCHER_PORT --variant 'prodDebug' --device
+	yarn expo run:android --no-install --port $WATCHER_PORT --variant 'prodDebug' --device
 }
 
 # Builds the Main APK for local development
@@ -356,13 +356,13 @@ buildAndroidRunQA(){
 	remapEnvVariableLocal
 	prebuild_android
 	#react-native run-android --port=$WATCHER_PORT --variant=qaDebug --active-arch-only
-	npx expo run:android --no-install --port $WATCHER_PORT --variant 'qaDebug'
+	yarn expo run:android --no-install --port $WATCHER_PORT --variant 'qaDebug'
 }
 
 buildAndroidRunFlask(){
 	prebuild_android
 	#react-native run-android --port=$WATCHER_PORT --variant=flaskDebug --active-arch-only
-	npx expo run:android --no-install  --port $WATCHER_PORT --variant 'flaskDebug'
+	yarn expo run:android --no-install  --port $WATCHER_PORT --variant 'flaskDebug'
 }
 
 buildIosSimulator(){
@@ -372,21 +372,21 @@ buildIosSimulator(){
 	if [ -n "$IOS_SIMULATOR" ]; then
 		device_args=(--device "$IOS_SIMULATOR")
 	fi
-	npx expo run:ios --no-install --configuration Debug --port $WATCHER_PORT "${device_args[@]}"
+	yarn expo run:ios --no-install --configuration Debug --port $WATCHER_PORT "${device_args[@]}"
 }
 
 buildIosSimulatorQA(){
 	prebuild_ios
 	SIM="${IOS_SIMULATOR:-"iPhone 13 Pro"}"
 	#react-native run-ios --port=$WATCHER_PORT --simulator "$SIM" --scheme "MetaMask-QA"
 
-	npx expo run:ios --no-install --configuration Debug --port $WATCHER_PORT --device "$SIM" --scheme "MetaMask-QA"
+	yarn expo run:ios --no-install --configuration Debug --port $WATCHER_PORT --device "$SIM" --scheme "MetaMask-QA"
 }
 
 buildIosSimulatorFlask(){
 	prebuild_ios
 	SIM="${IOS_SIMULATOR:-"iPhone 13 Pro"}"
-	npx expo run:ios --no-install --configuration Debug --port $WATCHER_PORT --device "$SIM" --scheme "MetaMask-Flask"
+	yarn expo run:ios --no-install --configuration Debug --port $WATCHER_PORT --device "$SIM" --scheme "MetaMask-Flask"
 }
 
 buildIosSimulatorE2E(){
@@ -411,17 +411,17 @@ runIosE2E(){
 buildIosDevice(){
 	remapEnvVariableLocal
 	prebuild_ios
-	npx expo run:ios --no-install --configuration Debug --port $WATCHER_PORT --device
+	yarn expo run:ios --no-install --configuration Debug --port $WATCHER_PORT --device
 }
 
 buildIosDeviceQA(){
 	prebuild_ios
-	npx expo run:ios --no-install --port $WATCHER_PORT --configuration Debug --scheme "MetaMask-QA" --device
+	yarn expo run:ios --no-install --port $WATCHER_PORT --configuration Debug --scheme "MetaMask-QA" --device
 }
 
 buildIosDeviceFlask(){
 	prebuild_ios
-	npx expo run:ios --no-install --configuration Debug --scheme "MetaMask-Flask" --device
+	yarn expo run:ios --no-install --configuration Debug --scheme "MetaMask-Flask" --device
 }
 
 # Generates the iOS binary for the given scheme and configuration
@@ -676,10 +676,10 @@ startWatcher() {
 		watchman watch-del-all
 		rm -rf $TMPDIR/metro-cache
 		#react-native start --port=$WATCHER_PORT -- --reset-cache
-		npx expo start --port $WATCHER_PORT --clear
+		yarn expo start --port $WATCHER_PORT --clear
 	else
 		#react-native start --port=$WATCHER_PORT
-		npx expo start --port $WATCHER_PORT
+		yarn expo start --port $WATCHER_PORT
 	fi
 }