Skip to content

Commit 0a9c378

Browse files
test: quarantine flaky browser tests (MetaMask#18432)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
1 parent 08ef538 commit 0a9c378

1 file changed

Lines changed: 19 additions & 19 deletions

File tree

e2e/specs/browser/browser-tests.spec.ts renamed to e2e/specs/quarantine/browser/browser-tests.failing.ts

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,22 @@
1-
import { SmokeWalletPlatform } from '../../tags';
2-
import { loginToApp } from '../../viewHelper';
3-
import FixtureBuilder from '../../framework/fixtures/FixtureBuilder';
4-
import { withFixtures } from '../../framework/fixtures/FixtureHelper';
5-
import ExternalSites from '../../resources/externalsites.json';
6-
import Browser from '../../pages/Browser/BrowserView';
7-
import EnsWebsite from '../../pages/Browser/ExternalWebsites/EnsWebsite.ts';
8-
import TabBarComponent from '../../pages/wallet/TabBarComponent';
9-
import Assertions from '../../framework/Assertions';
10-
import ConnectBottomSheet from '../../pages/Browser/ConnectBottomSheet.ts';
11-
import RedirectWebsite from '../../pages/Browser/ExternalWebsites/RedirectWebsite.ts';
12-
import UniswapWebsite from '../../pages/Browser/ExternalWebsites/UniswapWebsite.ts';
13-
import OpenseaWebsite from '../../pages/Browser/ExternalWebsites/OpenseaWebsite.ts';
14-
import PancakeSwapWebsite from '../../pages/Browser/ExternalWebsites/PancakeSwapWebsite.ts';
15-
import DownloadFile from '../../pages/Browser/DownloadFile.ts';
16-
import DownloadFileWebsite from '../../pages/Browser/ExternalWebsites/DownloadFileWebsite.ts';
17-
import TestHelpers from '../../helpers';
18-
import CameraWebsite from '../../pages/Browser/ExternalWebsites/Security/CameraWebsite.ts';
19-
import HistoryDisclosureWebsite from '../../pages/Browser/ExternalWebsites/Security/HistoryDisclosureWebsite.ts';
1+
import { SmokeWalletPlatform } from '../../../tags.js';
2+
import { loginToApp } from '../../../viewHelper.ts';
3+
import FixtureBuilder from '../../../framework/fixtures/FixtureBuilder.ts';
4+
import { withFixtures } from '../../../framework/fixtures/FixtureHelper.ts';
5+
import ExternalSites from '../../../resources/externalsites.json';
6+
import Browser from '../../../pages/Browser/BrowserView.ts';
7+
import EnsWebsite from '../../../pages/Browser/ExternalWebsites/EnsWebsite.ts';
8+
import TabBarComponent from '../../../pages/wallet/TabBarComponent.ts';
9+
import Assertions from '../../../framework/Assertions.ts';
10+
import ConnectBottomSheet from '../../../pages/Browser/ConnectBottomSheet.ts';
11+
import RedirectWebsite from '../../../pages/Browser/ExternalWebsites/RedirectWebsite.ts';
12+
import UniswapWebsite from '../../../pages/Browser/ExternalWebsites/UniswapWebsite.ts';
13+
import OpenseaWebsite from '../../../pages/Browser/ExternalWebsites/OpenseaWebsite.ts';
14+
import PancakeSwapWebsite from '../../../pages/Browser/ExternalWebsites/PancakeSwapWebsite.ts';
15+
import DownloadFile from '../../../pages/Browser/DownloadFile.ts';
16+
import DownloadFileWebsite from '../../../pages/Browser/ExternalWebsites/DownloadFileWebsite.ts';
17+
import TestHelpers from '../../../helpers.js';
18+
import CameraWebsite from '../../../pages/Browser/ExternalWebsites/Security/CameraWebsite.ts';
19+
import HistoryDisclosureWebsite from '../../../pages/Browser/ExternalWebsites/Security/HistoryDisclosureWebsite.ts';
2020

2121
const getHostFromURL = (url: string): string => {
2222
try {

0 commit comments

Comments
 (0)