Skip to content

Commit 10b85d3

Browse files
authored
feat: improve Predict withdrawal toast messaging (MetaMask#23045)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Update withdrawal toast messages to be clearer and more user-friendly: - Simplify pending withdrawal title from "Withdrawing {amount} USDC" to "Withdrawal in progress" - Change pending subtitle to "Available in about 1 minute" for clearer expectation - Update completed message from "Withdrawal completed" to "Withdrawal complete" - Revise completed subtitle to "{amount} USDC moved to your wallet" for clarity - Format withdrawal amounts using formatPrice utility for consistent display <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/PRED-312?atlOrigin=eyJpIjoiYjZjMTlkNjRjYzEwNDY5OGE1ODczMjI4MGRlNGEwYzkiLCJwIjoiaiJ9 ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Simplifies Predict withdrawal toasts and locales, removing dynamic placeholders and formatting amounts with `formatPrice`. > > - **Predict UI**: > - `app/components/UI/Predict/hooks/usePredictWithdrawToasts.ts`: > - Format confirmed withdrawal amounts with `formatPrice`. > - Pending toast no longer passes `amount`/`time`; uses static `withdrawing`/`withdrawing_subtitle` strings. > - Updated pending/confirmed toast configs to match new copy. > - **Locales**: > - `locales/languages/en.json`: > - Simplified `predict.withdraw` strings (static pending title/subtitle; refined completed title/subtitle). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit eaaea2d. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent 1e56dee commit 10b85d3

2 files changed

Lines changed: 9 additions & 12 deletions

File tree

app/components/UI/Predict/hooks/usePredictWithdrawToasts.ts

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import { usePredictToasts } from './usePredictToasts';
66
import { PredictWithdrawStatus } from '../types';
77
import { useEffect } from 'react';
88
import { usePredictBalance } from './usePredictBalance';
9+
import { formatPrice } from '../utils/format';
910

1011
export const usePredictWithdrawToasts = () => {
1112
const { loadBalance } = usePredictBalance();
@@ -21,7 +22,8 @@ export const usePredictWithdrawToasts = () => {
2122
description: strings('predict.withdraw.withdraw_completed_subtitle', {
2223
amount: '{amount}',
2324
}),
24-
getAmount: () => withdrawTransaction?.amount.toString() ?? '0',
25+
getAmount: () =>
26+
formatPrice(withdrawTransaction?.amount.toString() ?? '0'),
2527
},
2628
errorToastConfig: {
2729
title: strings('predict.withdraw.error_title'),
@@ -36,14 +38,9 @@ export const usePredictWithdrawToasts = () => {
3638
useEffect(() => {
3739
if (withdrawTransaction?.status === PredictWithdrawStatus.PENDING) {
3840
showPendingToast({
39-
amount: withdrawTransaction?.amount.toString() ?? '0',
4041
config: {
41-
title: strings('predict.withdraw.withdrawing', {
42-
amount: '{amount}',
43-
}),
44-
description: strings('predict.withdraw.withdrawing_subtitle', {
45-
time: 30,
46-
}),
42+
title: strings('predict.withdraw.withdrawing'),
43+
description: strings('predict.withdraw.withdrawing_subtitle'),
4744
},
4845
});
4946
}

locales/languages/en.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1942,10 +1942,10 @@
19421942
"order_failed_generic": "Transaction failed. Please try again."
19431943
},
19441944
"withdraw": {
1945-
"withdrawing": "Withdrawing {{amount}} USDC",
1946-
"withdrawing_subtitle": "Est. {{time}} seconds",
1947-
"withdraw_completed": "Withdrawal completed",
1948-
"withdraw_completed_subtitle": "{{amount}} USDC added to your balance",
1945+
"withdrawing": "Withdrawal in progress",
1946+
"withdrawing_subtitle": "Available in about 1 minute",
1947+
"withdraw_completed": "Withdrawal complete",
1948+
"withdraw_completed_subtitle": "{{amount}} USDC moved to your wallet",
19491949
"error_title": "Something went wrong",
19501950
"error_description": "Failed to proceed with withdraw",
19511951
"try_again": "Try again"

0 commit comments

Comments
 (0)