fix: do not display Snap account dialogs for multichain wallet Snaps (MetaMask#23218)

## **Description**

Similar fix (technical details on this PR too):
- MetaMask/metamask-extension#38061

## **Changelog**

CHANGELOG entry: Prevent any dialogs for multichain wallet Snaps
(Solana, Bitcoin, Tron)

## **Related issues**

Fixes:
- MetaMask#22465

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Skip Snap account dialogs and naming for preinstalled multichain
wallet Snaps under state 2, with E2E-safe fallback and updated tests.
> 
> - **Core/SnapKeyring**:
> - Enhance `addAccount` flow to auto-skip dialogs for preinstalled
multichain wallet Snaps when multichain accounts state 2 is enabled.
> - Introduce `isMultichainWalletSnap` and `isE2E` checks; derive
`skipAll` to bypass confirmation, name suggestion, and selection steps.
> - Set `accountNameSuggestion` to ``''`` when skipping to avoid race
conditions; update `skipApprovalFlow` logic accordingly.
>   - Preserve legacy behavior in E2E runs by disabling skips.
> - **Tests**:
> - Mock `isMultichainWalletSnap` and extend scenarios for state 2,
verifying dialog skipping and naming behavior.
> - Minor adjustments to expectations around flows and account
naming/selection.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
fd81303. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Author: ccharly

app/core/SnapKeyring/SnapKeyring.test.ts

@@ -167,6 +167,7 @@ const createSnapKeyringBuilder = () =>
 // Mock the isSnapPreinstalled function
 jest.mock('./utils/snaps', () => ({
   isSnapPreinstalled: jest.fn(),
+  isMultichainWalletSnap: jest.fn().mockReturnValue(false),
   getSnapName: jest.fn().mockReturnValue('Mock Snap Name'),
 }));
 

app/core/SnapKeyring/SnapKeyring.ts

@@ -10,14 +10,19 @@ import { SnapKeyringBuilderMessenger } from './types';
 import { SnapId } from '@metamask/snaps-sdk';
 import { assertIsValidSnapId } from '@metamask/snaps-utils';
 import { getUniqueAccountName } from './utils/getUniqueAccountName';
-import { getSnapName, isSnapPreinstalled } from './utils/snaps';
+import {
+  getSnapName,
+  isMultichainWalletSnap,
+  isSnapPreinstalled,
+} from './utils/snaps';
 import { endTrace, TraceName } from '../../util/trace';
 import { store } from '../../store';
 import { MetaMetricsEvents } from '../../core/Analytics/MetaMetrics.events';
 import { trackSnapAccountEvent } from '../Analytics/helpers/SnapKeyring/trackSnapAccountEvent';
 import { endPerformanceTrace } from '../../core/redux/slices/performance';
 import { PerformanceEventNames } from '../redux/slices/performance/constants';
 import { areAddressesEqual } from '../../util/address';
+import { isE2E } from '../../util/test/utils';
 import { isMultichainAccountsState2Enabled } from '../../multichain-accounts/remote-feature-flag';
 
 /**
@@ -246,28 +251,47 @@ class SnapKeyringImpl implements SnapKeyringCallbacks {
   ) {
     assertIsValidSnapId(snapId);
 
+    // Preinstalled Snaps can skip some confirmation dialogs.
+    const isPreinstalled = isSnapPreinstalled(snapId);
+
+    // Since the introduction of BIP-44, multichain wallet Snaps will skip them automatically too!
+    let skipAll =
+      isMultichainAccountsState2Enabled() &&
+      isPreinstalled &&
+      isMultichainWalletSnap(snapId);
+    // FIXME: We still rely on the old behavior in some e2e, so we do not skip them in this case.
+    if (isE2E) {
+      skipAll = false;
+    }
+
+    // If Snap is preinstalled and does not request confirmation, skip the confirmation dialog.
+    const skipConfirmationDialog =
+      skipAll || (isPreinstalled && !displayConfirmation);
+
     // Only pre-installed Snaps can skip the account name suggestion dialog.
     const skipAccountNameSuggestionDialog =
-      isSnapPreinstalled(snapId) && !displayAccountNameSuggestion;
+      skipAll || (isPreinstalled && !displayAccountNameSuggestion);
+
+    // Only pre-installed Snaps can skip the account from being selected.
+    const skipSetSelectedAccountStep =
+      skipAll || (isPreinstalled && !setSelectedAccount);
+
     const skipApprovalFlow =
-      isSnapPreinstalled(snapId) &&
-      skipAccountNameSuggestionDialog &&
-      !displayConfirmation;
+      skipConfirmationDialog && skipAccountNameSuggestionDialog;
 
     // First part of the flow, which includes confirmation dialogs (if not skipped).
     // Once confirmed, we resume the Snap execution.
     const { accountName } = await this.addAccountConfirmations({
       snapId,
-      accountNameSuggestion,
+      // We do not set the account name suggestion if it's a multichain wallet Snap since the
+      // current naming could have race conditions with other account creations, and since
+      // naming is now handled by multichain account groups, we can skip this entirely.
+      accountNameSuggestion: skipAll ? '' : accountNameSuggestion,
       handleUserInput,
       skipAccountNameSuggestionDialog,
       skipApprovalFlow,
     });
 
-    // Only pre-installed Snaps can skip the account from being selected.
-    const skipSetSelectedAccountStep =
-      isSnapPreinstalled(snapId) && !setSelectedAccount;
-
     // The second part is about selecting the newly created account and showing some other
     // confirmation dialogs (or error dialogs if anything goes wrong while persisting the account
     // into the state.