Skip to content

Commit 275dfaf

Browse files
fix(analytics): cp-7.63.1 correct capitalization in Deep link event name (MetaMask#25592)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> - fix capitalization typo in event name making it invalid agains Segment Schema ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/MCWP-319 ## **Manual testing steps** N/A ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** N/A ### **After** N/A ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk string-only change to an analytics event label plus a matching test update; no functional logic paths are modified. > > **Overview** > Fixes the `DEEP_LINK_USED` MetaMetrics event display name capitalization from `Deep link Used` to `Deep Link Used` to align with expected analytics/schema naming. > > Updates `DeepLinkModal` test mocks to expect the corrected event name. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 7aedbd8. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent a6e8590 commit 275dfaf

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

app/components/UI/DeepLinkModal/DeepLinkModal.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ describe('DeepLinkModal', () => {
143143
}),
144144
build: jest.fn().mockImplementation(function (this: MockBuilder) {
145145
return {
146-
name: 'Deep link Used',
146+
name: 'Deep Link Used',
147147
properties: {
148148
route: 'invalid',
149149
was_app_installed: true,

app/core/Analytics/MetaMetrics.events.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -516,7 +516,7 @@ enum EVENT_NAME {
516516
NetworkConnectionBannerRpcUpdated = 'Network Connection Banner RPC Updated',
517517

518518
// Deep Link Analytics - Consolidated Event
519-
DEEP_LINK_USED = 'Deep link Used',
519+
DEEP_LINK_USED = 'Deep Link Used',
520520

521521
// What's New Link Clicked
522522
WHATS_NEW_LINK_CLICKED = "What's New Link Clicked",

0 commit comments

Comments
 (0)