Skip to content

Commit 27e7f2e

Browse files
authored
fix(predict): use MINIMUM_BET directly for validation cp-7.61.0 (MetaMask#23748)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Removes unnecessary fee calculations from minimum bet check. The canPlaceBet validation now compares currentValue directly against MINIMUM_BET instead of adding fees to the minimum threshold. This fixes an issue where users needed to input more than the actual minimum bet due to fees being incorrectly added to the minimum requirement. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: MetaMask#23740 ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Removes fee-based minimum bet calculations and validates `canPlaceBet` directly against `MINIMUM_BET`. > > - **Predict Buy Preview (`app/components/UI/Predict/views/PredictBuyPreview/PredictBuyPreview.tsx`)**: > - Remove `minimumBetFees` and `minimumBetWithFees` calculations. > - Update `canPlaceBet` to require `currentValue >= MINIMUM_BET` (no fees added to threshold). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit dbb3489. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
2 parents 9ec45c6 + dbb3489 commit 27e7f2e

1 file changed

Lines changed: 1 addition & 11 deletions

File tree

app/components/UI/Predict/views/PredictBuyPreview/PredictBuyPreview.tsx

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -196,20 +196,10 @@ const PredictBuyPreview = () => {
196196
const providerFee = preview?.fees?.providerFee ?? 0;
197197
const total = currentValue + providerFee + metamaskFee;
198198

199-
const minimumBetFees = useMemo(
200-
() => (MINIMUM_BET * (preview?.fees?.totalFeePercentage ?? 0)) / 100,
201-
[preview?.fees?.totalFeePercentage],
202-
);
203-
204-
// Validation constants and states
205-
const minimumBetWithFees = useMemo(
206-
() => MINIMUM_BET + minimumBetFees,
207-
[minimumBetFees],
208-
);
209199
const hasInsufficientFunds = total > balance;
210200
const isBelowMinimum = currentValue > 0 && currentValue < MINIMUM_BET;
211201
const canPlaceBet =
212-
currentValue >= minimumBetWithFees &&
202+
currentValue >= MINIMUM_BET &&
213203
!hasInsufficientFunds &&
214204
preview &&
215205
!isLoading &&

0 commit comments

Comments
 (0)