chore: refactor delete wallet into Authentication service (MetaMask#23882)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR refactors wallet deletion logic by consolidating the
`useDeleteWallet` hook into the `Authentication` service class. The
refactoring improves code organization, ensures consistent wallet
deletion behavior, and simplifies the codebase by removing redundant
hook logic.

**Reason for the change:**
1. The `useDeleteWallet` hook duplicated logic that should be
centralized in the `Authentication` service
2. `resetWalletState` and `deleteUser` were always used together, but
there was no enforcement of this pattern
3. Having wallet deletion logic in a hook created unnecessary coupling
between React components and core authentication logic
4. The hook pattern was not appropriate for core service operations that
don't depend on React lifecycle

**Improvement/Solution:**
1. **Moved Logic to Authentication Service**: Consolidated
`resetWalletState` and `deleteUser` methods into
`app/core/Authentication/Authentication.ts` as protected methods
2. **Created Public API**: Added `deleteWallet()` as the main public
method that ensures `resetWalletState()` is always called before
`deleteUser()`
3. **Protected Methods**: Made `resetWalletState` and `deleteUser`
protected to prevent direct external access and enforce the correct
usage pattern through `deleteWallet()`
4. **Updated All Call Sites**: Refactored `usePromptSeedlessRelogin` and
`DeleteWalletModal` to use the new `Authentication.deleteWallet()`
method
5. **Comprehensive Test Coverage**: Added tests for the new
`deleteWallet()` method and maintained test coverage for the protected
methods

**Key Technical Improvements:**
- **Removed Hook**: Deleted
`app/components/hooks/DeleteWallet/useDeleteWallet.ts` and related test
files
- **Centralized Logic**: All wallet deletion logic is now in the
`Authentication` service, following the single responsibility principle
- **Enforced Usage Pattern**: The protected methods ensure that wallet
reset and user deletion always happen in the correct sequence
- **Better Encapsulation**: Protected methods prevent accidental misuse
and make the API surface clearer
- **Consistent Behavior**: All wallet deletion flows now use the same
underlying implementation

## **Changelog**

CHANGELOG entry: Refactored wallet deletion logic by consolidating
useDeleteWallet hook into Authentication service

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: Wallet Deletion

  Scenario: Delete wallet from seedless relogin prompt
    Given the user encounters a seedless controller error
    And the error prompt is displayed
    When the user taps the primary button to delete wallet
    Then the wallet state should be reset
    And user data should be deleted
    And the user should be navigated to onboarding
    And no errors should occur during the deletion process

  Scenario: Delete wallet from settings
    Given the user is viewing the Security Settings screen
    And the user navigates to the Delete Wallet modal
    When the user confirms wallet deletion
    Then the wallet state should be reset
    And user data should be deleted
    And cookies should be cleared
    And the user should be navigated to onboarding
    And analytics should track the deletion event

  Scenario: Wallet deletion error handling
    Given the user attempts to delete the wallet
    When an error occurs during wallet reset
    Then the error should be logged
    And the loading state should be reset
    And the user should see appropriate error feedback
    And the app should remain in a stable state
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- 
Before: Wallet deletion logic was split between a hook and the
Authentication service
- useDeleteWallet hook managed resetWalletState and deleteUser
separately
- Components had to call both methods in sequence manually
- No enforcement that both methods were always called together
-->

### **After**


https://github.com/user-attachments/assets/7dcb9cc3-cb52-4c50-8f1c-009fa402d1de



<!-- 
After: Wallet deletion is centralized in Authentication service
- Single deleteWallet() method ensures correct sequence
- Protected methods prevent misuse
- Cleaner component code with single method call
-->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Centralizes wallet deletion into `Authentication.deleteWallet()` and
refactors consumers/tests to use it, removing the old `useDeleteWallet`
hook.
> 
> - **Core (Authentication)**:
> - Add `Authentication.deleteWallet()` as the public API; implements
sequential `resetWalletState` → `deleteUser`.
> - `resetWalletState` (protected): clears vault backups,
disables/re-enables `EngineClass.disableAutomaticVaultBackup`, creates
temp wallet, clears seedless state, resets rewards via
`Engine.controllerMessenger`, clears provider token, locks app (no
navigation).
> - `deleteUser` (protected): dispatches `setExistingUser(false)` and
triggers `MetaMetrics.createDataDeletionTask`.
> - Also removes `OPTIN_META_METRICS_UI_SEEN` and dispatches
`setCompletedOnboarding(false)`.
> - **UI**:
> - `DeleteWalletModal`: replace hook flow with
`Authentication.deleteWallet()`, keep sign-out, clear cookies, dispatch
`clearHistory`, track event, then navigate to onboarding.
> - `usePromptSeedlessRelogin`: invoke `Authentication.deleteWallet()`
and simplify flow; maintain loading/error state and `clearHistory` +
sign-out + navigation.
> - **Hooks**:
>   - Remove `app/components/hooks/DeleteWallet/*` (hook and tests).
> - **Tests**:
> - Add comprehensive tests for `deleteWallet`, `resetWalletState`, and
`deleteUser` in `Authentication.test.ts`.
> - Update component/hook tests to assert calls to
`Authentication.deleteWallet()` and revised action sequences; remove
assertions tied to deleted hook/storage calls.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
b71e98d. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Author: tommasini

app/components/UI/DeleteWalletModal/index.test.tsx

@@ -9,11 +9,9 @@ import { createStackNavigator } from '@react-navigation/stack';
 import { RootState } from '../../../reducers';
 import { strings } from '../../../../locales/i18n';
 import { ForgotPasswordModalSelectorsIDs } from '../../../../e2e/selectors/Common/ForgotPasswordModal.selectors';
-import { SET_COMPLETED_ONBOARDING } from '../../../actions/onboarding';
 import { InteractionManager } from 'react-native';
-import StorageWrapper from '../../../store/storage-wrapper';
-import { OPTIN_META_METRICS_UI_SEEN } from '../../../constants/storage';
 import { clearHistory } from '../../../actions/browser';
+import { Authentication } from '../../../core/Authentication/Authentication';
 
 const mockInitialState = {
   engine: { backgroundState },
@@ -22,12 +20,6 @@ const mockInitialState = {
   },
 };
 
-jest.mock('../../../store/storage-wrapper', () => ({
-  getItem: jest.fn(),
-  setItem: jest.fn(),
-  removeItem: jest.fn(),
-}));
-
 const mockUseDispatch = jest.fn();
 
 jest.mock('react-redux', () => ({
@@ -74,11 +66,10 @@ jest.mock('../../../util/identity/hooks/useAuthentication', () => ({
   }),
 }));
 
-jest.mock('../../hooks/DeleteWallet', () => ({
-  useDeleteWallet: () => [
-    jest.fn(() => Promise.resolve()),
-    jest.fn(() => Promise.resolve()),
-  ],
+jest.mock('../../../core/Authentication/Authentication', () => ({
+  Authentication: {
+    deleteWallet: jest.fn(() => Promise.resolve()),
+  },
 }));
 
 const Stack = createStackNavigator();
@@ -153,7 +144,6 @@ describe('DeleteWalletModal', () => {
     });
 
     it('signs the user out when deleting the wallet', async () => {
-      const removeItemSpy = jest.spyOn(StorageWrapper, 'removeItem');
       const { getByTestId } = renderComponent(mockInitialState);
 
       fireEvent.press(
@@ -164,11 +154,9 @@ describe('DeleteWalletModal', () => {
       );
 
       expect(mockSignOut).toHaveBeenCalled();
-      expect(removeItemSpy).toHaveBeenCalledWith(OPTIN_META_METRICS_UI_SEEN);
     });
 
-    it('sets completedOnboarding to false when deleting the wallet', async () => {
-      const removeItemSpy = jest.spyOn(StorageWrapper, 'removeItem');
+    it('calls deleteWallet when deleting the wallet', async () => {
       const { getByTestId } = renderComponent(mockInitialState);
 
       fireEvent.press(
@@ -178,13 +166,10 @@ describe('DeleteWalletModal', () => {
         getByTestId(ForgotPasswordModalSelectorsIDs.YES_RESET_WALLET_BUTTON),
       );
 
-      expect(mockUseDispatch).toHaveBeenCalledWith(
-        expect.objectContaining({
-          type: SET_COMPLETED_ONBOARDING,
-          completedOnboarding: false,
-        }),
-      );
-      expect(removeItemSpy).toHaveBeenCalledWith(OPTIN_META_METRICS_UI_SEEN);
+      // Wait for async operations
+      await Promise.resolve();
+
+      expect(Authentication.deleteWallet).toHaveBeenCalled();
     });
   });
 

app/components/UI/DeleteWalletModal/index.tsx

@@ -7,14 +7,13 @@ import Icon, {
   IconColor,
 } from '../../../component-library/components/Icons/Icon';
 import { createStyles } from './styles';
-import { useDeleteWallet } from '../../hooks/DeleteWallet';
+import { Authentication } from '../../../core';
 import { strings } from '../../../../locales/i18n';
 import { useTheme } from '../../../util/theme';
 import Device from '../../../util/device';
 import Routes from '../../../constants/navigation/Routes';
 import { ForgotPasswordModalSelectorsIDs } from '../../../../e2e/selectors/Common/ForgotPasswordModal.selectors';
 import { IMetaMetricsEvent, MetaMetricsEvents } from '../../../core/Analytics';
-import { setCompletedOnboarding } from '../../../actions/onboarding';
 import { useDispatch, useSelector } from 'react-redux';
 import { clearHistory } from '../../../actions/browser';
 import CookieManager from '@react-native-cookies/cookies';
@@ -38,8 +37,6 @@ import { useMetrics } from '../../hooks/useMetrics';
 import ButtonIcon, {
   ButtonIconSizes,
 } from '../../../component-library/components/Buttons/ButtonIcon';
-import StorageWrapper from '../../../store/storage-wrapper';
-import { OPTIN_META_METRICS_UI_SEEN } from '../../../constants/storage';
 
 if (Device.isAndroid() && UIManager.setLayoutAnimationEnabledExperimental) {
   UIManager.setLayoutAnimationEnabledExperimental(true);
@@ -62,7 +59,6 @@ const DeleteWalletModal: React.FC = () => {
 
   const [isResetWallet, setIsResetWallet] = useState<boolean>(false);
 
-  const [resetWalletState, deleteUser] = useDeleteWallet();
   const dispatch = useDispatch();
   const isDataCollectionForMarketingEnabled = useSelector(
     (state: RootState) => state.security.dataCollectionForMarketing,
@@ -115,10 +111,7 @@ const DeleteWalletModal: React.FC = () => {
       dispatch(clearHistory(isEnabled(), isDataCollectionForMarketingEnabled));
       signOut();
       await CookieManager.clearAll(true);
-      await resetWalletState();
-      await deleteUser();
-      await StorageWrapper.removeItem(OPTIN_META_METRICS_UI_SEEN);
-      dispatch(setCompletedOnboarding(false));
+      await Authentication.deleteWallet();
       // Track analytics for successful deletion
       track(MetaMetricsEvents.RESET_WALLET_CONFIRMED, {});
       InteractionManager.runAfterInteractions(() => {