refactor: remove forward selected account group (MetaMask#31761)

## **Description**

The `SnapAccountService` already handle this logic, we don't need this
on the client side anymore.

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Fixes: N/A

## **Manual testing steps**

```gherkin
Feature: Selecting an account

  Scenario: user selects an account
    Given given it has funds on this account

    When user select the new account
    Then the account IDs are forwarded to the multichain Snaps, so balances are updated
```

## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

<!-- mms-check: type=checklist required=true -->

<!--
Every checklist item must be consciously assessed before marking this PR
as
"Ready for review". A checked box means you deliberately considered that
responsibility, not that you literally performed every action listed.

Unchecked boxes are ambiguous: they are not an implicit "N/A" and they
are not
a silent "skip". See `docs/readme/ready-for-review.md` for the full
checklist
semantics.
-->

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

#### Performance checks (if applicable)

- [ ] I've tested on Android
  - Ideally on a mid-range device; emulator is acceptable
- [ ] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [ ] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example

For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).

## **Pre-merge reviewer checklist**

<!--
Reviewer checklist items follow the same semantics as the author
checklist: an
unchecked box is ambiguous, a checked box means the reviewer consciously
assessed that responsibility. See `docs/readme/ready-for-review.md`.
-->

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Hassan Malik <hbmalik88@gmail.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: 3 people

app/core/Engine/controllers/multichain-account-service/multichain-account-service-init.ts

@@ -6,8 +6,6 @@ import {
   TRX_ACCOUNT_PROVIDER_NAME,
 } from '@metamask/multichain-account-service';
 import { MessengerClientInitFunction } from '../../types';
-import Engine from '../../Engine';
-import { forwardSelectedAccountGroupToSnapKeyring } from '../../../SnapKeyring/utils/forwardSelectedAccountGroupToSnapKeyring';
 import { MultichainAccountServiceInitMessenger } from '../../messengers/multichain-account-service-messenger/multichain-account-service-messenger';
 
 /**
@@ -63,20 +61,5 @@ export const multichainAccountServiceInit: MessengerClientInitFunction<
     },
   });
 
-  // TODO: Move this logic to the SnapKeyring directly.
-  initMessenger.subscribe(
-    'MultichainAccountService:multichainAccountGroupUpdated',
-    (group) => {
-      const { AccountTreeController } = Engine.context;
-
-      // If the current group gets updated, then maybe there are more accounts being "selected"
-      // now, so we have to forward them to the Snap keyring too!
-      if (AccountTreeController.getSelectedAccountGroup() === group.id) {
-        // eslint-disable-next-line no-void
-        void forwardSelectedAccountGroupToSnapKeyring(group.id);
-      }
-    },
-  );
-
   return { controller, memStateKey: null, persistedStateKey: null };
 };

app/core/SnapKeyring/utils/forwardSelectedAccountGroupToSnapKeyring.test.ts

@@ -11,11 +11,8 @@ const mockIsMoneyAccountEnabled = jest.requireMock(
 const mockUpdateAccounts = jest.fn();
 const mockAccountTreeInit = jest.fn();
 const mockAccountTreeClearState = jest.fn();
-const mockAccountTreeGetSelectedAccountGroup = jest.fn();
 const mockMoneyAccountInit = jest.fn();
 const mockMoneyAccountClearState = jest.fn();
-const mockForwardSelectedAccountGroupToSnapKeyring = jest.fn();
-
 jest.mock('../../core/Engine', () => ({
   __esModule: true,
   default: {
@@ -30,9 +27,6 @@ jest.mock('../../core/Engine', () => ({
         clearState: jest
           .fn()
           .mockImplementation(() => mockAccountTreeClearState()),
-        getSelectedAccountGroup: jest
-          .fn()
-          .mockImplementation(() => mockAccountTreeGetSelectedAccountGroup()),
       },
       MoneyAccountController: {
         init: jest.fn().mockImplementation(() => mockMoneyAccountInit()),
@@ -47,15 +41,6 @@ jest.mock('../../core/Engine', () => ({
   },
 }));
 
-jest.mock(
-  '../../core/SnapKeyring/utils/forwardSelectedAccountGroupToSnapKeyring',
-  () => ({
-    forwardSelectedAccountGroupToSnapKeyring: jest
-      .fn()
-      .mockImplementation(() => mockForwardSelectedAccountGroupToSnapKeyring()),
-  }),
-);
-
 describe('AccountTreeInitService', () => {
   let service: AccountTreeInitService;
 
@@ -91,25 +76,6 @@ describe('AccountTreeInitService', () => {
 
       expect(mockMoneyAccountInit).not.toHaveBeenCalled();
     });
-
-    it('forwards the selected account group to the Snap keyring', async () => {
-      await service.initializeAccountTree();
-      expect(mockForwardSelectedAccountGroupToSnapKeyring).toHaveBeenCalled();
-    });
-
-    it('forwards the result of getSelectedAccountGroup to the Snap keyring', async () => {
-      const mockGroup = { id: 'test-group' };
-      mockAccountTreeGetSelectedAccountGroup.mockReturnValue(mockGroup);
-
-      await service.initializeAccountTree();
-
-      const { forwardSelectedAccountGroupToSnapKeyring } = jest.requireMock(
-        '../../core/SnapKeyring/utils/forwardSelectedAccountGroupToSnapKeyring',
-      );
-      expect(forwardSelectedAccountGroupToSnapKeyring).toHaveBeenCalledWith(
-        mockGroup,
-      );
-    });
   });
 
   describe('clearState', () => {

app/core/SnapKeyring/utils/forwardSelectedAccountGroupToSnapKeyring.ts

@@ -1,5 +1,4 @@
 import Engine from '../../core/Engine';
-import { forwardSelectedAccountGroupToSnapKeyring } from '../../core/SnapKeyring/utils/forwardSelectedAccountGroupToSnapKeyring';
 import { isMoneyAccountEnabled } from '../../lib/Money/feature-flags';
 
 export class AccountTreeInitService {
@@ -21,11 +20,6 @@ export class AccountTreeInitService {
     if (isMoneyAccountEnabled(remoteFeatureFlags)) {
       await MoneyAccountController.init();
     }
-
-    // Forward initial selected accounts.
-    await forwardSelectedAccountGroupToSnapKeyring(
-      AccountTreeController.getSelectedAccountGroup(),
-    );
   };
 
   clearState = async (): Promise<void> => {

app/multichain-accounts/AccountTreeInitService/index.test.ts

@@ -4,10 +4,8 @@ import {
 } from '@metamask/account-tree-controller';
 import type { MessengerClientInitFunction } from '../../../core/Engine/types';
 import { trace } from '../../../util/trace';
-import { forwardSelectedAccountGroupToSnapKeyring } from '../../../core/SnapKeyring/utils/forwardSelectedAccountGroupToSnapKeyring';
 import { MetaMetricsEvents } from '../../../core/Analytics';
 import { AnalyticsEventBuilder } from '../../../util/analytics/AnalyticsEventBuilder';
-import { AccountGroupId } from '@metamask/account-api';
 import { AccountTreeControllerInitMessenger } from '../../messengers/account-tree-controller-messenger';
 
 /**
@@ -53,15 +51,5 @@ export const accountTreeControllerInit: MessengerClientInitFunction<
     },
   });
 
-  // Forward selected accounts every time the selected account group changes.
-  initMessenger.subscribe(
-    'AccountTreeController:selectedAccountGroupChange',
-    (groupId: AccountGroupId | '') => {
-      // TODO: Move this logic to the SnapKeyring directly.
-      // eslint-disable-next-line no-void
-      void forwardSelectedAccountGroupToSnapKeyring(groupId);
-    },
-  );
-
   return { controller };
 };

app/multichain-accounts/AccountTreeInitService/index.ts

@@ -1,7 +1,4 @@
-import {
-  AccountTreeControllerMessenger,
-  AccountTreeControllerSelectedAccountGroupChangeEvent,
-} from '@metamask/account-tree-controller';
+import { AccountTreeControllerMessenger } from '@metamask/account-tree-controller';
 import {
   RootExtendedMessenger,
   RootMessenger,
@@ -60,9 +57,6 @@ export function getAccountTreeControllerMessenger(
   return messenger;
 }
 
-export type AllowedInitializationEvents =
-  AccountTreeControllerSelectedAccountGroupChangeEvent;
-
 type AccountTreeControllerInitMessengerActions = AnalyticsControllerActions;
 
 export type AccountTreeControllerInitMessenger = ReturnType<
@@ -82,15 +76,14 @@ export function getAccountTreeControllerInitMessenger(
   const messenger = new Messenger<
     'AccountTreeControllerInit',
     AccountTreeControllerInitMessengerActions,
-    AllowedInitializationEvents,
+    never,
     RootMessenger
   >({
     namespace: 'AccountTreeControllerInit',
     parent: rootMessenger,
   });
   rootMessenger.delegate({
     actions: ['AnalyticsController:trackEvent'],
-    events: ['AccountTreeController:selectedAccountGroupChange'],
     messenger,
   });
   return messenger;