chore: upgrade assets controllers to v94.1.0 (MetaMask#24005)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

upgrade assets controllers to v94.1.0

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: bump assets controllers to v94.1.0

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Upgrade assets-controllers to v94.1.0 and align token
balance/detection controller initialization and messengers (add
isOnboarded, remove platform/useAccountsAPI, update delegated
actions/events).
> 
> - **Dependencies**
>   - Bump `@metamask/assets-controllers` to `^94.1.0`.
> - **Engine Controllers**
>   - `token-balances-controller-init`
>     - Add `isOnboarded` option using `selectCompletedOnboarding`.
>     - Update tests to expect `isOnboarded`.
>   - `token-detection-controller-init`
>     - Remove `platform` and `useAccountsAPI` options.
>     - Update tests to match new constructor args.
> - **Messengers**
>   - `token-balances-controller-messenger`
> - Actions: add `TokenDetectionController:addDetectedTokensViaPolling`,
`...:addDetectedTokensViaWs`, `...:detectTokens`,
`KeyringController:getState`.
> - Events: add `KeyringController:lock`, `KeyringController:unlock`,
`TransactionController:transactionConfirmed`,
`TransactionController:incomingTransactionsReceived`.
>   - `token-detection-controller-messenger`
> - Actions: add `AccountsController:getAccount`; remove
`AuthenticationController:getBearerToken`.
>     - Events: no net new events; ordering adjusted.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
8462734. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Author: salimtb

app/core/Engine/controllers/token-balances-controller-init.test.ts

@@ -74,6 +74,7 @@ describe('TokenBalancesControllerInit', () => {
       queryMultipleAccounts: expect.any(Boolean),
       accountsApiChainIds: expect.any(Function),
       platform: 'mobile',
+      isOnboarded: expect.any(Function),
     });
   });
 
@@ -92,6 +93,7 @@ describe('TokenBalancesControllerInit', () => {
       queryMultipleAccounts: expect.any(Boolean),
       accountsApiChainIds: expect.any(Function),
       platform: 'mobile',
+      isOnboarded: expect.any(Function),
     });
   });
 
@@ -111,6 +113,7 @@ describe('TokenBalancesControllerInit', () => {
       queryMultipleAccounts: expect.any(Boolean),
       accountsApiChainIds: expect.any(Function),
       platform: 'mobile',
+      isOnboarded: expect.any(Function),
     });
   });
 });

app/core/Engine/controllers/token-balances-controller-init.ts

@@ -6,6 +6,7 @@ import {
 import { TokenBalancesControllerInitMessenger } from '../messengers/token-balances-controller-messenger';
 import { selectAssetsAccountApiBalancesEnabled } from '../../../selectors/featureFlagController/assetsAccountApiBalances';
 import { selectBasicFunctionalityEnabled } from '../../../selectors/settings';
+import { selectCompletedOnboarding } from '../../../selectors/onboarding';
 
 /**
  * Initialize the token balances controller.
@@ -34,6 +35,7 @@ export const tokenBalancesControllerInit: ControllerInitFunction<
         engine: { backgroundState: persistedState as EngineState },
       }) as `0x${string}`[],
     platform: 'mobile',
+    isOnboarded: () => selectCompletedOnboarding(getState()),
   });
 
   return {

app/core/Engine/controllers/token-detection-controller-init.test.ts

@@ -46,8 +46,6 @@ describe('TokenDetectionControllerInit', () => {
     const controllerMock = jest.mocked(TokenDetectionController);
     expect(controllerMock).toHaveBeenCalledWith({
       messenger: expect.any(Object),
-      platform: 'mobile',
-      useAccountsAPI: true,
       disabled: false,
       getBalancesInSingleCall: expect.any(Function),
       useTokenDetection: expect.any(Function),

app/core/Engine/controllers/token-detection-controller-init.ts

@@ -27,8 +27,6 @@ export const tokenDetectionControllerInit: ControllerInitFunction<
 
   const controller = new TokenDetectionController({
     messenger: controllerMessenger,
-    platform: 'mobile',
-    useAccountsAPI: true,
     disabled: false,
     getBalancesInSingleCall: initMessenger.call.bind(
       initMessenger,

app/core/Engine/messengers/token-balances-controller-messenger.ts

@@ -28,26 +28,33 @@ export function getTokenBalancesControllerMessenger(
   });
   rootMessenger.delegate({
     actions: [
-      'NetworkController:getNetworkClientById',
       'NetworkController:getState',
-      'TokensController:getState',
+      'NetworkController:getNetworkClientById',
       'PreferencesController:getState',
+      'TokensController:getState',
+      'TokenDetectionController:addDetectedTokensViaPolling',
+      'TokenDetectionController:addDetectedTokensViaWs',
+      'TokenDetectionController:detectTokens',
       'AccountsController:getSelectedAccount',
       'AccountsController:listAccounts',
       'AccountTrackerController:getState',
       'AccountTrackerController:updateNativeBalances',
       'AccountTrackerController:updateStakedBalances',
-      'TokenDetectionController:addDetectedTokensViaWs',
+      'KeyringController:getState',
       'AuthenticationController:getBearerToken',
     ],
     events: [
-      'TokensController:stateChange',
-      'PreferencesController:stateChange',
       'NetworkController:stateChange',
+      'PreferencesController:stateChange',
+      'TokensController:stateChange',
       'KeyringController:accountRemoved',
+      'KeyringController:lock',
+      'KeyringController:unlock',
       'AccountActivityService:balanceUpdated',
       'AccountActivityService:statusChanged',
       'AccountsController:selectedEvmAccountChange',
+      'TransactionController:transactionConfirmed',
+      'TransactionController:incomingTransactionsReceived',
     ],
     messenger,
   });

app/core/Engine/messengers/token-detection-controller-messenger.ts

@@ -30,27 +30,26 @@ export function getTokenDetectionControllerMessenger(
   });
   rootMessenger.delegate({
     actions: [
+      'AccountsController:getAccount',
       'AccountsController:getSelectedAccount',
+      'KeyringController:getState',
       'NetworkController:getNetworkClientById',
       'NetworkController:getNetworkConfigurationByNetworkClientId',
       'NetworkController:getState',
-      'KeyringController:getState',
-      'PreferencesController:getState',
-      'TokenListController:getState',
       'TokensController:getState',
       'TokensController:addDetectedTokens',
-      'AccountsController:getAccount',
+      'TokenListController:getState',
+      'PreferencesController:getState',
       'TokensController:addTokens',
       'NetworkController:findNetworkClientIdByChainId',
-      'AuthenticationController:getBearerToken',
     ],
     events: [
+      'AccountsController:selectedEvmAccountChange',
       'KeyringController:lock',
       'KeyringController:unlock',
-      'PreferencesController:stateChange',
       'NetworkController:networkDidChange',
       'TokenListController:stateChange',
-      'AccountsController:selectedEvmAccountChange',
+      'PreferencesController:stateChange',
       'TransactionController:transactionConfirmed',
     ],
     messenger,

package.json

@@ -198,7 +198,7 @@
     "@metamask/address-book-controller": "^7.0.0",
     "@metamask/app-metadata-controller": "^2.0.0",
     "@metamask/approval-controller": "^8.0.0",
-    "@metamask/assets-controllers": "^94.0.0",
+    "@metamask/assets-controllers": "^94.1.0",
     "@metamask/base-controller": "^9.0.0",
     "@metamask/bitcoin-wallet-snap": "^1.8.0",
     "@metamask/bridge-controller": "^64.1.0",

yarn.lock

@@ -7186,9 +7186,9 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@metamask/assets-controllers@npm:^94.0.0":
-  version: 94.0.0
-  resolution: "@metamask/assets-controllers@npm:94.0.0"
+"@metamask/assets-controllers@npm:^94.1.0":
+  version: 94.1.0
+  resolution: "@metamask/assets-controllers@npm:94.1.0"
   dependencies:
     "@ethereumjs/util": "npm:^9.1.0"
     "@ethersproject/abi": "npm:^5.7.0"
@@ -7236,7 +7236,7 @@ __metadata:
   peerDependencies:
     "@metamask/providers": ^22.0.0
     webextension-polyfill: ^0.10.0 || ^0.11.0 || ^0.12.0
-  checksum: 10/86324e75db4adffbfc7c4f93138de25242360578e3aa0fd26f78ef84d4390fb04042cb1582d64139754de60f315a9b8a8458850c65b0b764b95eb6435f3bb054
+  checksum: 10/80f0fb88d55fd747540f141154a59eb9b49df8546d81881bb7f9683d92b462b73ede18fced3f9c4a551da3037b8f27886f1ec297d55e9a4eeb2f1c18b8ea65e7
   languageName: node
   linkType: hard
 
@@ -34207,7 +34207,7 @@ __metadata:
     "@metamask/address-book-controller": "npm:^7.0.0"
     "@metamask/app-metadata-controller": "npm:^2.0.0"
     "@metamask/approval-controller": "npm:^8.0.0"
-    "@metamask/assets-controllers": "npm:^94.0.0"
+    "@metamask/assets-controllers": "npm:^94.1.0"
     "@metamask/auto-changelog": "npm:^5.3.0"
     "@metamask/base-controller": "npm:^9.0.0"
     "@metamask/bitcoin-wallet-snap": "npm:^1.8.0"