Commit 68b310f
refactor: replace remove token ActionSheet with MMDS BottomSheet (MetaMask#24112)
## **Description**
The ActionSheet is buggy on Android (a new layout shift has caused
Android to freeze when the ActionSheet is trying to be visible).
Instead we have replaced it with a more reliable MMDS BottomSheet, which
allows us to control the buttons and other fields with our Design System
components.
## **Changelog**
<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`
If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`
(This helps the Release Engineer do their job more quickly and
accurately)
-->
CHANGELOG entry: refactor: replace remove token ActionSheet with MMDS
BottomSheet
## **Related issues**
Fixes: MetaMask#23605,
https://consensyssoftware.atlassian.net/browse/ASSETS-1961
## **Manual testing steps**
See issue:
1. Long press non-native tokens
2. See bottom sheet
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **Before**
<!-- [screenshots/recordings] -->
### **After**
https://www.loom.com/share/8163f10e116646e0b2097aae3a085f0f
## **Pre-merge author checklist**
- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> Replaces the token removal ActionSheet with a new MMDS BottomSheet,
updates related state/UX, adds targeted tests, and tweaks test IDs and
i18n copy.
>
> - **UI (Tokens)**:
> - **BottomSheet replacement**: Introduces
`TokenList/RemoveTokenBottomSheet` and refactors `Tokens` to use it
instead of `ActionSheet` (adds `removeTokenState`, `showRemoveMenu`, and
close handlers).
> - **Skeleton**: Adds `testID="token-list-skeleton"` in
`TokenListSkeleton`.
> - **Empty State**: `TokensEmptyState` now sets
`testID="tokens-empty-state"` and passes through props.
> - **Tests**:
> - Overhauls `app/components/UI/Tokens/index.test.tsx` to mock
subcomponents and cover: container render, loading skeleton, empty
state, token list, refresh action, add-token navigation, and EVM/non‑EVM
removal via BottomSheet.
> - Updates `TokensEmptyState.test.tsx` to assert new `testID`.
> - **i18n**:
> - Changes `wallet.remove_token_title` to "Hide token?".
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
d30881c. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
---------
Co-authored-by: Cursor Agent <cursoragent@cursor.com>1 parent e19ee34 commit 68b310f
7 files changed
Lines changed: 335 additions & 1022 deletions
File tree
- app/components/UI
- TokensEmptyState
- Tokens
- TokenList
- TokenListSkeleton
- locales/languages
Lines changed: 81 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
| 31 | + | |
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| |||
0 commit comments