Skip to content

Commit 7bf7d95

Browse files
fix: blocking button even when there's an active quote (MetaMask#23792)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR fixes an issue that caused Swap button to be blocked even though a quote was available. ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Fixed a bug that caused Swap button to be blocked even though a quote was available ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/SWAPS-3559 ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/4e38deb6-61d9-4b39-aaa0-ecf31906b5af ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Adjusts `isSubmitDisabled` so the confirm button remains enabled during loading when an `activeQuote` exists. > > - **Bridge UI (`app/components/UI/Bridge/Views/BridgeView/index.tsx`)**: > - Refines `isSubmitDisabled` to `(isLoading && !activeQuote)` instead of `isLoading`, allowing confirm when a quote is already available. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 5754e63. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent 244210d commit 7bf7d95

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

  • app/components/UI/Bridge/Views/BridgeView

app/components/UI/Bridge/Views/BridgeView/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ const BridgeView = () => {
228228
]);
229229

230230
const isSubmitDisabled =
231-
isLoading ||
231+
(isLoading && !activeQuote) ||
232232
hasInsufficientBalance ||
233233
isSubmittingTx ||
234234
(isHardwareAddress && isSolanaSourced) ||

0 commit comments

Comments
 (0)