Skip to content

Commit 7da38e7

Browse files
authored
fix: Fix padding issue of transactions view (MetaMask#17804)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR fixing minor design defect on transactions view. ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: ## **Related issues** Fixes: MetaMask/MetaMask-planning#5433 ## **Manual testing steps** N/A ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <img width="897" height="2160" alt="Screenshot 2025-08-01 at 09 06 37" src="https://github.com/user-attachments/assets/05acbc53-7ef9-4976-ba63-4e93c27bf8d4" /> ### **After** <img width="897" height="2160" alt="Screenshot 2025-08-01 at 09 06 22" src="https://github.com/user-attachments/assets/d7ca0dd4-a1ca-4d73-ab0f-4fdf13cce420" /> ## **Pre-merge author checklist** - [X] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
1 parent e4d305d commit 7da38e7

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

  • app/components/UI/TransactionElement

app/components/UI/TransactionElement/index.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ const createStyles = (colors, typography) =>
100100
paddingTop: 10,
101101
},
102102
listItemDate: {
103-
marginBottom: 0,
103+
marginBottom: 10,
104104
paddingBottom: 0,
105105
},
106106
listItemContent: {
@@ -287,8 +287,7 @@ class TransactionElement extends PureComponent {
287287
'transactions.from_device_label',
288288
// eslint-disable-next-line no-mixed-spaces-and-tabs
289289
)}`
290-
: `${toDateFormat(tx.time)}
291-
`
290+
: `${toDateFormat(tx.time)}`
292291
}`;
293292
};
294293

0 commit comments

Comments
 (0)