Commit 8a7bced
authored
fix: hides perps buttons in ai insights when user has a position cp-7.71.0 (MetaMask#27919)
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->
## **Description**
This PR is a bug fix for
MetaMask#27916 where:
- In the AI Market Insights in Perps, the action buttons are wrong when
user has an open position: the action buttons should be the same in AI
market insight page and market page, ie. “modify” and “Close” when user
has an open position
Fix:
- When the user has an existing perps position, the MarketInsights
footer action buttons (Long/Short) are hidden since the relevant actions
(modify/close) live on the Perps market details page
- The "AI summary for information only" disclaimer is moved inline below
the feedback section when the footer is hidden, so it remains visible
- Position state is passed via route params (hasPerpsPosition) from the
caller rather than fetched async inside MarketInsightsView, preventing a
flash where buttons briefly appear then disappear while the position
loads
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
## **Changelog**
<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`
If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`
(This helps the Release Engineer do their job more quickly and
accurately)
-->
CHANGELOG entry: Fixed a bug that was causing incorrect Perps action
buttons to be displayed
## **Related issues**
Fixes: MetaMask#27916
## **Manual testing steps**
```gherkin
- Open MarketInsights from token details → Swap/Buy buttons visible with disclaimer in footer
- Open MarketInsights from perps with no position → Long/Short buttons visible with disclaimer in footer
- Open MarketInsights from perps with an existing position → no footer buttons, disclaimer shown below "Was this helpful?"
- Verify no flash/layout shift on the perps + position flow
```
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **Before**
<!-- [screenshots/recordings] -->
https://github.com/user-attachments/assets/0373c1bb-d433-4c9a-8768-117a40d98f9e
### **After**
<!-- [screenshots/recordings] -->
<img width="3699" height="3090" alt="SCR-20260325-nzfa"
src="https://github.com/user-attachments/assets/4b058c59-6df0-4d16-acf7-8d6bb839183f"
/>
## **Pre-merge author checklist**
- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Low Risk**
> Low risk UI/navigation tweak that changes which CTAs are shown based
on a new route param; main risk is incorrect param wiring causing
missing actions or disclaimer placement in the Perps insights flow.
>
> **Overview**
> Fixes Perps AI Market Insights showing inappropriate `Long`/`Short`
CTAs when the user already has an open position.
>
> Adds a `hasPerpsPosition` route param (set by
`PerpsMarketDetailsView`) and uses it in `MarketInsightsView` to **hide
the footer action buttons** for Perps-with-position while **keeping the
informational disclaimer visible** by moving it inline under the
feedback section for that case.
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
833593b. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->1 parent ad3b7a5 commit 8a7bced
2 files changed
Lines changed: 62 additions & 44 deletions
File tree
- app/components/UI
- MarketInsights/Views/MarketInsightsView
- Perps/Views/PerpsMarketDetailsView
Lines changed: 60 additions & 43 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
153 | 153 | | |
154 | 154 | | |
155 | 155 | | |
| 156 | + | |
| 157 | + | |
156 | 158 | | |
157 | 159 | | |
158 | 160 | | |
| |||
182 | 184 | | |
183 | 185 | | |
184 | 186 | | |
| 187 | + | |
185 | 188 | | |
186 | 189 | | |
187 | 190 | | |
| |||
660 | 663 | | |
661 | 664 | | |
662 | 665 | | |
| 666 | + | |
| 667 | + | |
| 668 | + | |
| 669 | + | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
| 674 | + | |
663 | 675 | | |
664 | 676 | | |
665 | 677 | | |
666 | | - | |
667 | | - | |
668 | | - | |
669 | | - | |
670 | | - | |
671 | | - | |
672 | | - | |
673 | | - | |
674 | | - | |
675 | | - | |
676 | | - | |
677 | | - | |
678 | | - | |
679 | | - | |
680 | | - | |
681 | | - | |
682 | | - | |
683 | | - | |
684 | | - | |
685 | | - | |
686 | | - | |
687 | | - | |
688 | | - | |
689 | | - | |
690 | | - | |
691 | | - | |
692 | | - | |
| 678 | + | |
| 679 | + | |
| 680 | + | |
| 681 | + | |
| 682 | + | |
| 683 | + | |
693 | 684 | | |
694 | 685 | | |
695 | 686 | | |
696 | | - | |
697 | | - | |
698 | | - | |
| 687 | + | |
| 688 | + | |
| 689 | + | |
699 | 690 | | |
700 | | - | |
| 691 | + | |
701 | 692 | | |
702 | | - | |
703 | | - | |
704 | 693 | | |
705 | 694 | | |
706 | 695 | | |
707 | | - | |
708 | | - | |
709 | | - | |
| 696 | + | |
| 697 | + | |
| 698 | + | |
710 | 699 | | |
711 | | - | |
| 700 | + | |
712 | 701 | | |
713 | 702 | | |
| 703 | + | |
| 704 | + | |
| 705 | + | |
| 706 | + | |
| 707 | + | |
| 708 | + | |
| 709 | + | |
| 710 | + | |
| 711 | + | |
| 712 | + | |
| 713 | + | |
| 714 | + | |
| 715 | + | |
| 716 | + | |
| 717 | + | |
| 718 | + | |
| 719 | + | |
| 720 | + | |
| 721 | + | |
| 722 | + | |
| 723 | + | |
| 724 | + | |
| 725 | + | |
| 726 | + | |
| 727 | + | |
| 728 | + | |
| 729 | + | |
| 730 | + | |
| 731 | + | |
| 732 | + | |
| 733 | + | |
| 734 | + | |
| 735 | + | |
714 | 736 | | |
715 | | - | |
716 | | - | |
717 | | - | |
718 | | - | |
719 | | - | |
720 | 737 | | |
721 | | - | |
| 738 | + | |
722 | 739 | | |
723 | 740 | | |
724 | 741 | | |
| |||
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1041 | 1041 | | |
1042 | 1042 | | |
1043 | 1043 | | |
| 1044 | + | |
1044 | 1045 | | |
1045 | | - | |
| 1046 | + | |
1046 | 1047 | | |
1047 | 1048 | | |
1048 | 1049 | | |
| |||
0 commit comments