Commit 8b4cc93
authored
refactor(earn): migrate Earn routes to native stack and HeaderStandard (MetaMask#30478)
## **Description**
Migrates Earn navigation stacks from @react-navigation/stack to
@react-navigation/native-stack, and replaces imperative getStakingNavbar
headers on stablecoin lending deposit/withdrawal confirmation screens
with declarative HeaderStandard from the design system.
**Why**
- Align Earn with other recently converted stacks (native stack for
performance and consistency).
- Remove legacy navigation.setOptions(getStakingNavbar(...)) in favor of
in-view HeaderStandard, matching patterns from refactor/unstake (MetaMask#30281)
and refactor/headerstandard-titles-bridge (accessibility-label–based
header interactions in tests).
**What changed**
_app/components/UI/Earn/routes/index.tsx_
- createStackNavigator → createNativeStackNavigator for EarnScreenStack
and EarnModalStack.
- EarnScreenStack uses transparentModalScreenOptions.
- EarnModalStack uses clearNativeStackNavigatorOptions +
transparentModalScreenOptions.
- headerShown: false on lending deposit and withdrawal confirmation
screens (headers owned by the view).
_EarnLendingDepositConfirmationView_
- Renders <HeaderStandard> with dynamic title (Supply <token>).
- Back via onBack + backButtonProps.accessibilityLabel:
strings('navigation.back').
- Removed dead getStakingNavbar(...) call and navbar useEffect.
_EarnLendingWithdrawalConfirmationView_
- Same HeaderStandard pattern with title (Withdraw <token>).
- Back press preserves EARN_LENDING_WITHDRAW_CONFIRMATION_BACK_CLICKED
analytics (moved from getStakingNavbar backButtonEvent into
handleHeaderBackPress).
_Tests_
- Added HeaderStandard coverage (title rendering, back navigation,
withdrawal back analytics).
- Back button queried via getByLabelText(strings('navigation.back'))
(bridge header pattern), not button-icon testID.
- Removed getStakingNavbar spy/import from withdrawal tests.
## **Changelog**
<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`
If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`
(This helps the Release Engineer do their job more quickly and
accurately)
-->
CHANGELOG entry: null
## **Related issues**
Fixes:
## **Manual testing steps**
```gherkin
Feature: my feature name
Scenario: user [verb for user action]
Given [describe expected initial app state]
When user [verb for user action]
Then [describe expected outcome]
```
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **Before**
<!-- [screenshots/recordings] -->
### **After**
<img width="334" height="696" alt="Earn - Deposit"
src="https://github.com/user-attachments/assets/b9a6838f-3952-4bdf-a30a-720f2dc1921b"
/>
<img width="346" height="738" alt="Earn - Withdraw"
src="https://github.com/user-attachments/assets/6d61116e-a342-414a-86eb-94fed9a1f266"
/>
<img width="334" height="696" alt="earn - confirmation"
src="https://github.com/user-attachments/assets/7074bc4a-f815-4f0a-b652-6a1b6f3afe8f"
/>
<img width="334" height="696" alt="Earn - conversion education"
src="https://github.com/user-attachments/assets/1e687c54-8b3a-4e93-841c-6d7923d09faf"
/>
<img width="334" height="696" alt="earn - learn more modal"
src="https://github.com/user-attachments/assets/ca5195fe-108f-4fcf-8f93-7d3bc54aa328"
/>
<img width="334" height="696" alt="earn - confirm modal"
src="https://github.com/user-attachments/assets/41c191ae-6b4a-409f-b838-5297bcaf2ec3"
/>
Android _EarnLendingDepositConfirmationView_ and
_EarnLendingWithdrawalConfirmationView_ screens after nav header changes
|EarnLendingDepositConfirmationView|EarnLendingWithdrawalConfirmationView|
| --- | --- |
|<img width="1080" height="2316"
alt="Screenshot_20260521_071052_MetaMask"
src="https://github.com/user-attachments/assets/635fa65b-28a1-4d34-ab8e-8ab0781afaa6"
/>|<img width="1080" height="2316"
alt="Screenshot_20260521_070956_MetaMask"
src="https://github.com/user-attachments/assets/408d6e88-980a-4e98-ae6e-098bdb82b3ae"
/>|
## **Pre-merge author checklist**
<!--
Every checklist item must be consciously assessed before marking this PR
as
"Ready for review". A checked box means you deliberately considered that
responsibility, not that you literally performed every action listed.
Unchecked boxes are ambiguous: they are not an implicit "N/A" and they
are not
a silent "skip". See `docs/readme/ready-for-review.md` for the full
checklist
semantics.
-->
- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
#### Performance checks (if applicable)
- [x] I've tested on Android
- Ideally on a mid-range device; emulator is acceptable
- [ ] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [ ] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example
For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).
## **Pre-merge reviewer checklist**
<!--
Reviewer checklist items follow the same semantics as the author
checklist: an
unchecked box is ambiguous, a checked box means the reviewer consciously
assessed that responsibility. See `docs/readme/ready-for-review.md`.
-->
- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Medium Risk**
> Touches user-facing Earn confirmation navigation and header/back
behavior; withdrawal back analytics are explicitly preserved, but stack
presentation changes warrant manual regression on deposit/withdraw
flows.
>
> **Overview**
> Earn navigation moves from the legacy JS stack to **native stack**,
with shared `transparentModalScreenOptions` /
`clearNativeStackNavigatorOptions` and **`headerShown: false`** on
stablecoin lending deposit and withdrawal confirmation routes so headers
live in the screen.
>
> **Deposit and withdrawal confirmation** drop `getStakingNavbar` /
`navigation.setOptions` and render in-view **`HeaderStandard`** with
titles built from the routed token (ticker → symbol → name). Back uses
`onBack` and the `navigation.back` accessibility label; tests query the
back control via that label.
>
> On **withdrawal**, `EARN_LENDING_WITHDRAW_CONFIRMATION_BACK_CLICKED`
analytics move from the old navbar `backButtonEvent` into
**`handleHeaderBackPress`** before `goBack()`. Deposit back only
navigates back (no new back analytics in this change).
>
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
c8a60d9. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->1 parent 761019c commit 8b4cc93
5 files changed
Lines changed: 164 additions & 95 deletions
File tree
- app/components/UI/Earn
- Views
- EarnLendingDepositConfirmationView
- EarnLendingWithdrawalConfirmationView
- routes
Lines changed: 50 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
20 | 19 | | |
21 | 20 | | |
22 | 21 | | |
| |||
235 | 234 | | |
236 | 235 | | |
237 | 236 | | |
238 | | - | |
239 | | - | |
240 | 237 | | |
241 | 238 | | |
242 | 239 | | |
| |||
345 | 342 | | |
346 | 343 | | |
347 | 344 | | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
348 | 395 | | |
349 | 396 | | |
350 | 397 | | |
| |||
Lines changed: 19 additions & 14 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| |||
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
76 | | - | |
| 76 | + | |
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
| |||
91 | 91 | | |
92 | 92 | | |
93 | 93 | | |
94 | | - | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
95 | 102 | | |
96 | 103 | | |
97 | 104 | | |
| |||
221 | 228 | | |
222 | 229 | | |
223 | 230 | | |
224 | | - | |
225 | | - | |
226 | | - | |
227 | | - | |
228 | | - | |
229 | | - | |
230 | | - | |
231 | | - | |
232 | | - | |
233 | | - | |
234 | 231 | | |
235 | | - | |
| 232 | + | |
236 | 233 | | |
237 | 234 | | |
238 | 235 | | |
| |||
793 | 790 | | |
794 | 791 | | |
795 | 792 | | |
| 793 | + | |
| 794 | + | |
| 795 | + | |
| 796 | + | |
| 797 | + | |
| 798 | + | |
| 799 | + | |
| 800 | + | |
796 | 801 | | |
797 | 802 | | |
798 | 803 | | |
| |||
Lines changed: 47 additions & 32 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
3 | 2 | | |
4 | 3 | | |
5 | 4 | | |
| |||
24 | 23 | | |
25 | 24 | | |
26 | 25 | | |
27 | | - | |
28 | | - | |
29 | 26 | | |
30 | 27 | | |
31 | 28 | | |
| |||
36 | 33 | | |
37 | 34 | | |
38 | 35 | | |
39 | | - | |
40 | | - | |
41 | 36 | | |
42 | 37 | | |
43 | 38 | | |
| |||
213 | 208 | | |
214 | 209 | | |
215 | 210 | | |
216 | | - | |
| 211 | + | |
217 | 212 | | |
218 | 213 | | |
219 | 214 | | |
220 | 215 | | |
221 | 216 | | |
222 | 217 | | |
223 | 218 | | |
224 | | - | |
225 | | - | |
226 | | - | |
227 | | - | |
228 | | - | |
229 | | - | |
230 | | - | |
231 | | - | |
232 | | - | |
233 | | - | |
234 | | - | |
235 | | - | |
236 | | - | |
237 | | - | |
238 | | - | |
239 | | - | |
240 | | - | |
241 | | - | |
242 | | - | |
243 | | - | |
244 | | - | |
245 | | - | |
246 | | - | |
247 | | - | |
248 | | - | |
249 | | - | |
250 | 219 | | |
251 | 220 | | |
252 | 221 | | |
253 | 222 | | |
254 | 223 | | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
255 | 270 | | |
256 | 271 | | |
257 | 272 | | |
| |||
Lines changed: 36 additions & 39 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
| |||
34 | 35 | | |
35 | 36 | | |
36 | 37 | | |
37 | | - | |
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
| |||
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
75 | | - | |
| 75 | + | |
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
| |||
88 | 88 | | |
89 | 89 | | |
90 | 90 | | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
91 | 96 | | |
92 | 97 | | |
93 | 98 | | |
| |||
106 | 111 | | |
107 | 112 | | |
108 | 113 | | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
140 | 131 | | |
| 132 | + | |
141 | 133 | | |
142 | 134 | | |
| 135 | + | |
143 | 136 | | |
144 | 137 | | |
145 | | - | |
146 | 138 | | |
147 | | - | |
148 | 139 | | |
149 | | - | |
150 | 140 | | |
151 | | - | |
152 | | - | |
| 141 | + | |
153 | 142 | | |
154 | 143 | | |
155 | 144 | | |
| |||
469 | 458 | | |
470 | 459 | | |
471 | 460 | | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
472 | 469 | | |
473 | 470 | | |
474 | 471 | | |
| |||
0 commit comments