Skip to content

Commit 8f29d2f

Browse files
feat(base branch): make it possible to define name of release PR base branch (MetaMask#18495)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Release PR base branch is currently hardcoded to `main` which is not convenient, as it should be set to `stable` for Mobile. This PR makes it possible to manually define the name of release PR base branch. It leverages changes introduced on github-tools repo in this [PR](MetaMask/github-tools#99). We've already introduced and tested the same change on metamask-extension repo (see MetaMask/metamask-extension#35194 and MetaMask/metamask-extension#35197). ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: non user-facing ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
1 parent 939690e commit 8f29d2f

1 file changed

Lines changed: 9 additions & 5 deletions

File tree

.github/workflows/create-release-pr.yml

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,11 @@ name: Create Release Pull Request
33
on:
44
workflow_dispatch:
55
inputs:
6-
base-branch:
7-
description: 'The base branch, tag, or SHA for git operations and the pull request.'
6+
checkout-base-branch:
7+
description: 'The base branch, tag, or SHA for git operations. Usually `main`'
8+
required: true
9+
release-pr-base-branch:
10+
description: 'The base branch, tag, or SHA for the release pull request. Usually `stable`'
811
required: true
912
semver-version:
1013
description: 'A semantic version. eg: x.x.x'
@@ -20,14 +23,15 @@ jobs:
2023

2124
create-release-pr:
2225
needs: generate-build-version
23-
uses: MetaMask/github-tools/.github/workflows/create-release-pr.yml@dde6d530bebae07d1e50180894ab2cac64170a2c
26+
uses: MetaMask/github-tools/.github/workflows/create-release-pr.yml@75cfa5085bee4804dadaa2516a47c4ff37278b35
2427
with:
2528
platform: mobile
26-
base-branch: ${{ inputs.base-branch }}
29+
checkout-base-branch: ${{ inputs.checkout-base-branch }}
30+
release-pr-base-branch: ${{ inputs.release-pr-base-branch }}
2731
semver-version: ${{ inputs.semver-version }}
2832
previous-version-tag: ${{ inputs.previous-version-ref }}
2933
mobile-build-version: ${{ needs.generate-build-version.outputs.build-version }}
30-
github-tools-version: dde6d530bebae07d1e50180894ab2cac64170a2c
34+
github-tools-version: 75cfa5085bee4804dadaa2516a47c4ff37278b35
3135

3236
secrets:
3337
# This token needs read permissions to metamask-planning & write permissions to metamask-mobile

0 commit comments

Comments
 (0)