fix: Fix MM Connect resuming of sessions before NetworkController state is available for BackgroundBridge (MetaMask#22749)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Fixes an issue where MM Connect deeplinks do not result in an approval
being shown to the user from app cold start AND (?) if the app is an
expo build that gets delayed by bundling.

~~1. For some reason we do not restore connections the first ReactNative
AppState "active" event, which is the only one we receive. Guard has
been removed~~ Tamas has clarified why this is the case. I have reverted
this change
2. Our check to ensure the store is fully initialized is not complete
enough and was resulting in BackgroundBridge throwing when trying to
access state from the NetworkController that was not ready.

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
3. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null


No changelog as MetaMask Connect has not been released to public yet

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.




<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Adds store readiness check (including NetworkController state) to RPC
bridge init and increases readiness polling intervals; updates tests
accordingly.
> 
> - **SDKConnectV2 readiness**:
> - `when-store-ready`: New util ensuring `store.dispatch` and
`engine.backgroundState.NetworkController` exist before proceeding.
> - `when-engine-ready`/`when-store-ready`: Increase polling interval
from 10ms to 100ms.
> - **RPC bridge initialization**:
> - `RPCBridgeAdapter` tests updated to wait for `whenEngineReady`,
`whenOnboardingComplete`, and new `whenStoreReady` before creating
`BackgroundBridge` and subscribing to unlock events; ensure idempotent
init and queuing behavior.
> - **Tests**:
> - Update timer advances to match slower polling (milliseconds →
seconds) in `when-engine-ready.test.ts` and `when-store-ready.test.ts`.
> - `connection-registry.test.ts`: Mock store state to include
`NetworkController` for initialization-dependent flows.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
570282b. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: aphex <52055541+wenfix@users.noreply.github.com>

Author: jiexi

app/core/SDKConnectV2/adapters/rpc-bridge-adapter.test.ts

@@ -5,6 +5,7 @@ import { ConnectionInfo } from '../types/connection-info';
 import { RPCBridgeAdapter } from './rpc-bridge-adapter';
 import { whenEngineReady } from '../utils/when-engine-ready';
 import { whenOnboardingComplete } from '../utils/when-onboarding-complete';
+import { whenStoreReady } from '../utils/when-store-ready';
 
 jest.mock('../../BackgroundBridge/BackgroundBridge');
 jest.mock('../utils/when-engine-ready', () => ({
@@ -13,6 +14,9 @@ jest.mock('../utils/when-engine-ready', () => ({
 jest.mock('../utils/when-onboarding-complete', () => ({
   whenOnboardingComplete: jest.fn(),
 }));
+jest.mock('../utils/when-store-ready', () => ({
+  whenStoreReady: jest.fn(),
+}));
 jest.mock('../../Engine', () => ({
   controllerMessenger: {
     subscribe: jest.fn(),
@@ -28,6 +32,7 @@ jest.mock('../../Engine', () => ({
 const MockedBackgroundBridge = BackgroundBridge as any;
 const mockedWhenEngineReady = whenEngineReady as jest.Mock;
 const mockedWhenOnboardingComplete = whenOnboardingComplete as jest.Mock;
+const mockedWhenStoreReady = whenStoreReady as jest.Mock;
 const mockedEngine = Engine as any;
 
 describe('RPCBridgeAdapter', () => {
@@ -62,6 +67,7 @@ describe('RPCBridgeAdapter', () => {
     mockedEngine.controllerMessenger = mockMessenger;
     mockedWhenEngineReady.mockResolvedValue(undefined);
     mockedWhenOnboardingComplete.mockResolvedValue(undefined);
+    mockedWhenStoreReady.mockResolvedValue(undefined);
 
     // Capture the instance and sendMessage callback from the mock constructor
     MockedBackgroundBridge.mockImplementation((args: any) => {
@@ -89,6 +95,8 @@ describe('RPCBridgeAdapter', () => {
       await new Promise(process.nextTick);
 
       expect(mockedWhenEngineReady).toHaveBeenCalledTimes(1);
+      expect(mockedWhenOnboardingComplete).toHaveBeenCalledTimes(1);
+      expect(mockedWhenStoreReady).toHaveBeenCalledTimes(1);
       expect(mockMessenger.subscribe).toHaveBeenCalledWith(
         'KeyringController:unlock',
         expect.any(Function),
@@ -112,6 +120,8 @@ describe('RPCBridgeAdapter', () => {
       await new Promise(process.nextTick);
 
       expect(mockedWhenEngineReady).toHaveBeenCalledTimes(1);
+      expect(mockedWhenOnboardingComplete).toHaveBeenCalledTimes(1);
+      expect(mockedWhenStoreReady).toHaveBeenCalledTimes(1);
       expect(mockMessenger.subscribe).toHaveBeenCalledTimes(1);
       expect(MockedBackgroundBridge).toHaveBeenCalledTimes(1);
     });

app/core/SDKConnectV2/services/connection-registry.test.ts

@@ -17,6 +17,9 @@ jest.mock('../../Permissions');
 jest.mock('../../../store', () => ({
   store: {
     dispatch: jest.fn(),
+    getState: jest.fn().mockImplementation(() => ({
+      engine: { backgroundState: { NetworkController: {} } },
+    })),
   },
 }));
 

app/core/SDKConnectV2/utils/when-engine-ready.test.ts

@@ -43,7 +43,7 @@ describe('when-engine-ready', () => {
       const promise = whenEngineReady();
 
       // Fast-forward time to trigger the check intervals
-      await jest.advanceTimersByTimeAsync(200);
+      await jest.advanceTimersByTimeAsync(2000);
 
       await expect(promise).resolves.toBeUndefined();
     });
@@ -65,7 +65,7 @@ describe('when-engine-ready', () => {
       const promise = whenEngineReady();
 
       // Fast-forward time to trigger the check intervals
-      await jest.advanceTimersByTimeAsync(300);
+      await jest.advanceTimersByTimeAsync(3000);
 
       await expect(promise).resolves.toBeUndefined();
     });

app/core/SDKConnectV2/utils/when-engine-ready.ts

@@ -13,6 +13,6 @@ const isEngineReady = (): boolean => {
 
 export async function whenEngineReady() {
   while (!isEngineReady()) {
-    await new Promise((resolve) => setTimeout(resolve, 10));
+    await new Promise((resolve) => setTimeout(resolve, 100));
   }
 }

app/core/SDKConnectV2/utils/when-store-ready.test.ts

@@ -21,7 +21,9 @@ describe('when-store-ready', () => {
     it('should resolve immediately if the store is already ready', async () => {
       const mockStore = {
         dispatch: jest.fn(),
-        getState: jest.fn(),
+        getState: jest.fn().mockImplementation(() => ({
+          engine: { backgroundState: { NetworkController: true } },
+        })),
       };
 
       // eslint-disable-next-line @typescript-eslint/no-require-imports
@@ -41,7 +43,9 @@ describe('when-store-ready', () => {
       let callCount = 0;
       const mockStore = {
         dispatch: jest.fn(),
-        getState: jest.fn(),
+        getState: jest.fn().mockImplementation(() => ({
+          engine: { backgroundState: { NetworkController: true } },
+        })),
       };
 
       // eslint-disable-next-line @typescript-eslint/no-require-imports
@@ -60,7 +64,7 @@ describe('when-store-ready', () => {
       const promise = whenStoreReady();
 
       // Fast-forward time to trigger the check intervals
-      await jest.advanceTimersByTimeAsync(200);
+      await jest.advanceTimersByTimeAsync(2000);
 
       await expect(promise).resolves.toBeUndefined();
     });
@@ -70,7 +74,9 @@ describe('when-store-ready', () => {
       let callCount = 0;
       const mockStore = {
         dispatch: jest.fn(),
-        getState: jest.fn(),
+        getState: jest.fn().mockImplementation(() => ({
+          engine: { backgroundState: { NetworkController: true } },
+        })),
       };
 
       // eslint-disable-next-line @typescript-eslint/no-require-imports
@@ -89,7 +95,42 @@ describe('when-store-ready', () => {
       const promise = whenStoreReady();
 
       // Fast-forward time to trigger the check intervals
-      await jest.advanceTimersByTimeAsync(200);
+      await jest.advanceTimersByTimeAsync(2000);
+
+      await expect(promise).resolves.toBeUndefined();
+    });
+
+    it('should wait if NetworkController is not available in store state', async () => {
+      let callCount = 0;
+      const mockReadyStore = {
+        dispatch: jest.fn(),
+        getState: jest.fn().mockImplementation(() => ({
+          engine: { backgroundState: { NetworkController: true } },
+        })),
+      };
+
+      // eslint-disable-next-line @typescript-eslint/no-require-imports
+      const storeModule = require('../../../store');
+      Object.defineProperty(storeModule, 'store', {
+        get: () => {
+          callCount++;
+          if (callCount < 3) {
+            return {
+              dispatch: jest.fn(),
+              getState: jest.fn().mockImplementation(() => ({
+                engine: { backgroundState: {} }, // NetworkController not set
+              })),
+            };
+          }
+          return mockReadyStore;
+        },
+        configurable: true,
+      });
+
+      const promise = whenStoreReady();
+
+      // Fast-forward time to trigger the check intervals
+      await jest.advanceTimersByTimeAsync(2000);
 
       await expect(promise).resolves.toBeUndefined();
     });

app/core/SDKConnectV2/utils/when-store-ready.ts

@@ -2,10 +2,14 @@ import { store } from '../../../store';
 
 const isStoreReady = () => {
   try {
-    if (store && typeof store.dispatch === 'function') {
-      return true;
-    }
-    return false;
+    return Boolean(
+      store &&
+        typeof store.dispatch === 'function' &&
+        // This check is needed because the BackgroundBridge requires the NetworkController state
+        // for initialization. This check is brittle as reliance on other controller state during
+        // resumption would not be accounted for. We should figure out something more robust.
+        store.getState().engine.backgroundState.NetworkController,
+    );
   } catch {
     return false;
   }
@@ -20,6 +24,6 @@ const isStoreReady = () => {
  */
 export const whenStoreReady = async (): Promise<void> => {
   while (!isStoreReady()) {
-    await new Promise((resolve) => setTimeout(resolve, 10));
+    await new Promise((resolve) => setTimeout(resolve, 100));
   }
 };