Skip to content

Commit 9e90ec5

Browse files
fix: rename "Monthly Top Traders" to "Weekly Top Traders" (MetaMask#31620)
## **Description** Updates `locales/languages/en.json` to replace "Monthly Top Traders" with "Weekly Top Traders" in two places: - `social_leaderboard.top_traders_view.title` — full-screen leaderboard title - `top_traders` — home widget label The UI labels said "Monthly" but the leaderboard reflects a weekly timeframe, causing a mismatch between the copy and the actual data shown. ## **Changelog** CHANGELOG entry: null ## **Related issues** Fixes: N/A — copy-only fix identified via visual inspection of the app ## **Manual testing steps** ```gherkin Feature: Weekly Top Traders label Scenario: user views the Top Traders section Given the app is open on the home screen When user scrolls to the Top Traders widget Then the widget title reads "Weekly Top Traders" When user taps the widget to open the full leaderboard Then the screen title reads "Weekly Top Traders" ``` ## **Screenshots/Recordings** ### **Before** Monthly Top Traders (as seen in UI) ### **After** Weekly Top Traders ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [ ] I've tested on Android - [ ] I've tested with a power user scenario - [ ] I've instrumented key operations with Sentry traces for production performance metrics ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Copy-only change in English locale plus test expectation updates; no logic, API, or navigation changes. > > **Overview** > Renames the Top Traders copy to **Weekly Top Traders** so the home widget and full leaderboard title match the weekly timeframe of the data. > > `locales/languages/en.json` updates `social_leaderboard.top_traders_view.title` and `homepage.sections.top_traders`. Component code is unchanged; tests in `TopTradersSection.test.tsx` and `TopTradersView.test.tsx` now assert the new label when tapping the section header and on the leaderboard screen. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit b953ca2. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 67d1ab5 commit 9e90ec5

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

app/components/Views/Homepage/Sections/TopTraders/TopTradersSection.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ describe('TopTradersSection', () => {
139139
it('navigates to the Top Traders view when the section header is pressed', () => {
140140
renderWithProvider(<TopTradersSection {...defaultProps} />);
141141

142-
fireEvent.press(screen.getByText('Top Traders'));
142+
fireEvent.press(screen.getByText('Weekly Top Traders'));
143143

144144
expect(mockNavigate).toHaveBeenCalledWith(Routes.SOCIAL_LEADERBOARD.VIEW, {
145145
source: 'home_carousel',

app/components/Views/SocialLeaderboard/TopTradersView/TopTradersView.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ describe('TopTradersView', () => {
174174

175175
it('renders the Top Traders title', () => {
176176
renderWithProvider(<TopTradersView />);
177-
expect(screen.getByText('Top Traders')).toBeOnTheScreen();
177+
expect(screen.getByText('Weekly Top Traders')).toBeOnTheScreen();
178178
});
179179

180180
it('calls goBack when the back button is pressed', () => {

locales/languages/en.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1041,7 +1041,7 @@
10411041
},
10421042
"social_leaderboard": {
10431043
"top_traders_view": {
1044-
"title": "Top Traders",
1044+
"title": "Weekly Top Traders",
10451045
"chain_filter": {
10461046
"all": "All"
10471047
}
@@ -9703,7 +9703,7 @@
97039703
"related_assets": "Related Assets",
97049704
"perpetuals": "Perpetuals",
97059705
"predictions": "Predictions",
9706-
"top_traders": "Top Traders",
9706+
"top_traders": "Weekly Top Traders",
97079707
"defi": "DeFi",
97089708
"nfts": "NFTs",
97099709
"trending_tokens": "Trending",

0 commit comments

Comments
 (0)