Skip to content

Commit a092b62

Browse files
authored
chore: add commas to PnL (MetaMask#27815)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Add commas to PnL <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: add commas to PnL ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-2966 ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <img width="441" height="883" alt="image" src="https://github.com/user-attachments/assets/88f816c2-e54e-4977-8733-10d1e6cb201a" /> <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I've included tests if applicable - [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk UI-only change to how the price difference (PnL) value is formatted and signed in `AssetOverview`. > > **Overview** > Improves the `AssetOverview` price-diff (PnL) label formatting by switching from `addCurrencySymbol(diff, ...)` to `formatPriceWithSubscriptNotation(Math.abs(diff), ...)`, which adds thousands separators and consistent small-value formatting. > > Also fixes sign rendering so negative diffs show a leading `-` (positive keeps `+`, zero shows no sign) while keeping the percentage calculation display unchanged. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 4055c10. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent 1897f33 commit a092b62

1 file changed

Lines changed: 8 additions & 2 deletions

File tree

  • app/components/UI/AssetOverview/Price

app/components/UI/AssetOverview/Price/Price.tsx

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,8 +129,14 @@ const Price = ({
129129
variant={TextVariant.BodyMDMedium}
130130
allowFontScaling={false}
131131
>
132-
{diff > 0 ? '+' : ''}
133-
{addCurrencySymbol(diff, currentCurrency, true)} (
132+
{diff > 0 ? '+' : diff < 0 ? '-' : ''}
133+
{diff !== 0
134+
? formatPriceWithSubscriptNotation(
135+
Math.abs(diff),
136+
currentCurrency,
137+
)
138+
: addCurrencySymbol(0, currentCurrency, true)}{' '}
139+
{'('}
134140
{diff > 0 ? '+' : ''}
135141
{diff === 0 ? '0' : ((diff / comparePrice) * 100).toFixed(2)}
136142
%){' '}

0 commit comments

Comments
 (0)