fix: resetpassword screen touch-id state (MetaMask#23798)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
* fix: resetpassword screen touch-id state
* Jira: https://consensyssoftware.atlassian.net/browse/SL-371
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: resetpassword screen touch-id state

## **Related issues**

Fixes: https://consensyssoftware.atlassian.net/browse/SL-371

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Saves biometry choice to storage only after a successful password
reset, removing premature writes and adding tests to verify the flow.
> 
> - **ResetPassword flow
(`app/components/Views/ResetPassword/index.js`)**:
> - Move `updateAuthTypeStorageFlags(this.state.biometryChoice)` to run
after successful password reset and vault recreation.
>   - Remove storage update from `updateBiometryChoice` handler.
> - **Tests (`app/components/Views/ResetPassword/index.test.tsx`)**:
> - Mock `updateAuthTypeStorageFlags` and add test ensuring it is called
only after confirming the password change.
>   - Minor test scaffolding updates to support the new flow.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
937780b. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Author: grvgoel81

app/components/Views/ResetPassword/index.js

@@ -542,13 +542,22 @@ class ResetPassword extends PureComponent {
 
       // Set biometrics for new password
       await Authentication.resetPassword();
+
       try {
         // compute and store the new authentication method
         const authData = await Authentication.componentAuthenticationType(
           this.state.biometryChoice,
           this.state.rememberMe,
         );
         await Authentication.storePasswordWithFallback(password, authData);
+        if (
+          Authentication.authData.currentAuthType ===
+          AUTHENTICATION_TYPE.BIOMETRIC
+        ) {
+          await updateAuthTypeStorageFlags(this.state.biometryChoice);
+        } else {
+          await updateAuthTypeStorageFlags(false);
+        }
       } catch (error) {
         Logger.error(error);
       }
@@ -624,7 +633,6 @@ class ResetPassword extends PureComponent {
   };
 
   updateBiometryChoice = async (biometryChoice) => {
-    await updateAuthTypeStorageFlags(biometryChoice);
     this.setState({ biometryChoice });
   };
 

app/components/Views/ResetPassword/index.test.tsx

@@ -47,6 +47,13 @@ jest.mock('../../../core/Engine', () => ({
 
 jest.mock('lottie-react-native', () => 'LottieView');
 
+const mockUpdateAuthTypeStorageFlags = jest.fn().mockResolvedValue(undefined);
+jest.mock('../../../util/authentication', () => ({
+  ...jest.requireActual('../../../util/authentication'),
+  updateAuthTypeStorageFlags: (biometryChoice: boolean) =>
+    mockUpdateAuthTypeStorageFlags(biometryChoice),
+}));
+
 jest.mock('../../../store/storage-wrapper', () => ({
   setItem: jest.fn(),
   getItem: jest.fn().mockResolvedValue(null), // Mock to return null to avoid biometrics interference
@@ -65,6 +72,7 @@ jest.mock('../../../core/Authentication', () => ({
   getPassword: jest.fn().mockResolvedValue(null),
   resetPassword: jest.fn().mockResolvedValue(undefined),
   storePassword: jest.fn().mockResolvedValue(undefined),
+  storePasswordWithFallback: jest.fn().mockResolvedValue(undefined),
   newWalletAndKeychain: jest
     .fn()
     .mockImplementation(
@@ -77,6 +85,9 @@ jest.mock('../../../core/Authentication', () => ({
     ),
   checkIsSeedlessPasswordOutdated: jest.fn().mockResolvedValue(false),
   lockApp: jest.fn().mockResolvedValue(undefined),
+  authData: {
+    currentAuthType: 'passcode',
+  },
 }));
 
 jest.mock('../../../core/NavigationService', () => ({
@@ -1004,4 +1015,120 @@ describe('ResetPassword', () => {
       );
     });
   });
+
+  describe('biometry choice storage', () => {
+    it('saves biometry choice as false when auth type is not biometric', async () => {
+      mockUpdateAuthTypeStorageFlags.mockClear();
+
+      const component = await renderConfirmPasswordView();
+
+      const newPasswordInput = component.getByTestId(
+        ChoosePasswordSelectorsIDs.NEW_PASSWORD_INPUT_ID,
+      );
+
+      await act(async () => {
+        fireEvent.changeText(newPasswordInput, 'NewPassword123');
+      });
+
+      const confirmPasswordInput = component.getByTestId(
+        ChoosePasswordSelectorsIDs.CONFIRM_PASSWORD_INPUT_ID,
+      );
+
+      await act(async () => {
+        fireEvent.changeText(confirmPasswordInput, 'NewPassword123');
+      });
+
+      const submitButton = component.getByTestId(
+        ChoosePasswordSelectorsIDs.SUBMIT_BUTTON_ID,
+      );
+
+      await act(async () => {
+        fireEvent.press(submitButton);
+      });
+
+      await waitFor(() => {
+        expect(NavigationService.navigation.navigate).toHaveBeenCalledWith(
+          Routes.MODAL.ROOT_MODAL_FLOW,
+          expect.objectContaining({
+            screen: Routes.SHEET.SUCCESS_ERROR_SHEET,
+          }),
+        );
+      });
+
+      const navigationCall = (
+        NavigationService.navigation.navigate as jest.Mock
+      ).mock.calls[0];
+      const onPrimaryButtonPress =
+        navigationCall[1].params.onPrimaryButtonPress;
+
+      await act(async () => {
+        await onPrimaryButtonPress();
+      });
+
+      await waitFor(() => {
+        expect(mockUpdateAuthTypeStorageFlags).toHaveBeenCalledWith(false);
+      });
+    });
+
+    it('saves biometry choice when auth type is biometric', async () => {
+      mockUpdateAuthTypeStorageFlags.mockClear();
+
+      const mockAuthModule = jest.requireMock('../../../core/Authentication');
+      const originalAuthData = mockAuthModule.authData;
+      mockAuthModule.authData = {
+        currentAuthType: AUTHENTICATION_TYPE.BIOMETRIC,
+      };
+
+      const component = await renderConfirmPasswordView();
+
+      const newPasswordInput = component.getByTestId(
+        ChoosePasswordSelectorsIDs.NEW_PASSWORD_INPUT_ID,
+      );
+
+      await act(async () => {
+        fireEvent.changeText(newPasswordInput, 'NewPassword123');
+      });
+
+      const confirmPasswordInput = component.getByTestId(
+        ChoosePasswordSelectorsIDs.CONFIRM_PASSWORD_INPUT_ID,
+      );
+
+      await act(async () => {
+        fireEvent.changeText(confirmPasswordInput, 'NewPassword123');
+      });
+
+      const submitButton = component.getByTestId(
+        ChoosePasswordSelectorsIDs.SUBMIT_BUTTON_ID,
+      );
+
+      await act(async () => {
+        fireEvent.press(submitButton);
+      });
+
+      await waitFor(() => {
+        expect(NavigationService.navigation.navigate).toHaveBeenCalledWith(
+          Routes.MODAL.ROOT_MODAL_FLOW,
+          expect.objectContaining({
+            screen: Routes.SHEET.SUCCESS_ERROR_SHEET,
+          }),
+        );
+      });
+
+      const navigationCall = (
+        NavigationService.navigation.navigate as jest.Mock
+      ).mock.calls[0];
+      const onPrimaryButtonPress =
+        navigationCall[1].params.onPrimaryButtonPress;
+
+      await act(async () => {
+        await onPrimaryButtonPress();
+      });
+
+      await waitFor(() => {
+        expect(mockUpdateAuthTypeStorageFlags).toHaveBeenCalled();
+      });
+
+      mockAuthModule.authData = originalAuthData;
+    });
+  });
 });