Skip to content

Commit bb0fee4

Browse files
authored
chore: remove rewards season 1 e2e tests (MetaMask#25344)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** https://consensyssoftware.atlassian.net/browse/RWDS-942 Remove e2e tests for Rewards season 1 <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk since this only deletes E2E test code and CI jobs; primary impact is reduced automated coverage for Rewards. > > **Overview** > Removes the Rewards Season 1 E2E coverage by deleting the Rewards smoke spec, its mock server fixtures, and related page objects. > > Updates smoke-test infrastructure to drop the `SmokeRewards` tag and stop scheduling `rewards-*-smoke` jobs in the iOS/Android GitHub Actions workflows (including removing them from the reporting job dependencies). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 54f68a9. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent e4b8256 commit bb0fee4

8 files changed

Lines changed: 0 additions & 1344 deletions

File tree

.github/workflows/run-e2e-smoke-tests-android.yml

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -163,22 +163,6 @@ jobs:
163163
changed_files: ${{ inputs.changed_files }}
164164
secrets: inherit
165165

166-
rewards-android-smoke:
167-
if: contains(fromJson(inputs.selected_tags), 'ALL') || contains(fromJson(inputs.selected_tags), 'SmokeRewards')
168-
strategy:
169-
matrix:
170-
split: [1]
171-
fail-fast: false
172-
uses: ./.github/workflows/run-e2e-workflow.yml
173-
with:
174-
test-suite-name: rewards-android-smoke-${{ matrix.split }}
175-
platform: android
176-
test_suite_tag: 'SmokeRewards'
177-
split_number: ${{ matrix.split }}
178-
total_splits: 1
179-
changed_files: ${{ inputs.changed_files }}
180-
secrets: inherit
181-
182166
card-android-smoke:
183167
if: contains(fromJson(inputs.selected_tags), 'ALL') || contains(fromJson(inputs.selected_tags), 'SmokeCard')
184168
strategy:
@@ -241,7 +225,6 @@ jobs:
241225
- network-expansion-android-smoke
242226
- confirmations-android-smoke
243227
- prediction-market-android-smoke
244-
- rewards-android-smoke
245228
- card-android-smoke
246229
- ramps-android-smoke
247230
- multichain-api-android-smoke

.github/workflows/run-e2e-smoke-tests-ios.yml

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -163,22 +163,6 @@ jobs:
163163
changed_files: ${{ inputs.changed_files }}
164164
secrets: inherit
165165

166-
rewards-ios-smoke:
167-
if: contains(fromJson(inputs.selected_tags), 'ALL') || contains(fromJson(inputs.selected_tags), 'SmokeRewards')
168-
strategy:
169-
matrix:
170-
split: [1]
171-
fail-fast: false
172-
uses: ./.github/workflows/run-e2e-workflow.yml
173-
with:
174-
test-suite-name: rewards-ios-smoke-${{ matrix.split }}
175-
platform: ios
176-
test_suite_tag: 'SmokeRewards'
177-
split_number: ${{ matrix.split }}
178-
total_splits: 1
179-
changed_files: ${{ inputs.changed_files }}
180-
secrets: inherit
181-
182166
card-ios-smoke:
183167
if: contains(fromJson(inputs.selected_tags), 'ALL') || contains(fromJson(inputs.selected_tags), 'SmokeCard')
184168
strategy:
@@ -241,7 +225,6 @@ jobs:
241225
- network-abstraction-ios-smoke
242226
- network-expansion-ios-smoke
243227
- prediction-market-ios-smoke
244-
- rewards-ios-smoke
245228
- card-ios-smoke
246229
- ramps-ios-smoke
247230
- multichain-api-ios-smoke

e2e/pages/Rewards/RewardsActivityTabView.ts

Lines changed: 0 additions & 84 deletions
This file was deleted.

e2e/pages/Rewards/RewardsOnboarding.ts

Lines changed: 0 additions & 86 deletions
This file was deleted.

e2e/pages/Rewards/RewardsView.ts

Lines changed: 0 additions & 56 deletions
This file was deleted.

e2e/tags.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,6 @@ const smokeTags = {
4646
description:
4747
'Tests MetaMask Card integration for crypto-to-fiat spending. Covers the Card home screen display showing card status and balance, the Add Funds button with Deposit and Swap funding options, and Advanced Card Management which opens the external card dashboard in the browser. Tests the Card navbar button for quick navigation to Card home. Validates card-related analytics events: Card Button Viewed, Card Home Clicked, Card Add Funds Clicked, and Card Advanced Management Clicked. The Card feature is controlled by experimental feature flags. Integrates with SmokeTrade for funding via swaps.',
4848
},
49-
smokeRewards: {
50-
tag: 'SmokeRewards:',
51-
description:
52-
'Tests the MetaMask Rewards incentive program. Covers the rewards opt-in onboarding flow with its multi-screen carousel, claiming sign-up bonuses, displaying reward tier levels (e.g., Level 1 "Origin"), and showing earned points balance. Tests the Activity tab displaying reward-earning actions including sign-up bonuses, perpetuals trading rewards, swap rewards, and referral activities. Note: Tests are currently skipped pending rewards system stabilization. When enabled, integrates with SmokeTrade for trading reward triggers.',
53-
},
5449
smokePerps: {
5550
tag: 'SmokePerps:',
5651
description:
@@ -111,7 +106,6 @@ const SmokeTrade = (testName) => `${smokeTags.smokeTrade.tag} ${testName}`;
111106
const SmokeWalletPlatform = (testName) =>
112107
`${smokeTags.smokeWalletPlatform.tag} ${testName}`;
113108
const SmokeCard = (testName) => `${smokeTags.smokeCard.tag} ${testName}`;
114-
const SmokeRewards = (testName) => `${smokeTags.smokeRewards.tag} ${testName}`;
115109
const SmokePerps = (testName) => `${smokeTags.smokePerps.tag} ${testName}`;
116110
const SmokeRamps = (testName) => `${smokeTags.smokeRamps.tag} ${testName}`;
117111
const SmokeMultiChainAPI = (testName) =>
@@ -154,7 +148,6 @@ export {
154148
SmokeTrade,
155149
SmokeWalletPlatform,
156150
SmokeCard,
157-
SmokeRewards,
158151
SmokePerps,
159152
SmokeRamps,
160153
SmokeMultiChainAPI,

0 commit comments

Comments
 (0)