Skip to content

Commit c6c099f

Browse files
authored
chore: Make Asset sort e2e test more robust cp-7.53.0 (MetaMask#18046)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** - This PR unblocks [this pr](MetaMask#17789) - With FlashList v2, the list tree is not re rendered and instead recycled so we cannot rely on the label to check the order of the list. - to address this, we reload the app so that we can see the new tree label and test the ordering. ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
1 parent dc8f82d commit c6c099f

1 file changed

Lines changed: 9 additions & 0 deletions

File tree

e2e/specs/assets/multichain/asset-sort.spec.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ import ConfirmAddAssetView from '../../../pages/wallet/ImportTokenFlow/ConfirmAd
1111
import Tenderly from '../../../tenderly';
1212
import { CustomNetworks } from '../../../resources/networks.e2e';
1313
import ImportTokensView from '../../../pages/wallet/ImportTokenFlow/ImportTokensView';
14+
import TestHelpers from '../../../helpers';
15+
import { getFixturesServerPort } from '../../../fixtures/utils';
1416

1517
const AAVE_TENDERLY_MAINNET_DETAILS = {
1618
address: '0x7Fc66500c84A76Ad7e9c93437bFc5Ac33E2DDaE9',
@@ -59,13 +61,20 @@ describe(SmokeNetworkAbstractions('Import Tokens'), () => {
5961
fixture: new FixtureBuilder()
6062
.withNetworkController(CustomNetworks.Tenderly.Mainnet)
6163
.withTokens([AAVE_TENDERLY_MAINNET_DETAILS])
64+
.withMetaMetricsOptIn()
6265
.build(),
6366
restartDevice: true,
6467
},
6568
async () => {
6669
await loginToApp();
6770
await WalletView.tapSortBy();
6871
await SortModal.tapSortAlphabetically();
72+
// Relaunching the app since the tree is not re-rendered with FlashList v2.
73+
await device.terminateApp();
74+
await TestHelpers.launchApp({
75+
launchArgs: { fixtureServerPort: `${getFixturesServerPort()}` },
76+
});
77+
await loginToApp();
6978

7079
const tokens =
7180
(await WalletView.getTokensInWallet()) as IndexableNativeElement;

0 commit comments

Comments
 (0)