fix: cp-7.53.0 e2e misusing checksum addresses (MetaMask#17896)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

After investigating state on both mobile and extension, the
AccountsController and other state fixtures were incorrectly using
checksummed addresses when we should be using lowercase addresses.

This was uncovered since the new AccountTreeInit links together the
`KeyringController` and the `AccountsController`

https://github.com/MetaMask/metamask-mobile/blob/390dee8bb650c0f1f7a1fed3b8d15e67fa670093/app/multichain-accounts/AccountTreeInitService/index.ts#L26-L29

Fixes Failing Tests:
```
e2e/specs/assets/import-tokens-via-asset-watcher.spec.ts
e2e/specs/assets/multichain/asset-sort.spec.ts
e2e/specs/assets/defi/view-defi-details.spec.ts
e2e/specs/assets/defi/view-defi-tab.spec.ts
```

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry:

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Author: Prithpal-Sooriya

e2e/api-mocking/mock-config/mock-events.js

@@ -8,6 +8,7 @@ import {
   suggestedGasFeesApiGanache,
 } from '../mock-responses/gas-api-responses.json';
 import defiPositionsWithData from '../mock-responses/defi-api-response-data.json';
+import { DEFAULT_FIXTURE_ACCOUNT } from '../../framework/fixtures/FixtureBuilder';
 
 export const mockEvents = {
   /**
@@ -164,22 +165,19 @@ export const mockEvents = {
     },
 
     defiPositionsWithNoData: {
-      urlEndpoint:
-        'https://defiadapters.api.cx.metamask.io/positions/0x76cf1CdD1fcC252442b50D6e97207228aA4aefC3',
+      urlEndpoint: `https://defiadapters.api.cx.metamask.io/positions/${DEFAULT_FIXTURE_ACCOUNT}`,
       response: { data: [] },
       responseCode: 200,
     },
 
     defiPositionsError: {
-      urlEndpoint:
-        'https://defiadapters.api.cx.metamask.io/positions/0x76cf1CdD1fcC252442b50D6e97207228aA4aefC3',
+      urlEndpoint: `https://defiadapters.api.cx.metamask.io/positions/${DEFAULT_FIXTURE_ACCOUNT}`,
       response: { error: 'Internal server error' },
       responseCode: 500,
     },
 
     defiPositionsWithData: {
-      urlEndpoint:
-        'https://defiadapters.api.cx.metamask.io/positions/0x76cf1CdD1fcC252442b50D6e97207228aA4aefC3',
+      urlEndpoint: `https://defiadapters.api.cx.metamask.io/positions/${DEFAULT_FIXTURE_ACCOUNT}`,
       response: { data: defiPositionsWithData },
       responseCode: 200,
     },

e2e/fixtures/utils.js

@@ -78,6 +78,7 @@ export function buildPermissions(chainIds) {
       caveats: [
         {
           type: Caip25CaveatType,
+          /** @type {import('@metamask/chain-agnostic-permission').Caip25CaveatValue} */
           value: {
             optionalScopes,
             requiredScopes: {},

e2e/framework/fixtures/FixtureBuilder.ts

@@ -18,9 +18,14 @@ import {
 import { BackupAndSyncSettings, RampsRegion } from '../types';
 import { MULTIPLE_ACCOUNTS_ACCOUNTS_CONTROLLER } from './constants';
 
-export const DEFAULT_FIXTURE_ACCOUNT =
+export const DEFAULT_FIXTURE_ACCOUNT_CHECKSUM =
   '0x76cf1CdD1fcC252442b50D6e97207228aA4aefC3';
 
+export const DEFAULT_FIXTURE_ACCOUNT =
+  DEFAULT_FIXTURE_ACCOUNT_CHECKSUM.toLowerCase() as Lowercase<
+    typeof DEFAULT_FIXTURE_ACCOUNT_CHECKSUM
+  >;
+
 export const DEFAULT_FIXTURE_ACCOUNT_2 =
   '0xcdd74c6eb517f687aa2c786bc7484eb2f9bae1da';
 
@@ -128,12 +133,12 @@ class FixtureBuilder {
             AccountTrackerController: {
               accountsByChainId: {
                 64: {
-                  [DEFAULT_FIXTURE_ACCOUNT]: {
+                  [DEFAULT_FIXTURE_ACCOUNT_CHECKSUM]: {
                     balance: '0x0',
                   },
                 },
                 1: {
-                  [DEFAULT_FIXTURE_ACCOUNT]: {
+                  [DEFAULT_FIXTURE_ACCOUNT_CHECKSUM]: {
                     balance: '0x0',
                   },
                 },
@@ -818,7 +823,7 @@ class FixtureBuilder {
     const permittedEthAccounts =
       incomingEthAccounts.length > 0
         ? incomingEthAccounts
-        : [DEFAULT_FIXTURE_ACCOUNT];
+        : [DEFAULT_FIXTURE_ACCOUNT_CHECKSUM];
 
     // Cast addresses to the required 0x${string} format
     const typedAddresses = permittedEthAccounts.map(
@@ -932,7 +937,7 @@ class FixtureBuilder {
     );
     const caip25CaveatValueWithDefaultAccount = setEthAccounts(
       caip25CaveatValueWithChains,
-      [DEFAULT_FIXTURE_ACCOUNT],
+      [DEFAULT_FIXTURE_ACCOUNT_CHECKSUM],
     );
     const chainPermission = {
       [Caip25EndowmentPermissionName]: {

e2e/specs/assets/import-tokens-via-asset-watcher.spec.ts

@@ -1,7 +1,9 @@
 import { SmokeNetworkAbstractions } from '../../tags';
 import TestHelpers from '../../helpers';
 import { loginToApp } from '../../viewHelper';
-import FixtureBuilder from '../../framework/fixtures/FixtureBuilder';
+import FixtureBuilder, {
+  DEFAULT_FIXTURE_ACCOUNT,
+} from '../../framework/fixtures/FixtureBuilder';
 import { withFixtures } from '../../framework/fixtures/FixtureHelper';
 import { SMART_CONTRACTS } from '../../../app/util/test/smart-contracts';
 
@@ -12,6 +14,7 @@ import AssetWatchBottomSheet from '../../pages/Transactions/AssetWatchBottomShee
 import WalletView from '../../pages/wallet/WalletView';
 import { buildPermissions } from '../../fixtures/utils';
 import { DappVariants } from '../../framework/Constants';
+import { setEthAccounts } from '@metamask/chain-agnostic-permission';
 
 const ERC20_CONTRACT = SMART_CONTRACTS.HST;
 
@@ -23,6 +26,16 @@ describe(SmokeNetworkAbstractions('Asset Watch:'), () => {
     await TestHelpers.reverseServerPort();
   });
 
+  const buildERC20PermsForAddress = () => {
+    const perms = buildPermissions(['0x539']);
+    perms['endowment:caip25'].caveats[0].value = setEthAccounts(
+      perms['endowment:caip25'].caveats[0].value,
+      [DEFAULT_FIXTURE_ACCOUNT],
+    );
+
+    return perms;
+  };
+
   it('Should Import ERC20 Token via Dapp', async () => {
     await withFixtures(
       {
@@ -34,7 +47,7 @@ describe(SmokeNetworkAbstractions('Asset Watch:'), () => {
         fixture: new FixtureBuilder()
           .withGanacheNetwork()
           .withPermissionControllerConnectedToTestDapp(
-            buildPermissions(['0x539']),
+            buildERC20PermsForAddress(),
           )
           .build(),
         restartDevice: true,

e2e/specs/multichain-accounts/common.ts

@@ -1,6 +1,6 @@
 import { mockEvents } from '../../api-mocking/mock-config/mock-events';
 import FixtureBuilder, {
-  DEFAULT_FIXTURE_ACCOUNT,
+  DEFAULT_FIXTURE_ACCOUNT_CHECKSUM,
 } from '../../framework/fixtures/FixtureBuilder';
 import { withFixtures } from '../../framework/fixtures/FixtureHelper';
 import AccountListBottomSheet from '../../pages/wallet/AccountListBottomSheet';
@@ -16,13 +16,13 @@ export interface Account {
 export const HD_ACCOUNT: Account = {
   name: 'Account 1',
   index: 0,
-  address: DEFAULT_FIXTURE_ACCOUNT,
+  address: DEFAULT_FIXTURE_ACCOUNT_CHECKSUM,
 };
 
 export const SIMPLE_KEYPAIR_ACCOUNT: Account = {
   name: 'Account 4',
   index: 4,
-  address: DEFAULT_FIXTURE_ACCOUNT,
+  address: DEFAULT_FIXTURE_ACCOUNT_CHECKSUM,
 };
 
 export const goToAccountDetails = async (account: Account) => {

e2e/specs/notifications/notification-settings-flow.spec.ts

@@ -4,7 +4,7 @@ import Assertions from '../../framework/Assertions';
 import { mockNotificationServices } from './utils/mocks';
 import { withFixtures } from '../../framework/fixtures/FixtureHelper';
 import FixtureBuilder, {
-  DEFAULT_FIXTURE_ACCOUNT,
+  DEFAULT_FIXTURE_ACCOUNT_CHECKSUM,
 } from '../../framework/fixtures/FixtureBuilder';
 import { loginToApp } from '../../viewHelper';
 import TabBarComponent from '../../pages/wallet/TabBarComponent';
@@ -66,11 +66,11 @@ describe(SmokeNetworkAbstractions('Notification Onboarding'), () => {
 
         // Test account notifications toggle functionality
         await NotificationSettingsView.tapAccountNotificationsToggleAndVerifyState(
-          DEFAULT_FIXTURE_ACCOUNT,
+          DEFAULT_FIXTURE_ACCOUNT_CHECKSUM,
           'off',
         );
         await NotificationSettingsView.tapAccountNotificationsToggleAndVerifyState(
-          DEFAULT_FIXTURE_ACCOUNT,
+          DEFAULT_FIXTURE_ACCOUNT_CHECKSUM,
           'on',
         );