Commit ce498e9
authored
feat: remove quote details tooltip cta and fix paddings (MetaMask#26156)
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->
## **Description**
Make TooltipModal CTA optional to prevent rendering the CTA of the
tooltip on top of the swaps CTA causing misclicks.
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
## **Changelog**
<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`
If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`
(This helps the Release Engineer do their job more quickly and
accurately)
-->
CHANGELOG entry: remove quote details tooltip cta and fix paddings
## **Related issues**
Fixes: https://consensyssoftware.atlassian.net/browse/SWAPS-4129
## **Manual testing steps**
```gherkin
Feature: my feature name
Scenario: user [verb for user action]
Given [describe expected initial app state]
When user [verb for user action]
Then [describe expected outcome]
```
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **Before**
<!-- [screenshots/recordings] -->
### **After**
<img width="499" height="236" alt="εικόνα"
src="https://github.com/user-attachments/assets/cd4e5d5a-a572-4416-b96e-2db674e62935"
/>
## **Pre-merge author checklist**
- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Low Risk**
> Small UI param removal limited to tooltip modal configuration and test
updates; low chance of behavioral impact beyond tooltip spacing.
>
> **Overview**
> Bridge `QuoteDetailsCard` no longer passes a hardcoded `bottomPadding`
to the tooltip modal for quote rate, network fee, slippage, minimum
received, price impact, and rewards tooltips, removing the now-unused
`TOOLTIP_BOTTOM_PADDING` constant.
>
> Associated navigation assertions in `QuoteDetailsCard.test.tsx` were
updated to expect tooltip modal params without `bottomPadding`.
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
00ad73f. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->1 parent 5d11a21 commit ce498e9
2 files changed
Lines changed: 0 additions & 13 deletions
File tree
- app/components/UI/Bridge/components/QuoteDetailsCard
Lines changed: 0 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
489 | 489 | | |
490 | 490 | | |
491 | 491 | | |
492 | | - | |
493 | 492 | | |
494 | 493 | | |
495 | 494 | | |
| |||
578 | 577 | | |
579 | 578 | | |
580 | 579 | | |
581 | | - | |
582 | 580 | | |
583 | 581 | | |
584 | 582 | | |
| |||
Lines changed: 0 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | 56 | | |
60 | 57 | | |
61 | 58 | | |
| |||
176 | 173 | | |
177 | 174 | | |
178 | 175 | | |
179 | | - | |
180 | 176 | | |
181 | 177 | | |
182 | 178 | | |
| |||
206 | 202 | | |
207 | 203 | | |
208 | 204 | | |
209 | | - | |
210 | 205 | | |
211 | 206 | | |
212 | 207 | | |
| |||
262 | 257 | | |
263 | 258 | | |
264 | 259 | | |
265 | | - | |
266 | 260 | | |
267 | 261 | | |
268 | 262 | | |
| |||
287 | 281 | | |
288 | 282 | | |
289 | 283 | | |
290 | | - | |
291 | 284 | | |
292 | 285 | | |
293 | 286 | | |
| |||
327 | 320 | | |
328 | 321 | | |
329 | 322 | | |
330 | | - | |
331 | 323 | | |
332 | 324 | | |
333 | 325 | | |
| |||
355 | 347 | | |
356 | 348 | | |
357 | 349 | | |
358 | | - | |
359 | 350 | | |
360 | 351 | | |
361 | 352 | | |
| |||
388 | 379 | | |
389 | 380 | | |
390 | 381 | | |
391 | | - | |
392 | 382 | | |
393 | 383 | | |
394 | 384 | | |
| |||
426 | 416 | | |
427 | 417 | | |
428 | 418 | | |
429 | | - | |
430 | 419 | | |
431 | 420 | | |
432 | 421 | | |
| |||
0 commit comments