Skip to content

Commit dc62a84

Browse files
authored
feat: skeleton migration (swaps scope) (MetaMask#27204)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Migrated `Skeleton` component to design system. ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/DSYS-274 ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** https://github.com/user-attachments/assets/7c871005-b0b1-41d5-9d4e-1b1323990be3 ### **After** https://github.com/user-attachments/assets/a53b3d28-8977-4cac-847e-1f4e677a3bdb ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk UI-only change that swaps Bridge loading placeholders to the new `components-temp` design-system `Skeleton` wrapper; main risk is minor visual/animation differences during loading states. > > **Overview** > Updates Bridge loading UI to use the design-system-backed `Skeleton` by switching imports from the deprecated `component-library/components/Skeleton` to `component-library/components-temp/Skeleton` in `QuoteDetailsCardSkeleton`, `SkeletonItem`, and `TokenInputArea`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 2ec0763. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent 289f897 commit dc62a84

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

app/components/UI/Bridge/components/QuoteDetailsCard/QuoteDetailsCardSkeleton.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {
55
BoxJustifyContent,
66
BoxAlignItems,
77
} from '@metamask/design-system-react-native';
8-
import { Skeleton } from '../../../../../component-library/components/Skeleton';
8+
import { Skeleton } from '../../../../../component-library/components-temp/Skeleton';
99
import { BridgeViewSelectorsIDs } from '../../Views/BridgeView/BridgeView.testIds';
1010

1111
const ROWS: readonly (readonly [string, string])[] = [

app/components/UI/Bridge/components/SkeletonItem.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { Box } from '../../Box/Box';
44
import { useStyles } from '../../../../component-library/hooks';
55
import { Theme } from '../../../../util/theme/models';
66
import { FlexDirection, AlignItems } from '../../Box/box.types';
7-
import { Skeleton } from '../../../../component-library/components/Skeleton';
7+
import { Skeleton } from '../../../../component-library/components-temp/Skeleton';
88

99
const createStyles = (_params: { theme: Theme }) =>
1010
StyleSheet.create({

app/components/UI/Bridge/components/TokenInputArea/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import { TokenButton } from '../TokenButton';
1818
import { selectCurrentCurrency } from '../../../../../selectors/currencyRateController';
1919
import { BigNumber } from 'ethers';
2020
import { BridgeToken } from '../../types';
21-
import { Skeleton } from '../../../../../component-library/components/Skeleton';
21+
import { Skeleton } from '../../../../../component-library/components-temp/Skeleton';
2222
import Button, {
2323
ButtonVariants,
2424
} from '../../../../../component-library/components/Buttons/Button';

0 commit comments

Comments
 (0)