Skip to content

Commit ddd333c

Browse files
fix: MUL-1331 modify android manifest file for correct BLE location permission. (MetaMask#23759)
our current BLE permission is wrong based on https://consensyssoftware.atlassian.net/browse/MUL-1331 record. This PR will update the manifest.yml file to correct the wrong setting in BLE permisison. <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Modify the android manifest so that android 12+ will never ask for location permission. ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/MUL-1331 ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Adjusts BLE-related permissions to avoid unnecessary location prompts on Android 12+. > > - In `android/app/src/main/AndroidManifest.xml`, restricts `ACCESS_FINE_LOCATION` with `android:maxSdkVersion="30"` (pre-Android 12 only) > - Adds `android:usesPermissionFlags="neverForLocation"` to `BLUETOOTH_SCAN` (Android 12+) > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 7eb729d. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Owen Craston <owen.craston@consensys.net>
1 parent fd5e185 commit ddd333c

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

android/app/src/main/AndroidManifest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@
1212
<!-- Android < 12 -->
1313
<uses-permission android:name="android.permission.BLUETOOTH" android:maxSdkVersion="30" />
1414
<uses-permission android:name="android.permission.BLUETOOTH_ADMIN" android:maxSdkVersion="30" />
15-
<uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />
15+
<uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" android:maxSdkVersion="30" />
1616
<uses-feature android:name="android.hardware.bluetooth_le" android:required="false" />
1717

1818
<!-- Bluetooth permissions: Android API >= 31 (Android 12)-->
1919
<uses-permission android:name="android.permission.BLUETOOTH_CONNECT" />
20-
<uses-permission android:name="android.permission.BLUETOOTH_SCAN" />
20+
<uses-permission android:name="android.permission.BLUETOOTH_SCAN" android:usesPermissionFlags="neverForLocation"/>
2121

2222
<uses-sdk tools:overrideLibrary="com.tectiv3.aes" />
2323

0 commit comments

Comments
 (0)