Commit e2bb36a
authored
fix(deps): Force-resolve @metamask/messenger to ^1.0.0 (MetaMask#28060)
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->
## **Description**
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
Recently we released `@metamask/messenger` 1.0.0, and we upgraded all
core packages to use this version. Unfortunately, this makes it
impossible to bump a single core package in this repo. Doing so means
that there are two versions of this package in the dependency tree in
use at the same time, and this results in a type error, since the
`Messenger` type from 1.0.0 is incompatible with the `Messenger` type
from previous versions due to the use of private fields (see
<microsoft/TypeScript#62486> and other
TypeScript issues).
To truly fix this, we would have to upgrade all core packages. This is
non-trivial, so to unblock teams we force-resolve `@metamask/messenger`
to 1.0.0 across the dependency tree. This should be safe as there are no
breaking changes in 1.0.0 (this release was just a formality to
communicate that the package is now stable).
## **Changelog**
<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`
If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`
(This helps the Release Engineer do their job more quickly and
accurately)
-->
CHANGELOG entry: null
## **Related issues**
(N/A)
## **Manual testing steps**
Should be already covered by CI, but just in case, try upgrading a core
package. `yarn lint:tsc` should still pass.
## **Screenshots/Recordings**
(N/A)
### **Before**
<!-- [screenshots/recordings] -->
### **After**
<!-- [screenshots/recordings] -->
## **Pre-merge author checklist**
- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Low Risk**
> Low risk dependency-resolution change; main risk is unforeseen
runtime/type incompatibilities if any transitive dependency relied on
`@metamask/messenger@0.x` behavior.
>
> **Overview**
> Forces the dependency tree to use `@metamask/messenger@^1.0.0` by
adding a Yarn `resolutions` override, preventing multiple
`@metamask/messenger` versions from being installed simultaneously.
>
> Updates the direct dependency and lockfile to
`@metamask/messenger@1.0.0`, removing the locked `0.3.0` entry.
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
c6b17de. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->1 parent 34a7b88 commit e2bb36a
2 files changed
Lines changed: 4 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
188 | 188 | | |
189 | 189 | | |
190 | 190 | | |
191 | | - | |
| 191 | + | |
| 192 | + | |
192 | 193 | | |
193 | 194 | | |
194 | 195 | | |
| |||
259 | 260 | | |
260 | 261 | | |
261 | 262 | | |
262 | | - | |
| 263 | + | |
263 | 264 | | |
264 | 265 | | |
265 | 266 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8886 | 8886 | | |
8887 | 8887 | | |
8888 | 8888 | | |
8889 | | - | |
8890 | | - | |
8891 | | - | |
8892 | | - | |
8893 | | - | |
8894 | | - | |
8895 | | - | |
8896 | 8889 | | |
8897 | 8890 | | |
8898 | 8891 | | |
| |||
35613 | 35606 | | |
35614 | 35607 | | |
35615 | 35608 | | |
35616 | | - | |
| 35609 | + | |
35617 | 35610 | | |
35618 | 35611 | | |
35619 | 35612 | | |
| |||
0 commit comments