Commit ec9230f
authored
test: remove bip44 ff from chain permissions tests (MetaMask#26961)
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->
## **Description**
The E2E tests for the files,
e2e/specs/multichain/permissions/chains/permission-system-dapp-chain-switch-grant.spec.js
tests/smoke/multichain/permissions/chains/permission-system-initial-connection.spec.js
Fail once the BIP-44 flag is removed and currently it is being mocked to
be OFF for this test. This mock is not correct since it does not
represent the real state of the wallet in production.
The goal of this ticket is to update the test file to be compatible with
BIP-44. If the tests are not relevant anymore, they can be deleted from
the test suite. For this remove the testSpecificMock from the fixture
and check for failures in the test.
## **Changelog**
<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`
If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`
(This helps the Release Engineer do their job more quickly and
accurately)
-->
CHANGELOG entry:
## **Related issues**
Fixes:
## **Manual testing steps**
```gherkin
Feature: my feature name
Scenario: user [verb for user action]
Given [describe expected initial app state]
When user [verb for user action]
Then [describe expected outcome]
```
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **Before**
<!-- [screenshots/recordings] -->
### **After**
<!-- [screenshots/recordings] -->
## **Pre-merge author checklist**
- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Low Risk**
> Low risk because changes are isolated to Detox smoke tests and
primarily adjust setup/expectations to match updated UI flows. Main risk
is increased test flakiness if the new selectors/labels vary across
builds or locales.
>
> **Overview**
> Removes the remote feature-flag mocking from the chain-permissions
smoke tests and unskips the dApp chain-switch permission test so it runs
by default.
>
> Updates test flows/assertions to match the current Connected Accounts
modal: checks for `disconnectAllAccountsAndNetworksButton` visibility
instead of the modal title/manage-permissions step, uses
select/deselect-all interactions for network permissions validation, and
updates the expected network picker label (`'E'` -> `'l E'`).
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
5c25e60. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->1 parent 5f6025d commit ec9230f
2 files changed
Lines changed: 11 additions & 30 deletions
File tree
- tests/smoke/multichain/permissions/chains
Lines changed: 2 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
16 | | - | |
17 | 15 | | |
18 | | - | |
| 16 | + | |
19 | 17 | | |
20 | 18 | | |
21 | 19 | | |
| |||
35 | 33 | | |
36 | 34 | | |
37 | 35 | | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | 36 | | |
45 | 37 | | |
46 | 38 | | |
| |||
69 | 61 | | |
70 | 62 | | |
71 | 63 | | |
72 | | - | |
73 | 64 | | |
74 | 65 | | |
75 | 66 | | |
76 | | - | |
| 67 | + | |
77 | 68 | | |
78 | 69 | | |
79 | 70 | | |
| |||
Lines changed: 9 additions & 19 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
15 | | - | |
16 | 14 | | |
17 | 15 | | |
18 | 16 | | |
| |||
29 | 27 | | |
30 | 28 | | |
31 | 29 | | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | 30 | | |
39 | 31 | | |
40 | 32 | | |
| |||
46 | 38 | | |
47 | 39 | | |
48 | 40 | | |
49 | | - | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
50 | 44 | | |
51 | 45 | | |
52 | 46 | | |
| |||
61 | 55 | | |
62 | 56 | | |
63 | 57 | | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | 58 | | |
71 | 59 | | |
72 | 60 | | |
| |||
97 | 85 | | |
98 | 86 | | |
99 | 87 | | |
100 | | - | |
101 | | - | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
102 | 91 | | |
103 | 92 | | |
104 | 93 | | |
105 | 94 | | |
106 | 95 | | |
107 | 96 | | |
108 | | - | |
109 | | - | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
110 | 100 | | |
111 | 101 | | |
112 | 102 | | |
| |||
0 commit comments