Commit f166abb
authored
refactor(aggregator): migrate aggregator routes to native stack (MetaMask#30611)
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until this PR meets the canonical
Definition of Ready For Review in `docs/readme/ready-for-review.md`.
In short: the template must be materially complete (not just section
titles
present), all status checks must be currently passing, and the only
expected
follow-up commits must be reviewer-driven.
-->
## **Description**
Migrates the legacy aggregator routes (`Aggregator/routes/index.tsx`)
from `@react-navigation/stack` (JS stack) to
`@react-navigation/native-stack`, aligning with the rest of the Ramp
routing tree (Unified V2 `Ramp/routes.tsx` already uses native stack).
Native stack uses platform-native navigation primitives
(`UINavigationController` on iOS, `FragmentTransaction` on Android),
which yields better performance and a more native feel — especially
noticeable on the modal/overlay transitions used by `Quotes` and
`Checkout`.
The migration is purely a wiring/config change. No screen behaviour,
route names, or component imports change. Translations applied:
- Navigator: `createStackNavigator` → `createNativeStackNavigator`
- Per-screen overlay options: replaced inline `headerShown / cardStyle /
animationEnabled / detachPreviousScreen` blocks for `Quotes` and
`Checkout` with the shared `clearNativeStackNavigatorOptions` +
`transparentModalScreenOptions` presets from
`app/constants/navigation/clearStackNavigatorOptions.ts`.
- Property renames: `cardStyle` → `contentStyle`, `animationEnabled:
false` → `animation: 'none'`.
- The `detachPreviousScreen: false` workaround used to keep the
underlying screen mounted under transparent modals is no longer needed —
native stack keeps the presenting screen mounted automatically when
`presentation: 'transparentModal'` is used.
- Removed the now-unused `colors` import (it was only used to set
`cardStyle.backgroundColor: colors.transparent`).
Test mock in `routes/index.test.tsx` updated to mock
`@react-navigation/native-stack` (`createNativeStackNavigator`) instead
of `@react-navigation/stack`.
## **Changelog**
<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`
If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`
(This helps the Release Engineer do their job more quickly and
accurately)
-->
CHANGELOG entry:null
## **Related issues**
Fixes:
## **Manual testing steps**
```gherkin
Feature: my feature name
Scenario: user [verb for user action]
Given [describe expected initial app state]
When user [verb for user action]
Then [describe expected outcome]
```
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **Before**
<img width="364" height="752" alt="Aggregator Before"
src="https://github.com/user-attachments/assets/423ec7f4-66b2-48dd-bfc2-ab2769eaf260"
/>
### **After**
<img width="364" height="752" alt="Aggregator After"
src="https://github.com/user-attachments/assets/e545af4e-9b7d-4907-a343-6475c44ba0be"
/>
Android
https://github.com/user-attachments/assets/9df9f89d-3c4e-4e49-ac32-ba3896d0384f
## **Pre-merge author checklist**
<!--
Every checklist item must be consciously assessed before marking this PR
as
"Ready for review". A checked box means you deliberately considered that
responsibility, not that you literally performed every action listed.
Unchecked boxes are ambiguous: they are not an implicit "N/A" and they
are not
a silent "skip". See `docs/readme/ready-for-review.md` for the full
checklist
semantics.
-->
- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
#### Performance checks (if applicable)
- [x] I've tested on Android
- Ideally on a mid-range device; emulator is acceptable
- [ ] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [ ] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example
For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).
## **Pre-merge reviewer checklist**
<!--
Reviewer checklist items follow the same semantics as the author
checklist: an
unchecked box is ambiguous, a checked box means the reviewer consciously
assessed that responsibility. See `docs/readme/ready-for-review.md`.
-->
- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Low Risk**
> Navigation-only wiring in Ramp Aggregator routes; no business logic,
auth, or data handling changes.
>
> **Overview**
> **Aggregator Ramp routing** now uses `@react-navigation/native-stack`
instead of the JS stack, matching the newer Ramp navigation setup while
leaving screens and route names unchanged.
>
> **Quotes**, **Checkout**, and the nested **modals** stack pick up
shared `clearNativeStackNavigatorOptions` and
`transparentModalScreenOptions` instead of inline `cardStyle` /
`animationEnabled` / `detachPreviousScreen` workarounds;
`BUILD_QUOTE_HAS_STARTED` uses `animation: 'none'`. The route test mock
was updated to `createNativeStackNavigator`.
>
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
371f725. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->1 parent d95e80a commit f166abb
2 files changed
Lines changed: 24 additions & 25 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
12 | | - | |
| 11 | + | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | 13 | | |
15 | 14 | | |
16 | 15 | | |
17 | 16 | | |
18 | | - | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
19 | 21 | | |
20 | | - | |
21 | | - | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
22 | 30 | | |
23 | 31 | | |
24 | 32 | | |
25 | 33 | | |
26 | 34 | | |
27 | 35 | | |
28 | 36 | | |
29 | | - | |
| 37 | + | |
30 | 38 | | |
31 | 39 | | |
32 | 40 | | |
33 | 41 | | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
| 42 | + | |
41 | 43 | | |
42 | 44 | | |
43 | 45 | | |
44 | 46 | | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
| 47 | + | |
52 | 48 | | |
53 | 49 | | |
54 | 50 | | |
55 | 51 | | |
56 | 52 | | |
57 | 53 | | |
58 | | - | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
59 | 58 | | |
60 | 59 | | |
61 | 60 | | |
| |||
100 | 99 | | |
101 | 100 | | |
102 | 101 | | |
103 | | - | |
104 | | - | |
| 102 | + | |
| 103 | + | |
105 | 104 | | |
106 | 105 | | |
107 | 106 | | |
| |||
0 commit comments