Commit f729a9e
authored
fix: Reveal Private Credentials cp-7.54.0 (MetaMask#18484)
## **Description**
1. What is the reason for the change?
- While testing the latest RC (7.54.0) we noticed that the reveal
private credentials page (SRP and Private Key) were broken on Android.
- Clicking the password input field caused the page content to be pushed
to the very top which made it unreadable.
2. What is the improvement/solution?
- This issue was caused by the nested scrollview not applying the
flexGrow to the children. I removed the scrollview in favour of a
standard view and passed in the style flexGrow.
- I also refined the styles (removed unnecessary padding) so that the
Done button could fit on one page without scrolling.
## **Changelog**
<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`
If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`
(This helps the Release Engineer do their job more quickly and
accurately)
-->
CHANGELOG entry: null
## **Related issues**
Fixes: https://consensyssoftware.atlassian.net/browse/MUL-558
## **Manual testing steps**
```gherkin
Feature: Reveal private credential
Scenario: user clicks on the three dot menu inside the account list and it takes them to the account details page
Given a user click on reveal Secret recovery phrase
Given a user completes the SRP reveal quiz
When a user clicks on the password text field
Then the password field should remain in view of the user at all times
Given the user types the correct password
Then their SRP should be revealed
repeat the above steps with reveal private key
```
## **Screenshots/Recordings**
### **Before**
https://github.com/user-attachments/assets/7fe2ad7a-4695-4d08-8202-0a71a7b5338c
### **After**
https://github.com/user-attachments/assets/379f2479-324d-4a3a-8f6d-4969528f0591
<img width="350" height="700" alt="Simulator Screenshot - iPhone 15 Pro
- 2025-08-21 at 15 17 26"
src="https://github.com/user-attachments/assets/c1fe2644-a493-4c06-a600-2410b159a22c"
/>
## **Pre-merge author checklist**
- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.1 parent 89081bc commit f729a9e
5 files changed
Lines changed: 1292 additions & 1347 deletions
File tree
- app/components/Views
- MultichainAccounts/WalletDetails/BaseWalletDetails
- RevealPrivateCredential
- __snapshots__
Lines changed: 1 addition & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
265 | 265 | | |
266 | 266 | | |
267 | 267 | | |
268 | | - | |
269 | | - | |
270 | | - | |
271 | | - | |
272 | | - | |
273 | | - | |
| 268 | + | |
274 | 269 | | |
275 | 270 | | |
276 | 271 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
| 101 | + | |
101 | 102 | | |
102 | 103 | | |
103 | 104 | | |
| |||
Lines changed: 3 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
423 | 423 | | |
424 | 424 | | |
425 | 425 | | |
426 | | - | |
427 | 426 | | |
428 | 427 | | |
429 | 428 | | |
| |||
459 | 458 | | |
460 | 459 | | |
461 | 460 | | |
462 | | - | |
463 | 461 | | |
464 | 462 | | |
465 | 463 | | |
| |||
635 | 633 | | |
636 | 634 | | |
637 | 635 | | |
638 | | - | |
| 636 | + | |
639 | 637 | | |
640 | 638 | | |
641 | 639 | | |
| |||
658 | 656 | | |
659 | 657 | | |
660 | 658 | | |
661 | | - | |
662 | 659 | | |
663 | 660 | | |
664 | 661 | | |
665 | 662 | | |
666 | 663 | | |
667 | 664 | | |
668 | 665 | | |
669 | | - | |
| 666 | + | |
670 | 667 | | |
671 | 668 | | |
672 | 669 | | |
| |||
695 | 692 | | |
696 | 693 | | |
697 | 694 | | |
698 | | - | |
| 695 | + | |
699 | 696 | | |
700 | 697 | | |
701 | 698 | | |
| |||
0 commit comments