test: Fix for performance tests (MetaMask#22606)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
this is a PR that fixes:
performance build issues
test changes according to the new UI
test flakiness fixes
appwright patch to improve some DOM issues we had finding locators due
to nested components
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry:

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Patches Appwright (locators, BrowserStack settings) and refactors
performance tests/screens with new selectors, utilities, and modal
handling to reduce flakiness and match the updated UI.
> 
> - **Appwright (patched via Yarn)**:
> - Lower retries/workers in default config; adjust element lookup to
skip text matching; minor logging.
> - BrowserStack: add/update capabilities (networkProfile, selfHeal,
appProfiling), env‑driven buildName, Appium settings, optional video
download via `DISABLE_VIDEO_DOWNLOAD`; apply `updateSettings` on session
start.
>   - Wire patch in `package.json`/`yarn.lock`.
> - **Performance tests (Appwright)**:
> - Update login/onboarding/send/swap/asset view flows to new UI; tweak
timers; change tokens (e.g., `USDC`, `LINK`).
> - Add `dissmissPredictionsModal` and use across scenarios; skip perps
onboarding test.
> - Simplify fixture cleanup; always attach metrics; remove orphan timer
recovery/fallback.
> - **Utilities**:
> - New `appwright/utils/Utils.splitAmountIntoDigits`; refactor amount
entry in `AmountScreen`, `SwapScreen`, `BridgeScreen`,
`PerpsDepositScreen`.
> - **Screen objects**:
> - Numerous selector/tap fixes (IDs/text/XPath), iOS exact ID matching,
improved visibility timeouts, scroll-into-view, and modal buttons (e.g.,
Rewards, Login, Networks, Wallet actions).
> - **Config and tooling**:
> - Appwright project configs unchanged functionally (comment cleanup);
extend `.depcheckrc.yml` ignores for Appwright/Appium; minor test
config/timeouts.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
e34ae38. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>

Author: 3 people

.depcheckrc.yml

@@ -1,4 +1,5 @@
 # List things here that *are - 'used, that depcheck is wrong about'
+
 ignores:
   - '@metamask/oss-attribution-generator'
   - '@metamask/test-dapp-multichain'

.yarn/patches/appwright-npm-0.1.45-f282bc1c1b.patch

@@ -13,11 +13,107 @@ index a51913b3f9380fd5740b1d52cd1d3472e29233c3..6479c9b92ed17319f654e9323f689792
      reporter: [["list"], ["html", { open: "always" }]],
      use: {
          // TODO: Use this for actions
+diff --git a/dist/device/index.js b/dist/device/index.js
+index fda54b682837d06eb579596087826c862c35f33e..b61aceca45b8b3293dee14552c26f002b38a4e36 100644
+--- a/dist/device/index.js
++++ b/dist/device/index.js
+@@ -237,7 +237,7 @@ let Device = (() => {
+                 findStrategy: isAndroid
+                     ? "-android uiautomator"
+                     : "-ios predicate string",
+-                textToMatch: text,
++                textToMatch: null,
+             });
+         }
+         /**
+diff --git a/dist/locator/index.js b/dist/locator/index.js
+index 03f00574615d647d1887440ee7ae10798934c250..40089ce61ad598625afeb42d1149da8ce007dc26 100644
+--- a/dist/locator/index.js
++++ b/dist/locator/index.js
+@@ -244,51 +244,33 @@ let Locator = (() => {
+                 ]);
+             }
+         }
+-        /**
+-         * Retrieves the element reference based on the `selector`.
+-         *
+-         * @returns
+-         */
++
+         async getElement() {
+-            /**
+-             * Determine whether `path` is a regex or string, and find elements accordingly.
+-             *
+-             * If `path` is a regex:
+-             * - Iterate through all the elements on the page
+-             * - Extract text content of each element
+-             * - Return the first matching element
+-             *
+-             * If `path` is a string:
+-             * - Use `findStrategy` (either XPath, Android UIAutomator, or iOS predicate string) to find elements
+-             * - Apply regex to clean extra characters from the matched element’s text
+-             * - Return the first element that matches
+-             */
+-            let elements = await this.webDriverClient.findElements(this.findStrategy, this.selector);
+-            // If there is only one element, return it
+-            if (elements.length === 1) {
+-                return elements[0];
+-            }
+-            // If there are multiple elements, we reverse the order since the probability
+-            // of finding the element is higher at higher depth
++            const elements = await this.webDriverClient.findElements(this.findStrategy, this.selector);
+             const reversedElements = elements.reverse();
++            console.log('Reversed elements length', reversedElements.length);
++            // If no text matching is needed, just return the first (deepest) element
++            if (!this.textToMatch) {
++                console.log('No text to match, returning first element');
++                return reversedElements[0] || null;
++            }
++
++            // Only iterate and fetch text if we need to match text
+             for (const element of reversedElements) {
+                 let elementText = await this.webDriverClient.getElementText(element["element-6066-11e4-a52e-4f735466cecf"]);
+-                if (this.textToMatch) {
+-                    if (this.textToMatch instanceof RegExp &&
+-                        this.textToMatch.test(elementText)) {
+-                        return element;
+-                    }
+-                    if (typeof this.textToMatch === "string" &&
+-                        elementText.includes(this.textToMatch)) {
+-                        return element;
+-                    }
++                console.log('Element text', elementText);
++                console.log('Text to match', this.textToMatch);
++                
++                if (this.textToMatch instanceof RegExp &&
++                    this.textToMatch.test(elementText)) {
++                    return element;
+                 }
+-                else {
+-                    // This is returned for cases where xpath is findStrategy and we want
+-                    // to return the last element found in the list
++                if (typeof this.textToMatch === "string" &&
++                    elementText.includes(this.textToMatch)) {
+                     return element;
+                 }
+             }
++
+             return null;
+         }
+     };
 diff --git a/dist/providers/browserstack/index.js b/dist/providers/browserstack/index.js
-index 638c5df686413ffe050ef7e7329b9e9446e98002..61ecd1508400f59302d6139a805e7a912e9a1036 100644
+index 638c5df686413ffe050ef7e7329b9e9446e98002..34e211940e22cc195002e6d88a98d7b8488d88d0 100644
 --- a/dist/providers/browserstack/index.js
 +++ b/dist/providers/browserstack/index.js
-@@ -120,6 +120,12 @@ class BrowserStackDeviceProvider {
+@@ -104,6 +104,7 @@ class BrowserStackDeviceProvider {
+     async createDriver(config) {
+         const WebDriver = (await import("webdriver")).default;
+         const webDriverClient = await WebDriver.newSession(config);
++
+         this.sessionId = webDriverClient.sessionId;
+         const bundleId = await this.getAppBundleIdFromSession();
+         const testOptions = {
+@@ -120,6 +121,12 @@ class BrowserStackDeviceProvider {
          return this.sessionDetails?.app_details.app_name ?? "";
      }
      static async downloadVideo(sessionId, outputDir, fileName) {
@@ -30,7 +126,7 @@ index 638c5df686413ffe050ef7e7329b9e9446e98002..61ecd1508400f59302d6139a805e7a91
          const sessionData = await getSessionDetails(sessionId);
          const sessionDetails = sessionData?.automation_session;
          const videoURL = sessionDetails?.video_url;
-@@ -241,7 +247,10 @@ class BrowserStackDeviceProvider {
+@@ -241,7 +248,10 @@ class BrowserStackDeviceProvider {
              capabilities: {
                  "bstack:options": {
                      debug: true,
@@ -41,7 +137,7 @@ index 638c5df686413ffe050ef7e7329b9e9446e98002..61ecd1508400f59302d6139a805e7a91
                      networkLogs: true,
                      appiumVersion: "2.6.0",
                      enableCameraImageInjection: this.project.use.device?.enableCameraImageInjection,
-@@ -250,10 +259,10 @@ class BrowserStackDeviceProvider {
+@@ -250,10 +260,10 @@ class BrowserStackDeviceProvider {
                      osVersion: this.project.use.device.osVersion,
                      platformName: platformName,
                      deviceOrientation: this.project.use.device?.orientation,
@@ -54,144 +150,21 @@ index 638c5df686413ffe050ef7e7329b9e9446e98002..61ecd1508400f59302d6139a805e7a91
                          : process.env.USER,
                  },
                  "appium:autoGrantPermissions": true,
-@@ -261,6 +270,11 @@ class BrowserStackDeviceProvider {
+@@ -261,6 +271,17 @@ class BrowserStackDeviceProvider {
                  "appium:autoAcceptAlerts": true,
                  "appium:fullReset": true,
                  "appium:settings[snapshotMaxDepth]": 62,
 +                "appium:settings[autoGrantPermissions]": true,
-+                "appium:settings[waitForIdleTimeout]": 10000,
++                "appium:settings[waitForIdleTimeout]": 2000,
 +                "appium:settings[actionAcknowledgmentTimeout]": 3000,
 +                "appium:settings[ignoreUnimportantViews]": true,
-+                "appium:settings[waitForSelectorTimeout]": 10000,
++                "appium:settings[waitForSelectorTimeout]": 1000,
++                "appium:bstackPageSource": {
++                    "enable": true,
++                    "samplesX": 15,
++                    "samplesY": 15,
++                    "maxDepth": 75
++                }
              },
          };
      }
-diff --git a/dist/reporter.js b/dist/reporter.js
-index 516da403677d49af5fbb18edaf9f308dad401e55..ae1895be0513e2aa3ada45ad93a3f3c489e42911 100644
---- a/dist/reporter.js
-+++ b/dist/reporter.js
-@@ -6,8 +6,8 @@ Object.defineProperty(exports, "__esModule", { value: true });
- const providers_1 = require("./providers");
- const fs_1 = __importDefault(require("fs"));
- const path_1 = __importDefault(require("path"));
--const fluent_ffmpeg_1 = __importDefault(require("fluent-ffmpeg"));
--const ffmpeg_1 = __importDefault(require("@ffmpeg-installer/ffmpeg"));
-+// const fluent_ffmpeg_1 = __importDefault(require("fluent-ffmpeg"));
-+// const ffmpeg_1 = __importDefault(require("@ffmpeg-installer/ffmpeg"));
- const logger_1 = require("./logger");
- const utils_1 = require("./utils");
- const workerInfo_1 = require("./fixture/workerInfo");
-@@ -183,25 +183,32 @@ function trimVideo({ originalVideoPath, startSecs, durationSecs, outputPath, })
-     fs_1.default.copyFileSync(originalVideoPath, copyFullPath);
-     return new Promise((resolve, reject) => {
-         let stdErrs = "";
--        (0, fluent_ffmpeg_1.default)(copyFullPath)
--            .setFfmpegPath(ffmpeg_1.default.path)
--            .setStartTime(startSecs)
--            .setDuration(durationSecs)
--            .output(fullOutputPath)
--            .on("end", () => {
--            logger_1.logger.log(`Trimmed video saved at: ${fullOutputPath}`);
--            fs_1.default.unlinkSync(copyFullPath);
--            resolve(fullOutputPath);
--        })
--            .on("stderr", (stderrLine) => {
--            stdErrs += stderrLine + "\n";
--        })
--            .on("error", (err) => {
--            logger_1.logger.error("ffmpeg error:", err);
--            logger_1.logger.error("ffmpeg stderr:", stdErrs);
--            reject(err);
--        })
--            .run();
-+        // Video trimming disabled - ffmpeg removed
-+        // (0, fluent_ffmpeg_1.default)(copyFullPath)
-+        //     .setFfmpegPath(ffmpeg_1.default.path)
-+        //     .setStartTime(startSecs)
-+        //     .setDuration(durationSecs)
-+        //     .output(fullOutputPath)
-+        //     .on("end", () => {
-+        //     logger_1.logger.log(`Trimmed video saved at: ${fullOutputPath}`);
-+        //     fs_1.default.unlinkSync(copyFullPath);
-+        //     resolve(fullOutputPath);
-+        // })
-+        //     .on("stderr", (stderrLine) => {
-+        //     stdErrs += stderrLine + "\n";
-+        // })
-+        //     .on("error", (err) => {
-+        //     logger_1.logger.error("ffmpeg error:", err);
-+        //     logger_1.logger.error("ffmpeg stderr:", stdErrs);
-+        //     reject(err);
-+        // })
-+        //     .run();
-+        
-+        // Just copy the original video without trimming
-+        fs_1.default.copyFileSync(copyFullPath, fullOutputPath);
-+        fs_1.default.unlinkSync(copyFullPath);
-+        logger_1.logger.log(`Video copied without trimming: ${fullOutputPath}`);
-+        resolve(fullOutputPath);
-     });
- }
- async function getWorkerStartTime(idx) {
-diff --git a/dist/vision/index.js b/dist/vision/index.js
-index bf485308fe5ddde81b396bf87dbb365cc37efa0e..8e5f191e6b210c5839257bd6a1879b1f9ce45228 100644
---- a/dist/vision/index.js
-+++ b/dist/vision/index.js
-@@ -38,8 +38,8 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
- };
- Object.defineProperty(exports, "__esModule", { value: true });
- exports.VisionProvider = void 0;
--const vision_1 = require("@empiricalrun/llm/vision");
--const point_1 = require("@empiricalrun/llm/vision/point");
-+// const vision_1 = require("@empiricalrun/llm/vision");
-+// const point_1 = require("@empiricalrun/llm/vision/point");
- const fs_1 = __importDefault(require("fs"));
- const test_1 = __importDefault(require("@playwright/test"));
- const utils_1 = require("../utils");
-@@ -64,42 +64,12 @@ let VisionProvider = (() => {
-             this.webDriverClient = webDriverClient;
-         }
-         async query(prompt, options) {
--            test_1.default.skip(!process.env.OPENAI_API_KEY, "LLM vision based extract text is not enabled. Set the OPENAI_API_KEY environment variable to enable it");
--            let base64Screenshot = options?.screenshot;
--            if (!base64Screenshot) {
--                base64Screenshot = await this.webDriverClient.takeScreenshot();
--            }
--            return await (0, vision_1.query)(base64Screenshot, prompt, options);
-+            test_1.default.skip(true, "LLM vision based extract text is disabled - @empiricalrun/llm removed");
-+            throw new Error("LLM vision functionality has been disabled");
-         }
-         async tap(prompt, options) {
--            test_1.default.skip(!process.env.EMPIRICAL_API_KEY, "LLM vision based tap is not enabled. Set the EMPIRICAL_API_KEY environment variable to enable it");
--            const base64Image = await this.webDriverClient.takeScreenshot();
--            const coordinates = await (0, point_1.getCoordinatesFor)(prompt, base64Image, options);
--            if (coordinates.annotatedImage) {
--                const random = Math.floor(1000 + Math.random() * 9000);
--                const file = test_1.default.info().outputPath(`${random}.png`);
--                await fs_1.default.promises.writeFile(file, Buffer.from(coordinates.annotatedImage, "base64"));
--                await test_1.default.info().attach(`${random}`, { path: file });
--            }
--            const driverSize = await this.webDriverClient.getWindowRect();
--            const { container: imageSize, x, y } = coordinates;
--            const scaleFactorWidth = imageSize.width / driverSize.width;
--            const scaleFactorHeight = imageSize.height / driverSize.height;
--            if (scaleFactorWidth !== scaleFactorHeight) {
--                logger_1.logger.warn(`Scale factors are different: ${scaleFactorWidth} vs ${scaleFactorHeight}`);
--            }
--            const tapTargetX = x / scaleFactorWidth;
--            // This uses the width scale factor because getWindowRect on LambdaTest returns a smaller
--            // height value than the screenshot height, which causes disproportionate scaling
--            // for width and height.
--            // For example, Pixel 8 screenshot is 1080 (w) x 2400 (h), but LambdaTest returns
--            // 1080 (w) x 2142 (h) for getWindowRect.
--            const tapTargetY = y / scaleFactorWidth;
--            await this.device.tap({
--                x: tapTargetX,
--                y: tapTargetY,
--            });
--            return { x: tapTargetX, y: tapTargetY };
-+            test_1.default.skip(true, "LLM vision based tap is disabled - @empiricalrun/llm removed");
-+            throw new Error("LLM vision functionality has been disabled");
-         }
-     };
- })();

.yarn/patches/appwright-patch-bd36f2d657.patch

@@ -0,0 +1,26 @@
+diff --git a/dist/providers/browserstack/index.js b/dist/providers/browserstack/index.js
+index 61ecd1508400f59302d6139a805e7a912e9a1036..c7772bec15413478dd0d446f7c9f805e16b00851 100644
+--- a/dist/providers/browserstack/index.js
++++ b/dist/providers/browserstack/index.js
+@@ -104,6 +104,21 @@ class BrowserStackDeviceProvider {
+     async createDriver(config) {
+         const WebDriver = (await import("webdriver")).default;
+         const webDriverClient = await WebDriver.newSession(config);
++        await webDriverClient.updateSettings({
++            waitForIdleTimeout: 100,
++            waitForSelectorTimeout: 0,
++            shouldWaitForQuiescence: false,
++            snapshotMaxDepth: 62,
++            snapshotTimeout: 50000,
++            "appium:settings[snapshotMaxDepth]": 62,
++            "appium:settings[customSnapshotTimeout]": 50000,
++            "appium:bstackPageSource": {
++                "enable": true,
++                "samplesX": 15,
++                "samplesY": 15,
++                "maxDepth": 100
++            }
++        });
+         this.sessionId = webDriverClient.sessionId;
+         const bundleId = await this.getAppBundleIdFromSession();
+         const testOptions = {

appwright/appwright.config.ts

@@ -29,7 +29,7 @@ export default defineConfig({
           osVersion: '14', // this can be changed to your emulator version
         },
         buildPath: 'PATH-TO-BUILD', // Path to your .apk file
-        expectTimeout: 30 * 1000, //90 seconds  increased since login the app takes longer
+        expectTimeout: 30 * 1000,
       },
     },
     {
@@ -42,7 +42,7 @@ export default defineConfig({
           osVersion: '16.0', // this can be changed to your simulator version
         },
         buildPath: 'PATH-TO-BUILD', // Path to your .app file
-        expectTimeout: 30 * 1000, //90 seconds  increased since login the app takes longer
+        expectTimeout: 30 * 1000,
       },
     },
     {
@@ -56,7 +56,7 @@ export default defineConfig({
           osVersion: process.env.BROWSERSTACK_OS_VERSION || '13.0', // this can changed
         },
         buildPath: process.env.BROWSERSTACK_ANDROID_APP_URL, // Path to Browserstack url
-        expectTimeout: 30 * 1000, //90 seconds  increased since login the app takes longer
+        expectTimeout: 30 * 1000,
       },
     },
     {
@@ -70,7 +70,7 @@ export default defineConfig({
           osVersion: process.env.BROWSERSTACK_OS_VERSION || '16.0',
         },
         buildPath: process.env.BROWSERSTACK_IOS_APP_URL,
-        expectTimeout: 30 * 1000, //90 seconds  increased since login the app takes longer
+        expectTimeout: 30 * 1000,
       },
     },
     {
@@ -84,7 +84,7 @@ export default defineConfig({
           osVersion: process.env.BROWSERSTACK_OS_VERSION || '13.0',
         },
         buildPath: process.env.BROWSERSTACK_ANDROID_CLEAN_APP_URL,
-        expectTimeout: 30 * 1000, //90 seconds  increased since login the app takes longer
+        expectTimeout: 30 * 1000,
       },
     },
     {
@@ -98,7 +98,7 @@ export default defineConfig({
           osVersion: process.env.BROWSERSTACK_OS_VERSION || '16.0',
         },
         buildPath: process.env.BROWSERSTACK_IOS_CLEAN_APP_URL,
-        expectTimeout: 30 * 1000, //90 seconds  increased since login the app takes longer
+        expectTimeout: 30 * 1000,
       },
     },
   ],