[pull] main from MetaMask:main#134
Merged
Merged
Conversation
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** After a chain switch from the SDK, we confirm that the action was successfully completed before redirecting the user back to the original app. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Add confirmation message after network switch from SDK ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/WAPI-402 ## **Manual testing steps** ```gherkin Feature: add confirmation message after network switch from SDK Scenario: user switch chain from an app using our MM SDK Given the user is already connected to an App using our SDK When user switch chain and is redirected to MM Mobile Then MM Mobile confirm the chain switch, and ask the user to go back to the origin app ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/eea7989e-f35a-43ea-87a2-be52494dec88 ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->
## **Description**
Move ios E2E tests to a specific workflow
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
## **Changelog**
<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`
If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`
(This helps the Release Engineer do their job more quickly and
accurately)
-->
CHANGELOG entry:
## **Related issues**
Fixes:
## **Manual testing steps**
```gherkin
Feature: my feature name
Scenario: user [verb for user action]
Given [describe expected initial app state]
When user [verb for user action]
Then [describe expected outcome]
```
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **Before**
<!-- [screenshots/recordings] -->
### **After**
<!-- [screenshots/recordings] -->
## **Pre-merge author checklist**
- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR adds performance tracing for the following multichain account operations: - Create multichain account - Display account list - Display account address list - Display account private key list <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> <!-- ## **Changelog** --> <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> <!-- CHANGELOG entry: null --> ## **Related issues** Fixes: [MUL-671](https://consensyssoftware.atlassian.net/browse/MUL-671) ## **Manual testing steps** 1. Enable MetaMetrics by enabling **Settings** > **Security & Privacy** > **Participate in MetaMetrics** 2. Perform each one of the actions that should be tracked 3. At Sentry, on the [**Multichain Account** dashboard](https://metamask.sentry.io/dashboard/148512/), ensure that your actions were traced Alternatively, you can apply the following patch, and it should log the traces to the console: ```diff diff --git a/app/util/trace.ts b/app/util/trace.ts index 5b03ec5..dd65739960 100644 --- a/app/util/trace.ts +++ b/app/util/trace.ts @@ -175,6 +175,13 @@ export enum TraceOperation { PerpsPositionManagement = 'perps.position_management', } +const SHOULD_LOG = [ + TraceName.CreateMultichainAccount, + TraceName.AccountList, + TraceName.AccountAddressList, + TraceName.AccountPrivateKeyList, +]; + const ID_DEFAULT = 'default'; const OP_DEFAULT = 'custom'; export const TRACES_CLEANUP_INTERVAL = 5 * 60 * 1000; // 5 minutes @@ -345,6 +352,17 @@ export function endTrace(request: EndTraceRequest): void { const endTime = timestamp ?? getPerformanceTimestamp(); const duration = endTime - startTime; + if (SHOULD_LOG.includes(name)) { + /* eslint-disable no-console */ + console.log('=========================================================='); + console.log('>>> END TRACE'); + console.log('>>>'); + console.log('>>> Name:', name); + console.log('>>> Duration:', duration, 'ms'); + console.log('=========================================================='); + /* eslint-enable no-console */ + } + log('Finished trace', name, id, duration, { request: pendingRequest }); } @@ -566,6 +584,16 @@ function startTrace(request: TraceRequest): TraceContext { log('Started trace', name, id, request); + if (SHOULD_LOG.includes(name)) { + /* eslint-disable no-console */ + console.log('=========================================================='); + console.log('>>> START TRACE'); + console.log('>>>'); + console.log('>>> Name:', name); + console.log('=========================================================='); + /* eslint-enable no-console */ + } + return span; }; ``` <!-- ## **Screenshots/Recordings** --> <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> <!-- ### **Before** --> <!-- [screenshots/recordings] --> <!-- ### **After** --> <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. [MUL-671]: https://consensyssoftware.atlassian.net/browse/MUL-671?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
…"Add Funds" on PerpsMarketDetailsView (#19407) …nd clicks add funds on MarketDetailsView <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Adds missing eligibility check and geo block modal for the "Add funds" button in `PerpsMarketDetailsView`. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Added geo block modal when user clicks add funds on PerpsMarketDetailsView ## **Related issues** Fixes: [TAT-1537: Geo-blocked users can add funds on PerpsMarketDetailsView](https://consensyssoftware.atlassian.net/browse/TAT-1537) ## **Manual testing steps** ```gherkin Feature: Geo block modal on PerpsMarketDetailsView Scenario: User attempts to add funds to Perps account Given user is geo-blocked When user clicks "Add funds" on PerpsMarketDetailsView Then user sees geo block bottom sheet ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/0c966321-6864-40f4-83ec-186e35af34ed ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
…19396) ## **Description** 1. What is the reason for the change? - Fix azzicon, Blockies and Maskicon icon generation for CAIP-10 addresses (MetaMask/metamask-design-system#816). - This update ensures that the icon generated from a CAIP-10 address and a raw addresss (eip155:0:0x123 vs 0x123) are the same. 2. What is the improvement/solution? - Update package with fix Unblocks: #17793 ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: https://consensys.slack.com/archives/C0354T27M5M/p1755831342881179 ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
#19376) ## **Description** Fixed liquidation price calculation to use the correct entry price for limit orders. Previously, liquidation price was always calculated using the current market price, even for limit orders. This was incorrect because limit orders execute at the limit price, not the market price. **What is the reason for the change?** - Liquidation price displayed incorrect values for limit orders, showing calculations based on market price instead of limit price - Users couldn't accurately assess liquidation risk when placing limit orders - Both the main trading screen and leverage bottom sheet showed inconsistent liquidation prices **What is the improvement/solution?** - Updated liquidation price calculation logic to use limit price as entry price for limit orders - Market orders continue to use market price (preserving existing behavior) - Applied consistent logic across both PerpsOrderView (main screen) and PerpsLeverageBottomSheet - Real-time updates when switching between order types or changing limit prices ## **Changelog** CHANGELOG entry: Fixed liquidation price calculation for limit orders in trading screen and leverage modal ## **Related issues** Fixes: TAT-1577 ## **Manual testing steps** ```gherkin Feature: Liquidation price calculation for limit orders Scenario: user creates a limit order and sees correct liquidation price Given user is on the trading screen And current BTC price is $50,000 And user has selected "Long" direction And user has set leverage to 10x When user switches from "Market" to "Limit" order type And user sets limit price to $48,000 Then liquidation price should be calculated based on $48,000 entry price And liquidation price should update when limit price changes Scenario: user opens leverage modal with limit order Given user has a limit order configured with limit price $48,000 And user has 10x leverage selected When user opens the leverage bottom sheet Then liquidation price in the modal should match main screen And liquidation price should be based on $48,000 limit price, not current market price Scenario: user switches back to market order Given user has a limit order configured When user switches back to "Market" order type Then liquidation price should revert to using current market price And behavior should match original implementation ``` ## **Screenshots/Recordings** ### **Before** - Liquidation price always calculated using market price ($50,000) - Inconsistent risk assessment for limit orders - User sees incorrect liquidation distance ### **After** - Liquidation price correctly calculated using limit price ($48,000) for limit orders - Accurate risk assessment for all order types - Consistent display across main screen and leverage modal ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. Co-authored-by: dylanbutler1 <99672693+dylanbutler1@users.noreply.github.com> Co-authored-by: Matthew Grainger <46547583+Matt561@users.noreply.github.com>
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** 1. What is the reason for the change? There were a few issues with tutorial flow. On android there was a double continue when button was clicked and also we sometimes would redirect to the last page instead of defaulting to the markets list view. Also the wallet action button did not have a tutorial condition on it 2. What is the improvement/solution? Ensure that we can not double click buttons. Ensure that we are defaulting to the markets list view on escape routes. Wallet action button now has a tutorial condition on it when the user is a first time user <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/TAT-1378 ## **Manual testing steps** ```gherkin Feature: tutorial navigation fix Scenario: user is a first time user and is not geoblocked entering from GTM full screen perps ad Given user enters the tutorial from the GTM full screen perps ad When user clicks start trading and goes through the flow of tutorial Then if they click skip or got it they will go to the markets list Scenario: user is a first time user and is geoblocked entering from GTM full screen perps ad Given user enters the tutorial from the GTM full screen perps ad When user clicks start trading and goes through the flow of tutorial Then if they click skip or got it they will go to the markets list Scenario: user is a first time user and is not geoblocked and has clicked not now on GTM full screen perps ad Given user enters the tutorial from the wallet view perps tab When user clicks start trading and goes through the flow of tutorial Then if they click skip or got it they will go to the markets list Scenario: user is a first time user and is geoblocked and has clicked not now on GTM full screen perps ad Given user enters the tutorial from the wallet view perps tab When user clicks start trading and goes through the flow of tutorial Then if they click skip or got it they will go to the markets list Scenario: user is a first time user Given user is logged in When user clicks on the wallet action button for perps Then the tutorial shows ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** https://www.loom.com/share/281f4e93c36843e7abe8ce7ab7482a52?sid=ea06fb96-65ca-412a-b62f-bae023440a3d <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->
## **Description**
This PR add a GH Action that runs nightly at 11 pm UTC. It creates a
temporary branch based on main for the nightly build automation to run
against. To publish iOS builds the build number needs to increment but
our action should not have permission to push to main this means we need
a temporary branch to be created for nightly builds.
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
## **Changelog**
<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`
If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`
(This helps the Release Engineer do their job more quickly and
accurately)
-->
CHANGELOG entry:
## **Related issues**
Fixes:
## **Manual testing steps**
```gherkin
Feature: my feature name
Scenario: user [verb for user action]
Given [describe expected initial app state]
When user [verb for user action]
Then [describe expected outcome]
```
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **Before**
<!-- [screenshots/recordings] -->
### **After**
<!-- [screenshots/recordings] -->
## **Pre-merge author checklist**
- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )