[pull] main from MetaMask:main#359
Merged
Merged
Conversation
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** - Replace Text imports from component-library with @metamask/design-system-react-native - Update Text variant names to match design system conventions: - HeadingMD → HeadingMd, HeadingSM → HeadingSm - BodyMDMedium → BodyMd, BodyLGMedium → BodyLg - BodySM → BodySm, BodySMMedium → BodySm - BodyXS → BodyXs - Update TextColor enum values to design system tokens: - Default → TextDefault - Alternative → TextAlternative - Success → SuccessDefault - Error → ErrorDefault - Muted → TextMuted - Inverse → PrimaryInverse - Add twClassName='font-medium' to Text components that previously used Medium variants (BodyMDMedium, BodyLGMedium, BodySMMedium) to preserve font weight - Remove unused fontStyles import in PredictSellPreview.styles.ts - Replace fontStyles.bold with fontWeight: 'bold' Affected components: - PredictMarketOutcome - PredictSellPreview - PredictBuyPreview - PredictMarketDetails <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/PRED-310?atlOrigin=eyJpIjoiOTE5YjJjNmRjOTAzNDU3N2EwZTQwNDcwMjJhMmViZGIiLCJwIjoiaiJ9 ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Replaces legacy Text usage with @metamask/design-system-react-native across Predict screens, updating variants/colors and preserving weights, plus minor style cleanup. > > - **UI/Design System Migration** > - Replace `component-library` `Text` with `@metamask/design-system-react-native` `Text` across Predict screens. > - Update typography variants (e.g., `HeadingMD/SM` → `HeadingMd/Sm`, `Body*Medium` → `Body*` + `font-medium`, `BodyXS/SM/MD/LG` → `BodyXs/Sm/Md/Lg`). > - Map color tokens to design system equivalents (`Default` → `TextDefault`, `Alternative` → `TextAlternative`, `Success` → `SuccessDefault`, `Error` → `ErrorDefault`, `Muted` → `TextMuted`, `Inverse` → `PrimaryInverse`). > - **Components Updated** > - `PredictMarketOutcome`: Heading/body/text colors and winner/loser/price labels updated to new tokens and variants. > - `PredictBuyPreview`: Header, balance, errors, "to win", CTA labels, and disclaimers migrated to new variants/colors. > - `PredictMarketDetails`: Header title, tabs, status/messages, about section, resolved/outcomes chips, footnote text migrated to new variants/colors. > - `PredictSellPreview`: Header, cash-out values/PnL, info text, CTA, footnote migrated to new variants/colors. > - **Styles Cleanup** > - `PredictSellPreview.styles.ts`: remove `fontStyles` import and use `fontWeight: 'bold'`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 3b752a3. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )