Skip to content

[pull] main from MetaMask:main #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 4 commits into from
Dec 10, 2025
Merged

[pull] main from MetaMask:main #397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f5607c9
test: move performance test for Predict Market Details to login confi…
chrisleewilcox Dec 10, 2025
ef52fb0
feat(ramps): cp-7.61.0 unifies ramp entrypoint analytics (#23825)
georgeweiler Dec 10, 2025
7076cd2
refactor: deprecate legacy useBlockExplorer hook (#23628)
GeorgeGkas Dec 10, 2025
7879c4f
fix(SDKConnectV2): address connection failure toast on MMConnect inte…
ffmcgee725 Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions app/components/UI/AssetOverview/AssetOverview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ import { selectTronResourcesBySelectedAccountGroup } from '../../../selectors/as
import { createStakedTrxAsset } from './utils/createStakedTrxAsset';
///: END:ONLY_INCLUDE_IF
import { getDetectedGeolocation } from '../../../reducers/fiatOrders';
import { useRampsButtonClickData } from '../Ramp/hooks/useRampsButtonClickData';

interface AssetOverviewProps {
asset: TokenI;
Expand Down Expand Up @@ -171,7 +172,7 @@ const AssetOverview: React.FC<AssetOverviewProps> = ({

const currentAddress = asset.address as Hex;
const { goToBuy } = useRampNavigation();

const rampsButtonClickData = useRampsButtonClickData();
const { data: prices = [], isLoading } = useTokenHistoricalPrices({
asset,
address: currentAddress,
Expand Down Expand Up @@ -340,18 +341,23 @@ const AssetOverview: React.FC<AssetOverviewProps> = ({
assetId = undefined;
}

goToBuy({ assetId });

trackEvent(
createEventBuilder(MetaMetricsEvents.BUY_BUTTON_CLICKED)
createEventBuilder(MetaMetricsEvents.RAMPS_BUTTON_CLICKED)
.addProperties({
text: 'Buy',
location: 'TokenDetails',
chain_id_destination: getDecimalChainId(chainId),
ramp_type: 'BUY',
region: rampGeodetectedRegion,
ramp_routing: rampsButtonClickData.ramp_routing,
is_authenticated: rampsButtonClickData.is_authenticated,
preferred_provider: rampsButtonClickData.preferred_provider,
order_count: rampsButtonClickData.order_count,
})
.build(),
);

goToBuy({ assetId });
};

const goToBrowserUrl = (url: string) => {
Expand Down
1 change: 0 additions & 1 deletion app/components/UI/BalanceEmptyState/BalanceEmptyState.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ const mockEventBuilder = {
jest.mock('../../hooks/useMetrics', () => ({
useMetrics: jest.fn(),
MetaMetricsEvents: {
BUY_BUTTON_CLICKED: 'buy_button_clicked',
RAMPS_BUTTON_CLICKED: 'ramps_button_clicked',
},
}));
Expand Down
4 changes: 0 additions & 4 deletions app/components/UI/BalanceEmptyState/BalanceEmptyState.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,6 @@ const BalanceEmptyState: React.FC<BalanceEmptyStateProps> = ({
const handleAction = () => {
goToBuy();

trackEvent(
createEventBuilder(MetaMetricsEvents.BUY_BUTTON_CLICKED).build(),
);

trackEvent(
createEventBuilder(MetaMetricsEvents.RAMPS_BUTTON_CLICKED)
.addProperties({
Expand Down
Loading
Loading