Skip to content

[pull] main from MetaMask:main#404

Merged
pull[bot] merged 1 commit into
Reality2byte:mainfrom
MetaMask:main
Dec 12, 2025
Merged

[pull] main from MetaMask:main#404
pull[bot] merged 1 commit into
Reality2byte:mainfrom
MetaMask:main

Conversation

@pull
Copy link
Copy Markdown

@pull pull Bot commented Dec 12, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

Adds QuickNode Failover for Monad. This needs a migration as Monad is
already in prod.

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: added QuickNode fallback RPC for Monad.

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Adds migration to set QuickNode failover URLs for Monad, refactors SEI
migration to a shared util, updates configs, and expands tests.
> 
> - **Migrations**:
> - **109 (Monad)**: Adds `failoverUrls` to
`NetworkController.networkConfigurationsByChainId['0x8f']` RPC endpoints
using `process.env.QUICKNODE_MONAD_URL`.
>   - **107 (SEI)**: Refactored to use shared helper.
>   - Registered `109` in `migrationList` and async pipeline.
> - **Migration Utility**:
> - New `addFailoverUrlToNetworkConfiguration(state, chainId, version,
name, envVar)` with validation and Sentry error handling; reused by
107/109.
> - **Networks config**:
> - Added `'monad-mainnet'` QuickNode mapping and enabled failover URLs
for Monad in `PopularList`.
> - **Tests**:
> - New `109.test.ts` covering happy path, invalid states, and env-var
behavior.
> - Updated `107.test.ts` to spy `ensureValidState` and align
expectations.
>   - Extended `util/index.test.ts` for the new helper.
> - Added `QUICKNODE_MONAD_URL` to network-controller utils test env
setup.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
7388fc9. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@pull pull Bot locked and limited conversation to collaborators Dec 12, 2025
@pull pull Bot added the ⤵️ pull label Dec 12, 2025
@pull pull Bot merged commit 3d81cde into Reality2byte:main Dec 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant